From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA2F8C61D85 for ; Thu, 23 Nov 2023 06:32:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 50A236B0646; Thu, 23 Nov 2023 01:32:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4BAD26B0647; Thu, 23 Nov 2023 01:32:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3821D6B0648; Thu, 23 Nov 2023 01:32:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 282F06B0646 for ; Thu, 23 Nov 2023 01:32:36 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EF8FE401D6 for ; Thu, 23 Nov 2023 06:32:35 +0000 (UTC) X-FDA: 81488250270.20.765798D Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by imf02.hostedemail.com (Postfix) with ESMTP id E208A80022 for ; Thu, 23 Nov 2023 06:32:33 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=VXU5fQtp; spf=pass (imf02.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700721154; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V1iEv4pEEB/f9zYSljlSJ4XziP844i0g8GG1/fVd57I=; b=P7gIVINK22JBzWhzFTmj4AnbFqeWg/uol8l+NhZTCyjf0Bwhjv8qcbKUbmmnJhtlrwcBWr ICCrgOo9oyQrXIDj2KcAPEcLdbamZ8/HdctqPXV39lDCZ3BtnQDcKpZq0Br2cxAvkypdZ6 29C/jqkgxWJQrHpHls0HC94t+n2ToUU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700721154; a=rsa-sha256; cv=none; b=E5/+lKLEgLAIdP7bQxvzVLSFzP1mltKdxnsyYBuCQwtUKqvw7mjm8nSZUMuBAatpmFl9Ih /br6UX60Sprmgc5/zawBQfvW1Ms/D9kFfH6Zl9wdM63DdZ8AUm1fwfAHr/B5uxAA3uZAxr yP90UIZH8xXIOZqN0vCaGi5u9de+6LI= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=VXU5fQtp; spf=pass (imf02.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700721154; x=1732257154; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=rY/TBxnNGUbD9+yFwuL9Z437C7emu75hU1E4ZvjYwlQ=; b=VXU5fQtpHvgi07DzrVzXlB/AsTojgQpAtz8SSZ9TPo1f1aqxFM1RXs0f eaiLXHqy0F1WEWlDVVPES/zSPiUQxSNRXu6yKZwRAnKjefeZiBnUwl+El h/Y8pfofXZARgfHqrihpmAGuzIcdYTqz8ejqFdkIEAxUKq1atbSxo7GRt WNzKDZbS6RE+bTdJfMY2/4Ry/0aBO9xdPsGyCdYcSajhh86bISj6XNYM6 yucEXjdjppz12AmF4cjFn3Qx1Al6yzhT7KAZb0X5UuD4JWyi4aB4AuYyQ CCdd0lY7zW8eLf2KIgSYc3vw1O8rtf0+NqfrQ202et++lvq49FGGcQsVg w==; X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="382607310" X-IronPort-AV: E=Sophos;i="6.04,220,1695711600"; d="scan'208";a="382607310" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 22:32:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="858029742" X-IronPort-AV: E=Sophos;i="6.04,220,1695711600"; d="scan'208";a="858029742" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 22:32:28 -0800 From: "Huang, Ying" To: Yafang Shao Cc: akpm@linux-foundation.org, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, omosnace@redhat.com, mhocko@suse.com, linux-mm@kvack.org, linux-security-module@vger.kernel.org, bpf@vger.kernel.org, ligang.bdlg@bytedance.com, Eric Dumazet Subject: Re: [RFC PATCH v2 2/6] mm: mempolicy: Revise comment regarding mempolicy mode flags In-Reply-To: <20231122141559.4228-3-laoar.shao@gmail.com> (Yafang Shao's message of "Wed, 22 Nov 2023 14:15:55 +0000") References: <20231122141559.4228-1-laoar.shao@gmail.com> <20231122141559.4228-3-laoar.shao@gmail.com> Date: Thu, 23 Nov 2023 14:30:28 +0800 Message-ID: <87il5t7zi3.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Queue-Id: E208A80022 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 3e6iwkofsnhseqfjopyu9paac376u4zs X-HE-Tag: 1700721153-422261 X-HE-Meta: U2FsdGVkX1+nFxcLrm7ciu20HeATJ+z7WngCEZuioRgyejLPd+va5hQF8wdtOcrcMbHDAbaZj2lqaZ1uX0z/Dc6HNCvjfnANa1nHEw5iPNDxtPV2TJ0u+5OxoyoY1I9HHAUIgfkpQeC+yvxQvg7BoX2bqf2p6zLQG5TrayN+Cf754YmE8NfARBHHRtJaRne2w9H+eRPmhHOy2WJ6e/iFFo2y8PGQqwMbGQXzxIV2QbaQjfsrFgrwp1htJZZxQK0ZAbsua+owx5FRhv6tPUf7ZqylDgwi+uCjfFt1RuBBagx/cl3Rx+71NHVucOzyBqK4YXhr1oBrYOmzyIFT5+/upLiXz0sYKqPgwxsIZv2Tn1FBOBO75OHDVh/ljIcYzR3KJw26xNt9x1h938UB+AHEk61EtMYnwKL8wsiVhxnR2QXUwZRZ/YEbVqr57CIhFXy25DLw+woJqekNOlcotcZQQQVm2NBc9DeoCBybSlxGM1QVWE/HVvdBg3KtjMnCbQVgmUlrI0Co+eUTu4f5u9fScKZY2jqUnln8osY40mzR/OU6gYOAw9X2zgjMS1m14iM+E4JM/c27Yk/COyvcQmkMljGAsnE4hclocZL8in+S6uRD8d2ZAFATEBwWHgJvRjYOOl5kiqnGfaDSEPJ8xEpoZ5eQRSrI55lA/T6Rnwoveic3xZUUWAkJFwkRow5AKjc+pbbeEwNOLgH4sPWUK1S59JawvWL3DcfRyvUvcVlAxlYPTaeiEHDI9pcq7eiCe0c6fYQP8sUwb8Gtzj9oMJ9SgfoggJ9H2LwBMsuXRxHcKHBOeT6VQKw46IN9ttiA0BuNtYjevOwnN9k0c+NZ+Qb6xOK7vh/xoO0Aw+a2af0t1mdeJvpaDcTaWyrLay5BTKzxis/JcgZ53OJTZTtqBwye0vyUzKS4MO8MYOumnwBujl8F/emcgkIEjlvT4DyPdvBrEqRHZV09zB7LhJpJk97 IcHp4rtH D5Ns3lyH3gepvqg/6hYcZkBCc6fzZ1tAgWZXfMi9OHC9kJLPK0NalY5SgoNGHK9q3JJNhc+HUMxyL4P1qglTqdc9lAwcuMMSPYT6vVK1mmmxOoPnr4rkcqQ6wyhACHlilR98npuy3bFjcq+lMlx0SHceRB3+g5swgNCerreIzti2czIoppq6+6Bj9ILI3rC9tmLAxCIWUrvMVofNzVMHi1irDPdW458UqXPBHY596NeITvm6VIpLn71hfSuaOs+BupOWcQnUWWvYehZvDHczteiIn5THOD1aANjCxS1/OWJvP4acWAqauGVoaFB4WxgtX/BeDR7H2x8XZ3c4GKKYHpBLEfevCImIN+bwn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Yafang Shao writes: > MPOL_F_STATIC_NODES, MPOL_F_RELATIVE_NODES, and MPOL_F_NUMA_BALANCING are > mode flags applicable to both set_mempolicy(2) and mbind(2) system calls. > It's worth noting that MPOL_F_NUMA_BALANCING was initially introduced in > commit bda420b98505 ("numa balancing: migrate on fault among multiple bound > nodes") exclusively for set_mempolicy(2). However, it was later made a > shared flag for both set_mempolicy(2) and mbind(2) following > commit 6d2aec9e123b ("mm/mempolicy: do not allow illegal > MPOL_F_NUMA_BALANCING | MPOL_LOCAL in mbind()"). > > This revised version aims to clarify the details regarding the mode flags. > > Signed-off-by: Yafang Shao > Cc: Eric Dumazet > Cc: "Huang, Ying" Thanks for fixing this. Reviewed-by: "Huang, Ying" And, please revise the manpage for mbind() too. As we have done for set_mempolicy(), https://lore.kernel.org/all/20210120061235.148637-3-ying.huang@intel.com/ -- Best Regards, Huang, Ying > --- > include/uapi/linux/mempolicy.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/linux/mempolicy.h b/include/uapi/linux/mempolicy.h > index a8963f7ef4c2..afed4a45f5b9 100644 > --- a/include/uapi/linux/mempolicy.h > +++ b/include/uapi/linux/mempolicy.h > @@ -26,7 +26,7 @@ enum { > MPOL_MAX, /* always last member of enum */ > }; > > -/* Flags for set_mempolicy */ > +/* Flags for set_mempolicy() or mbind() */ > #define MPOL_F_STATIC_NODES (1 << 15) > #define MPOL_F_RELATIVE_NODES (1 << 14) > #define MPOL_F_NUMA_BALANCING (1 << 13) /* Optimize with NUMA balancing if possible */