From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57CEAC47DDB for ; Fri, 26 Jan 2024 17:30:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 61D2B6B0087; Fri, 26 Jan 2024 12:30:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A6576B0092; Fri, 26 Jan 2024 12:30:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 420206B0095; Fri, 26 Jan 2024 12:30:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2FA8E6B0087 for ; Fri, 26 Jan 2024 12:30:08 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E91951207B9 for ; Fri, 26 Jan 2024 17:30:07 +0000 (UTC) X-FDA: 81722150454.10.C459214 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf04.hostedemail.com (Postfix) with ESMTP id DA52440023 for ; Fri, 26 Jan 2024 17:30:05 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=bGdeKoUW; dkim=pass header.d=linutronix.de header.s=2020e header.b=tuzagaiU; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf04.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706290206; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y16NGcUWXAd/jpol4Aw++3XVEwkU5CL0GFzr1MU53XY=; b=X0xwM5yN2KqFW4jU4T2t2y/uj+yJ5yRmtMpjmxPck6quQrS7278EVi86XOrA4Y8Um/h3/b iH4h0pqFR+15WS2cS5TXoqBsiDtcje0BO5IMkcPFGYddVSAXIN4sk7a5XduqLkhF1LRv5U zM1LWDO2yWp+67Nk2J9qavQhm8pGIU8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=bGdeKoUW; dkim=pass header.d=linutronix.de header.s=2020e header.b=tuzagaiU; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf04.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706290206; a=rsa-sha256; cv=none; b=CFAq9CC1h2St2Ky1jEkk9zEb5kp3E83bQkZkr4SpnnusI/IAo3BXOZJTspyYYhCLc/8Yrq s3D4fFz9ih5ASqvI3jE7WlB7StjeUG9dq0NrqheD2S+dYG4mE1REwVQLBWiqyxIGysTlvc lD0ckWz17yS7lPFjvriKYvtiWJcntjo= From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1706290203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=y16NGcUWXAd/jpol4Aw++3XVEwkU5CL0GFzr1MU53XY=; b=bGdeKoUW9WdLqEtKEsxkWkPluiF27VXCxZSKAv3EF91of84hHPJu/t+7B9mlIfqDmwyhVQ 5Wy0Ak8LYkBMFC536ObQrarSAFKXlxaX18tfj4mZezpiUfaQdkDMG9wQCtqs11xhoOwLv7 pA8thEtSPHwm3lmTvJ07FPxtZYE52z+dy31Yz3fjNkM6LKIgSZ5nuds6Q52aKp/nVmBSyY +spk4CBBiK/sbO9HcOKfH2EIVtfT4fH6iY90wZoZZeksjxdCmGo7r0pBec73lzMMxFQhVc xpFa/bEbvEtI2gao8tw9CtiPgX/FYFPnpnN4YzjNzl3kjaWgFj/y/mmB8OSJKQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1706290203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=y16NGcUWXAd/jpol4Aw++3XVEwkU5CL0GFzr1MU53XY=; b=tuzagaiUxCjRffYVMgp6n3kaVE2tR+Ydl0coEnXTNFJKMgQQ2tLfSrtS+THdp+B8unTwvq SjL+Cz4iYZ9oxJBQ== To: Byungchul Park , linux-kernel@vger.kernel.org Cc: kernel_team@skhynix.com, torvalds@linux-foundation.org, damien.lemoal@opensource.wdc.com, linux-ide@vger.kernel.org, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, will@kernel.org, rostedt@goodmis.org, joel@joelfernandes.org, sashal@kernel.org, daniel.vetter@ffwll.ch, duyuyang@gmail.com, johannes.berg@intel.com, tj@kernel.org, tytso@mit.edu, willy@infradead.org, david@fromorbit.com, amir73il@gmail.com, gregkh@linuxfoundation.org, kernel-team@lge.com, linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@kernel.org, minchan@kernel.org, hannes@cmpxchg.org, vdavydov.dev@gmail.com, sj@kernel.org, jglisse@redhat.com, dennis@kernel.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, vbabka@suse.cz, ngupta@vflare.org, linux-block@vger.kernel.org, josef@toxicpanda.com, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, jlayton@kernel.org, dan.j.williams@intel.com, hch@infradead.org, djwong@kernel.org, dri-devel@lists.freedesktop.org, rodrigosiqueiramelo@gmail.com, melissa.srw@gmail.com, hamohammed.sa@gmail.com, 42.hyeyoo@gmail.com, chris.p.wilson@intel.com, gwan-gyeong.mun@intel.com, max.byungchul.park@gmail.com, boqun.feng@gmail.com, longman@redhat.com, hdanton@sina.com, her0gyugyu@gmail.com Subject: Re: [PATCH v11 14/26] locking/lockdep, cpu/hotplus: Use a weaker annotation in AP thread In-Reply-To: <20240124115938.80132-15-byungchul@sk.com> References: <20240124115938.80132-1-byungchul@sk.com> <20240124115938.80132-15-byungchul@sk.com> Date: Fri, 26 Jan 2024 18:30:02 +0100 Message-ID: <87il3ggfz9.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: DA52440023 X-Stat-Signature: 5brsyhxjmfkftf34n66x49y5f8oehnhb X-HE-Tag: 1706290205-890486 X-HE-Meta: U2FsdGVkX19wdKXhMQo7mjNSusyugs0g6x3yiWUeUi7h6zUWdZL57elNA4mwU9Fvd0m3U+NEhDfgBE8Vm4mx1OkN3tnEiEyvp4DxadlcXBcAnKsEWYp7PmZfAUPVuPm+nv5+NPttZSR8awFkg6QU2JNTxDDgs4BO84R6WVh5HkAn+tKUoHDB8EoaTUrTTUZMm4Z4crHRNhtbkOZDSb4MM/Nm93gCVFmfAZX+VR+9O0UjdrWjtjp3d9k0wo2Wdt7D9XZ0qcPD6L41PyixwaoHtTZ80t/KW/af+8m/0gyw27R8I3+DWJj1Vgmd7hzT2yeCDwKP8RnMFFP22CgoylweLJacPYfzLdchB4US/7C5RvtgrVziOZHUa1ShXgF1ucTdZy2bDy0tB3mz2RquXIEsl6JefBjtILk2k+7OFZEfNhkjGcURubvANDcvzsysg5EAA0qc34EzAHgi9YfATiS1LPHVsi3/pV2bExClIX/d9EJrv+EVeuyAJcPLkK+skmFvA6xZWzIL217H3SUEIUDtOyFkL5k4ed1b2oSbHUP3xmMzarQfsnXV9jg3UUYZH13iwy1XA9wtWNMlLK37sy6bq2Zy1TlEKBMOdoEV+edHD9lXK1MmkwymghNUxcGUNu9StBFJ5JoId8EDxxck/ebync10MVb5Nb1g2RX3oTiry6MnlquVWsmh1jmCHF1VpY8NVtg8fxgs7I+YouZWsSLUFGrF8Qr3oZ0KIvYEnlxNVKcZ0jrosCia8oYgzQgVkT7YKY9OKDm0v99UUQ7obVPEppdX8+QTlMYsdqETasU6CVvED7vrN4u7uuMZdaK6hhRTFEVrzQRGIYHAFrT9Rnp8u8eI8cRVWq5QWAcJ5XnQyhiZ2FVmen+GFxwb4P3ejq0j0YYuwV7YizhiLzGEh3LmlR5VNg4/bqVymxc1SqwzohO0AY0C4FCw9rtTsf/Po1JVXFwrirchxBfCx43pHeW SMxpaow0 ihpaVObsQQG0SeLi0VFyPGLRqjzOV+e+wk0jIeK1cnwVk7g6QKxrm7ZfqVISyoziwAyODPpdimZYXjfJ/Znp3AaI1ihY3AWFtUf+BjENsVhcXtm0em+wUArWW3A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 24 2024 at 20:59, Byungchul Park wrote: Why is lockdep in the subsystem prefix here? You are changing the CPU hotplug (not hotplus) code, right? > cb92173d1f0 ("locking/lockdep, cpu/hotplug: Annotate AP thread") was > introduced to make lockdep_assert_cpus_held() work in AP thread. > > However, the annotation is too strong for that purpose. We don't have to > use more than try lock annotation for that. This lacks a proper explanation why this is too strong. > Furthermore, now that Dept was introduced, false positive alarms was > reported by that. Replaced it with try lock annotation. I still have zero idea what this is about. Thanks, tglx