From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD66EC4345F for ; Fri, 12 Apr 2024 12:07:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 612F86B0092; Fri, 12 Apr 2024 08:07:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C2AA6B0093; Fri, 12 Apr 2024 08:07:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B1586B0099; Fri, 12 Apr 2024 08:07:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2DB386B0092 for ; Fri, 12 Apr 2024 08:07:52 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E77CE160EA0 for ; Fri, 12 Apr 2024 12:07:51 +0000 (UTC) X-FDA: 82000755942.01.2AE75A0 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by imf07.hostedemail.com (Postfix) with ESMTP id 1E57D4003E for ; Fri, 12 Apr 2024 12:07:48 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b=IOU+aZGz; dmarc=none; spf=pass (imf07.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712923670; a=rsa-sha256; cv=none; b=g5T3vqJKz/a1uMcL5iINc/MKqM/ZQvWdSWoiPw1+1WBdf+/AgJGZyOkhbhQoGKpLJ9Z/S5 3WkT6V7hevTHr/p0j2YH83O1IMGLTuES4b9qgnFwVQnguvD3CJAGwMitIkO7TTVcEFbllc 7YmiyyEJDv81SHTMrLS0d8v3ozXZ/xI= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b=IOU+aZGz; dmarc=none; spf=pass (imf07.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712923670; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+6L46Us/2qlRhhkFSf/ej11Qri1UigkSqyiqW3R+DUI=; b=bikKkXx7iRmOorZVAblkklfOlrVoCOcn3SDt0u/8kBP2dZGI0QJUX+C2Zgcg20tJbLE7q6 RSkM4+GD8zd5QVlanqwN64I6gAIyCSRT1dFUxtJBtOyTCX1oSvQaTLsEM7uely8OkflSRk jt6jXs/uLHsuuOrhAn0TqqRX0ahVpnk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1712923664; bh=+6L46Us/2qlRhhkFSf/ej11Qri1UigkSqyiqW3R+DUI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=IOU+aZGzxjVQGUXs2pw3MGEBG639NiwT0y6sGprZHf7Os4Du4lZbd15clakEZjfA+ 7spFZncmALJZjPxb2riROX0JC7IU4Q1+CxgnGF72ggg8kTz0BP9FBCNClXs+yKVZz+ FFh+dls+x7OSoR+55xOG4T9SohJuAwfG1KoS6LuKG/w94nhF4o6FzkH98j4AHeGTVb cW2Ks+0fefdPnSaIjKrz5voEW0QgS52f/Rbe8TUPGHD/a9cR2WDdzkYJtCt2dIOgSb OVKC3O4ITvcuykiPCyOrXF9qQM1DqHG8s+/9g/Iu6DgxzMotp878IQIXxaehv86OBn XWMy5lQ5sDmrA== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4VGFgd3XgTz4wnr; Fri, 12 Apr 2024 22:07:41 +1000 (AEST) From: Michael Ellerman To: Vignesh Balasubramanian , linux-kernel@vger.kernel.org, linux-toolchains@vger.kernel.org Cc: npiggin@gmail.com, christophe.leroy@csgroup.eu, aneesh.kumar@kernel.org, naveen.n.rao@linux.ibm.com, ebiederm@xmission.com, keescook@chromium.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, bpetkov@amd.com, jinisusan.george@amd.com, matz@suse.de, binutils@sourceware.org, jhb@FreeBSD.org, felix.willgerodt@intel.com, Vignesh Balasubramanian Subject: Re: [PATCH 1/1] Replace macro "ARCH_HAVE_EXTRA_ELF_NOTES" with kconfig In-Reply-To: <20240412062138.1132841-2-vigbalas@amd.com> References: <20240412062138.1132841-1-vigbalas@amd.com> <20240412062138.1132841-2-vigbalas@amd.com> Date: Fri, 12 Apr 2024 22:07:39 +1000 Message-ID: <87il0mdbsk.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1E57D4003E X-Stat-Signature: nnwe6u5kaeg7webcf5fswczprp785t4t X-HE-Tag: 1712923668-388208 X-HE-Meta: U2FsdGVkX1/01xmsY510GOxXwb9Yo/REaHDcJ2jbht0004OBhpLfdWVJp8mOKxtcEKxly28KevquiOQkq4sYltEFATlUDzSgE5vcTygpTtmxGCjjIBJdcSNBA3oJaoGRBhfQajjMD3nHjQEnd1MBBQP6HPsCb7LmMBic7KVRKGUzxQgtv1MhNhH4bsTWYrkmY+6Mgvyp/lzqzWNDcjG3Zr9Y/pgWr1S2e5+yf3Qj84dAAMzo7/w2iBoVMHN6xspiKO/p2gqNrKz3HsLqe5svVgT4/T8f3S/iDR1idAdPVItWh9zHHP19ti6J4mD9X7XxooXRpjaRs2pFLFMeIfTFFHAL5NZNf8eR/vemg6rNK9JRlJ1/Y0N1JqZEVLL4C5dwHv33OkdHXwPwIfIIfkYABE6tg5OhXRkaRI8pC3w4ndZIvuodODZUTA/PGw0OSizCMh/Kyybf9FBwTBCMgEIxYBohORyF+6Bj79497YlDu2+dWgORO7uoc+lUe6O7W+fxtj5wOPD5YWVz7U8voahHt4jlfSo2cGbHbMAswnHzx5BAYTe9ttxjHoSJk/MeYC0rFtbpWhlUi/1qL6rP8XzYVx5pnSo5vhKeH5ICC8ynbIZLw5KFTskapoUwGf4dZMDJ38HP96exaQTfa6DIiePHCiX+lCWA0m20hcHJmmoj/c2UNDm0oahjMpDcAK9b2yugfh5QDWepMsTHudDryHFqea7N78UpA5X1aPbe7VitUUxR41Z/yqibH/pclm5VHzm1QWliwIUwcR6e3qegrUvqrY5H9yKGWuNKzZjBIt48G1KXHTy1bnj2OFqueXAHHIxOv9f/gM3dFysnYUGQpoRSxO/Nap0qEs5MvnnnIAs0YwEWqCfYgdEU+/Q2q6vRh0Wpsk1iJ4WFQCQYhqrcf/uuX9lNa20667VigTChGo0NzWikkrEih04mjvPihL3IHhQvXMJ9SaN6ZuXqSthNcfB +zwW75ku Gg9z8cVN5wh9kJ2+9ZWmJEmy/PMcqVBPkRkGC0kv9fdcTjfKMK8tQP3CylSyLxNaUY0m5x79fPJzdLDukFgu6jJZNEEUAbNKcz01z11jQpPmDd/TAQMGa+wkftDgCPyrYiH254SpC/I7l2qVO0g0KsW+yKBMIwX3PJa/4uYq5BQ4TKBI+9RwHa52n+zwrO/9FCmnR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Vignesh Balasubramanian writes: > "ARCH_HAVE_EXTRA_ELF_NOTES" enables an extra note section in the > core dump. Kconfig variable is preferred over ARCH_HAVE_* macro. > > Co-developed-by: Jini Susan George > Signed-off-by: Jini Susan George > Signed-off-by: Vignesh Balasubramanian > --- > arch/Kconfig | 9 +++++++++ > arch/powerpc/Kconfig | 1 + > arch/powerpc/include/asm/elf.h | 2 -- > include/linux/elf.h | 2 +- > 4 files changed, 11 insertions(+), 3 deletions(-) Acked-by: Michael Ellerman (powerpc) cheers > diff --git a/arch/Kconfig b/arch/Kconfig > index 9f066785bb71..143f021c8a76 100644 > --- a/arch/Kconfig > +++ b/arch/Kconfig > @@ -502,6 +502,15 @@ config MMU_LAZY_TLB_SHOOTDOWN > config ARCH_HAVE_NMI_SAFE_CMPXCHG > bool > > +config ARCH_HAVE_EXTRA_ELF_NOTES > + bool > + help > + An architecture should select this in order to enable adding an > + arch-specific ELF note section to core files. It must provide two > + functions: elf_coredump_extra_notes_size() and > + elf_coredump_extra_notes_write() which are invoked by the ELF core > + dumper. > + > config ARCH_HAS_NMI_SAFE_THIS_CPU_OPS > bool > > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > index 1c4be3373686..c45fa9d7fb76 100644 > --- a/arch/powerpc/Kconfig > +++ b/arch/powerpc/Kconfig > @@ -156,6 +156,7 @@ config PPC > select ARCH_HAS_UACCESS_FLUSHCACHE > select ARCH_HAS_UBSAN > select ARCH_HAVE_NMI_SAFE_CMPXCHG > + select ARCH_HAVE_EXTRA_ELF_NOTES if SPU_BASE > select ARCH_KEEP_MEMBLOCK > select ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE if PPC_RADIX_MMU > select ARCH_MIGHT_HAVE_PC_PARPORT > diff --git a/arch/powerpc/include/asm/elf.h b/arch/powerpc/include/asm/elf.h > index 79f1c480b5eb..bb4b94444d3e 100644 > --- a/arch/powerpc/include/asm/elf.h > +++ b/arch/powerpc/include/asm/elf.h > @@ -127,8 +127,6 @@ extern int arch_setup_additional_pages(struct linux_binprm *bprm, > /* Notes used in ET_CORE. Note name is "SPU//". */ > #define NT_SPU 1 > > -#define ARCH_HAVE_EXTRA_ELF_NOTES > - > #endif /* CONFIG_SPU_BASE */ > > #ifdef CONFIG_PPC64 > diff --git a/include/linux/elf.h b/include/linux/elf.h > index c9a46c4e183b..5c402788da19 100644 > --- a/include/linux/elf.h > +++ b/include/linux/elf.h > @@ -65,7 +65,7 @@ extern Elf64_Dyn _DYNAMIC []; > struct file; > struct coredump_params; > > -#ifndef ARCH_HAVE_EXTRA_ELF_NOTES > +#ifndef CONFIG_ARCH_HAVE_EXTRA_ELF_NOTES > static inline int elf_coredump_extra_notes_size(void) { return 0; } > static inline int elf_coredump_extra_notes_write(struct coredump_params *cprm) { return 0; } > #else > -- > 2.34.1