From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B25A6C27C4F for ; Thu, 27 Jun 2024 03:06:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A99F6B008C; Wed, 26 Jun 2024 23:06:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 459066B0092; Wed, 26 Jun 2024 23:06:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 321746B0096; Wed, 26 Jun 2024 23:06:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 11D156B008C for ; Wed, 26 Jun 2024 23:06:49 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B1F7B121965 for ; Thu, 27 Jun 2024 03:06:48 +0000 (UTC) X-FDA: 82275181296.05.A66C063 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by imf14.hostedemail.com (Postfix) with ESMTP id 968EE100006 for ; Thu, 27 Jun 2024 03:06:45 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Vmz4gofd; spf=pass (imf14.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.17 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719457589; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RqMh8MoO7iKoCzDTWp5HlEGQvAHpfxxI7HqxQiGfAFM=; b=c9EykZDL6bl53iidC79jACBib1Eze1AivCyu0AU7DsqupLFZm9uIttGNNMXg11RbD/K8Le BPlTTxZnW8zhRcSoikQfGayww8RaupLGdnnVwOTEWFncUoVcLtdHWGd7F86Hedx3KdRAo4 dDJPihbSa/ZMe39JANxlamDB/60njH0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719457589; a=rsa-sha256; cv=none; b=IIBDt1TbR/9Rg7IZZGXkeyhvXJX4IwXhKdodzNeBEGVaJK5MPyclxRGG3rNbdj28NEUyLR RPpR5C3xbt7eFKEoKzMu3VL2c4Yo4Iu6fWcjfnW+nNRNszM8R6abLxVL0Qy0qqQt522sHo COSMu+HxlJc8yml4t8k99q4L13or6H4= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Vmz4gofd; spf=pass (imf14.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.17 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719457606; x=1750993606; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=m20LtT3zH1rzWB1D7Km3gbP09DhEv34gcr+Vpi2RTgc=; b=Vmz4gofdZursKVz5NInnej83L4tUGS4scGwwN1DnqakgbuiwD5uEAm1N 3VE9JavsxXhraoD68Nw5h9Nt77TwTn6rS9dwDvBILgDmQZGvib6irD+KG A2V2sWM18PaQ4eSED8pFh3+Fpz8d3rfqK06HhoN0J31DchWZkd5Sf4WBd re/ICijHdFMQ0FlYtptL6D3+zn4Qdz7D1RWKzOlV0SrNQh4x6g3wBZend vQ8O+wSVmz65a/i8h+UbOUaviuu7o8zRZciKly0PtejsTDcQskdPKDcGh guHs+Y5kYGvVc5tP033hIRLV5VAuSpt4R/MmJL6bOHTpKW+DfT2udlBbe g==; X-CSE-ConnectionGUID: U2rc/ZrUQQqf4q7owCBu5Q== X-CSE-MsgGUID: LNwwzKYtQMWVOfPSD3f79w== X-IronPort-AV: E=McAfee;i="6700,10204,11115"; a="16691907" X-IronPort-AV: E=Sophos;i="6.08,268,1712646000"; d="scan'208";a="16691907" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2024 20:06:45 -0700 X-CSE-ConnectionGUID: tfrjDlomSv2iIUNwnug9Dw== X-CSE-MsgGUID: p1YwwIuBS0Wqen2b4xFs3A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,268,1712646000"; d="scan'208";a="44126371" Received: from unknown (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2024 20:06:41 -0700 From: "Huang, Ying" To: Tvrtko Ursulin Cc: Tvrtko Ursulin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-dev@igalia.com, Mel Gorman , Peter Zijlstra , Ingo Molnar , Rik van Riel , Johannes Weiner , "Matthew Wilcox (Oracle)" , Dave Hansen , Andi Kleen , Michal Hocko , David Rientjes , Andrew Morton Subject: Re: [PATCH] mm/numa_balancing: Teach mpol_to_str about the balancing mode In-Reply-To: <9355e4b3-9892-4e5c-9288-103c93bd3bca@igalia.com> (Tvrtko Ursulin's message of "Wed, 26 Jun 2024 12:51:08 +0100") References: <20240625132605.38428-1-tursulin@igalia.com> <87r0ckozs4.fsf@yhuang6-desk2.ccr.corp.intel.com> <9355e4b3-9892-4e5c-9288-103c93bd3bca@igalia.com> Date: Thu, 27 Jun 2024 11:04:49 +0800 Message-ID: <87ikxvozla.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 968EE100006 X-Stat-Signature: x7ixbxdji8jo9ta8sybd5rroeyaxybch X-HE-Tag: 1719457605-902457 X-HE-Meta: U2FsdGVkX18JWpDp7n33VssuYPFmC5u3b1jHcGyL4f37KIGiZd4JUed2NQlRe6JgQgug/Gg60Hf54jP0AVruOA6lcjcHs//1MYlJnNZ3Zuvceqb7CG3we+9MdoBHEUC/CPnAytTdIXbcup1ySnpW0kUCp+7Q1KKtW+bn9d98EfWHwRfDqz2V5U/3j7Gm7S3dXghCogjYPAdUSB8FEvOZH82/aaiJPeazTMg+bO/dn/10Za0ftIm6tCtI6Nxo/86e4B1pQUBtTGQUPpxV44gBWIiW9kIPcrnVEvalgj95LOQyv7bC9yaqseQlnlSh9uPK714vmpP8j5JFnnS4OqlCJX/hHnIu6tsQgUfBYruVWTx/j7km2CT4NFtRXNK8E/YCyGWPO3n0MN9KnRjujOdlDmWLSGoUrYkyxPvklwOQSCCP99odhV+EOVy0bf9uG65bYZpfRj2Pz1txNfpqk7qtGq6IoUwZI6u3a2UPNzDLdIs/fqrV4NfiU36fbp6JiIHdZCv6arrbNFpcdYW6nUYO1ToXYSdVoyIaI0FvG51TVvvaUyuvu4WqzntZCt9S/EWmkXDG4cdaKyiOVpsDhfqCGq3mNf0QqR/bBdHsd4yzG5oQ8Za5JiRcRzgQVCm/3/Ou6Novhrhs+VFME8NZHcFt7FKHDfB8/qtMFLYoiypcfi2MMnkK2cWMVP4fGSqsu621yj5OTgr20+GCIIi8G9rgs2ojaPfF4ndVkbZ17GeCIhOrnbDugw0sWOopUBIhQwbFurntCeW20KZuHAu+DJCuyu2Y6I+BMjSMByiJyxc+q1kv1WwH5xr9pUxeT/TRSMXwICJjUZZ1vMGDre8zDqBRVWvy9cWOtYcOYovgyYbo1DYRN50ZXpO7nhgwB3uqEbRWmuEDaFdrwvQttGwk8J0P6X6P8+fXqI8DBQwGFJe9KII1LVXe6qREtJJ585JQ7XAmws8dgWtgmUaJtcj1TrX 5J/muX5v fMFL4TJcdxxTnNWYefxAIMX/a9po0p5qq1mnOBmFa+15Fd/AkWdTB5UkvxeMQKGjVNg9w4h9sXRJOZPij1wA9+GsoZBGAQQggnWaAjxwrXNH6WylKaybn65duEWdfvG6VCUb4Qu5pkE9aeiQh8DNngIebj3IAbgyx6ZHS4K8aif5N3LepdyDaAN9zyamS5vlZ4inoruKn2xAgh0C3NoXIb2mLc1wvbB4TzgrwpnQY6I/E8q1L+uAZAH/r2z6SqUdrxey1kq2j2PvBsG9BgRa/lvEoxBh6BL4NaRcBONLb2iAe5Ac= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Tvrtko Ursulin writes: > On 26/06/2024 09:48, Huang, Ying wrote: >> Tvrtko Ursulin writes: >> >>> From: Tvrtko Ursulin >>> >>> If a task has had MPOL_F_NUMA_BALANCING set it is useful to show that in >> IIUC, MPOL_F_NUMA_BALANCING works for VMA area via mbind() too. > > Ah okay.. I think I forgot to actually check and went by what commit > text of bda420b98505 said, which is probably outdated. > >>> procfs. Teach the mpol_to_str helper about its existance and while at it >>> update the comment to account for "weighted interleave" when suggesting >>> a recommended buffer size. >> Otherwise LGTM, Thanks! >> Reviewed-by: "Huang, Ying" > > Thank you! Would you have an idea of which tree this should go to aka > which maintainer to ask to merge it? You can use scripts/get_maintainer.pl in kernel source tree to find out the maintainer. And IIUC, Andrew Morton is the maintainer for this. > Second question - I also have a patch which enables choosing balancing > for tmpfs (mpol_parse_str) but I am unsure of its value. It would make > things symmetrical, but is there some other benefit I don't know. Any > thoughts on this? I am not familiar with tmpfs NUMA policy, after checking the source code, my understanding is that the change may have user visible effect. For example, you can mount tmpfs with numa balancing enabled/disabled and check whether pages can be balanced among NUMA nodes. [snip] -- Best Regards, Huang, Ying