From: "Huang, Ying" <ying.huang@intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Cc: Tvrtko Ursulin <tursulin@igalia.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-dev@igalia.com, Mel Gorman <mgorman@suse.de>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Rik van Riel <riel@surriel.com>,
Johannes Weiner <hannes@cmpxchg.org>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Dave Hansen <dave.hansen@intel.com>,
Andi Kleen <ak@linux.intel.com>, Michal Hocko <mhocko@suse.com>,
David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm/numa_balancing: Teach mpol_to_str about the balancing mode
Date: Thu, 27 Jun 2024 11:04:49 +0800 [thread overview]
Message-ID: <87ikxvozla.fsf@yhuang6-desk2.ccr.corp.intel.com> (raw)
In-Reply-To: <9355e4b3-9892-4e5c-9288-103c93bd3bca@igalia.com> (Tvrtko Ursulin's message of "Wed, 26 Jun 2024 12:51:08 +0100")
Tvrtko Ursulin <tvrtko.ursulin@igalia.com> writes:
> On 26/06/2024 09:48, Huang, Ying wrote:
>> Tvrtko Ursulin <tursulin@igalia.com> writes:
>>
>>> From: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
>>>
>>> If a task has had MPOL_F_NUMA_BALANCING set it is useful to show that in
>> IIUC, MPOL_F_NUMA_BALANCING works for VMA area via mbind() too.
>
> Ah okay.. I think I forgot to actually check and went by what commit
> text of bda420b98505 said, which is probably outdated.
>
>>> procfs. Teach the mpol_to_str helper about its existance and while at it
>>> update the comment to account for "weighted interleave" when suggesting
>>> a recommended buffer size.
>> Otherwise LGTM, Thanks!
>> Reviewed-by: "Huang, Ying" <ying.huang@intel.com>
>
> Thank you! Would you have an idea of which tree this should go to aka
> which maintainer to ask to merge it?
You can use scripts/get_maintainer.pl in kernel source tree to find out
the maintainer. And IIUC, Andrew Morton is the maintainer for this.
> Second question - I also have a patch which enables choosing balancing
> for tmpfs (mpol_parse_str) but I am unsure of its value. It would make
> things symmetrical, but is there some other benefit I don't know. Any
> thoughts on this?
I am not familiar with tmpfs NUMA policy, after checking the source
code, my understanding is that the change may have user visible effect.
For example, you can mount tmpfs with numa balancing enabled/disabled
and check whether pages can be balanced among NUMA nodes.
[snip]
--
Best Regards,
Huang, Ying
next prev parent reply other threads:[~2024-06-27 3:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 13:26 Tvrtko Ursulin
2024-06-26 8:48 ` Huang, Ying
2024-06-26 11:51 ` Tvrtko Ursulin
2024-06-27 3:04 ` Huang, Ying [this message]
2024-06-27 21:37 ` Andrew Morton
2024-06-28 9:03 ` Tvrtko Ursulin
2024-06-27 21:47 ` Matthew Wilcox
2024-06-28 3:12 ` Huang, Ying
2024-06-28 8:56 ` Tvrtko Ursulin
2024-06-28 9:32 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ikxvozla.fsf@yhuang6-desk2.ccr.corp.intel.com \
--to=ying.huang@intel.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-dev@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
--cc=rientjes@google.com \
--cc=tursulin@igalia.com \
--cc=tvrtko.ursulin@igalia.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox