From: Andi Kleen <andi@firstfloor.org>
To: Jim Paradis <jparadis@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Dirty page tracking & on-the-fly memory mirroring
Date: Fri, 07 Aug 2009 01:06:01 +0200 [thread overview]
Message-ID: <87hbwkiluu.fsf@basil.nowhere.org> (raw)
In-Reply-To: <4A7393D9.50807@redhat.com> (Jim Paradis's message of "Fri, 31 Jul 2009 21:01:13 -0400")
Jim Paradis <jparadis@redhat.com> writes:
> +#ifdef CONFIG_TRACK_DIRTY_PAGES
> +
> +#if PAGETABLE_LEVELS <= 3
> +static inline unsigned pud_index(unsigned long address)
> +{
> + return 0;
> +}
> +#endif
Needing special code for different page table levels is a really bad
sign that it uses the wrong abstractions for page tables. It should be using
the standard page walk idioms or perhaps even walk_page_range() now
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2009-08-06 23:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-01 1:01 Jim Paradis
2009-08-01 15:52 ` Christoph Hellwig
2009-08-06 23:06 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hbwkiluu.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=jparadis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox