Re: [RFC PATCH 2/4] mm: Change the interface for __tlb_remove_page

["Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>]

Hillf Danton <hillf.zj@alibaba-inc.com> writes:

>> >> @@ -1202,7 +1205,12 @@ again:
>> >>  	if (force_flush) {
>> >>  		force_flush = 0;
>> >>  		tlb_flush_mmu_free(tlb);
>> >> -
>> >> +		if (pending_page) {
>> >> +			/* remove the page with new size */
>> >> +			__tlb_adjust_range(tlb, tlb->addr);
>> >
>> > Would you please specify why tlb->addr is used here?
>> >
>> 
>> That is needed because tlb_flush_mmu_tlbonly() does a __tlb_reset_range().
>> 
> If ->addr is updated in resetting, then it is a noop here to deliver tlb->addr to
> __tlb_adjust_range().
> On the other hand, if ->addr is not updated in resetting, then it is also a noop here.
>
> Do you want to update ->addr here?
>

I don't get that question. We wanted to track the alst adjusted addr in
tlb->addr because when we do a tlb_flush_mmu_tlbonly() we does a
__tlb_reset_range(), which clears tlb->start and tlb->end. Now we need
to update the range again with the last adjusted addr before we can call
__tlb_remove_page(). Look for VM_BUG_ON(!tlb->end); in
__tlb_remove_page().

-aneesh


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>