From: Michael Ellerman <mpe@ellerman.id.au>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: linuxppc-dev@ozlabs.org, linux-mm@kvack.org,
erhard_f@mailbox.org, jack@suse.cz,
aneesh.kumar@linux.vnet.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/64s: Fix possible corruption on big endian due to pgd/pud_present()
Date: Sun, 17 Feb 2019 19:26:29 +1100 [thread overview]
Message-ID: <87h8d2ddmy.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <87pnrran89.fsf@igel.home>
Andreas Schwab <schwab@linux-m68k.org> writes:
> On Feb 14 2019, Michael Ellerman <mpe@ellerman.id.au> wrote:
>
>> The fix is simple, we need to convert the result of the bitwise && to
>> an int before returning it.
>
> Alternatively, the return type could be changed to bool, so that the
> compiler does the right thing by itself.
Yes that would be preferable. All other architectures return an int so
I wasn't game to switch to bool for a fix. But I don't see why it should
matter so I'll do a patch using bool for next.
cheers
next prev parent reply other threads:[~2019-02-17 8:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 6:23 Michael Ellerman
2019-02-14 16:31 ` Jan Kara
2019-02-16 10:55 ` Balbir Singh
2019-02-16 14:22 ` Segher Boessenkool
2019-02-17 6:23 ` Balbir Singh
2019-02-17 8:34 ` Michael Ellerman
2019-02-17 21:55 ` Balbir Singh
2019-02-18 0:49 ` Michael Ellerman
2019-02-19 12:01 ` Balbir Singh
2019-02-19 20:15 ` Segher Boessenkool
2019-02-20 11:18 ` Michael Ellerman
2019-02-20 14:51 ` Segher Boessenkool
2019-02-17 8:34 ` Michael Ellerman
2019-02-16 13:15 ` Andreas Schwab
2019-02-17 8:26 ` Michael Ellerman [this message]
2019-02-17 8:21 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8d2ddmy.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=erhard_f@mailbox.org \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox