From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFD6AC5479D for ; Tue, 10 Jan 2023 00:45:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 409818E0002; Mon, 9 Jan 2023 19:45:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B9308E0001; Mon, 9 Jan 2023 19:45:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 259D28E0002; Mon, 9 Jan 2023 19:45:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 15F478E0001 for ; Mon, 9 Jan 2023 19:45:27 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D9D39141A7F for ; Tue, 10 Jan 2023 00:45:26 +0000 (UTC) X-FDA: 80337045852.30.A30DEB6 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2055.outbound.protection.outlook.com [40.107.95.55]) by imf13.hostedemail.com (Postfix) with ESMTP id 3979520008 for ; Tue, 10 Jan 2023 00:45:23 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=EZQgxcd7; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf13.hostedemail.com: domain of apopple@nvidia.com designates 40.107.95.55 as permitted sender) smtp.mailfrom=apopple@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673311524; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GoigljLd0kxqS9jtF9A79S39m7yJleuPYaPak5FC1tc=; b=ZU4S+qgpuP9dZka7LZ77AmACh+1DEb6mPjh0pmloDofalf2b/l0ZfzABitxtWRLd4Zun22 gfjLPDksjsiQM4ozkOKytOR03d7GtdHh+PGVv6U1ORjP5RNKj4zFf05e8Zn3RCUwUh8+ZQ IYGGKUNAN8ZtQ75KIMxarUhmkXOoncQ= ARC-Authentication-Results: i=2; imf13.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=EZQgxcd7; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf13.hostedemail.com: domain of apopple@nvidia.com designates 40.107.95.55 as permitted sender) smtp.mailfrom=apopple@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1673311524; a=rsa-sha256; cv=pass; b=sOc8+EGp0mQFMLTH71szYk/PmJGP9vo9bwY0Oe/VG0YgRNrjc9QW4co661sQ3ejzv2fkgZ OUhqpnj/pfkTQhKLAdlfF0UX2Abke/Etiivre9bp1x8SR4DbHEAgWUEc/MgyQ/aewk2Q98 18JeiP8ifIZLmqNgbGj95pWofQj+/cE= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N6MkYipp8wCSns6A3qzQjLpDvTmz8/xXRB8GargMDN0Xb+iRO9bGKmCbv3/2V1PgsjJWr5WnGMd5dnnfjup2nOPavbqJ3F86IJi+eeWY4ndphk9JzdRQFKeqsphStL/CierErBWno7627214+DAhyM0hkt+6Sgv6jQP3Yuoo4m4PF5Np7av2hUJPkURolTulJcOo6xX9bb1+zqr7FXLq3UW979ya6kc6y7Bu0O/KlHbRQe18F4ypblKo+EVB+rk6GbFhbAqAW1T1ow8I/EBMIL7O6eNa5y8HHPFnwrIS9OLnYWBT3oEbLC6NaWxm+e9unMEkLaXbUS/FyNR0z8fv5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GoigljLd0kxqS9jtF9A79S39m7yJleuPYaPak5FC1tc=; b=J4WwkJFkFxqxOHxYK1zD/HncXhH67PnBTLkLcrMx5UBGH2m4+57VnFdO3tgQ9Disut+06Q6eHLbBT/Qtok/cUD/Byn24fFeO60uKZyglVucVcDiuOa/x1PYAg/cq4hBtuUW/zj4QqGm4BWtLHSfkxQBVZplCk9egbJi1t4mHO5+tzEFq1xd4P5OertOD5q8S9DJ1Rd2Vtx6WnzaBAfkKcwZcAKHxzOa3tW/gUNI0Mea7pnN4lIFUt72YoZtCUyef2tjtq6lP6VljNHD9W0JHt5nMjI+pMsZWYuGy79bbl3z9SjLbNUzPu95w0iif0/Gr+a2JH1wVnnagkcnQQRyQiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GoigljLd0kxqS9jtF9A79S39m7yJleuPYaPak5FC1tc=; b=EZQgxcd7dhcFHeT66xURR3TckBv2f17NISp2GpIu9X+zwgXicb6RVcHYf7Ba0Dd3CRXrakkbGWcoFipxV8AC3ismLO2zI65sLzo38FXhAQvCFVjkd5vd0dqB3XhJKOs+DRqMnbp9gGfDu1YJqTL3r89lLN6xIsuPVaipUAWHLZ9ty4avWk0tzpm66+sbjYKRS832WY/onOzycnvC4Y8pCtyq9GU++xv0qIQFQsYHf0d5e9u4LYFzycJEPJ1QhVoeptcpTMhR3Zj/1kp1VUI/3A1UP3enVRbhvca+N9XE5VVLQLKFU5gYaRrHUOIYb1rbfCueMBs08dqPjVLKo3xo9w== Received: from BYAPR12MB3176.namprd12.prod.outlook.com (2603:10b6:a03:134::26) by SJ1PR12MB6361.namprd12.prod.outlook.com (2603:10b6:a03:455::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 00:45:22 +0000 Received: from BYAPR12MB3176.namprd12.prod.outlook.com ([fe80::ecfb:a3ad:3efa:9df8]) by BYAPR12MB3176.namprd12.prod.outlook.com ([fe80::ecfb:a3ad:3efa:9df8%3]) with mapi id 15.20.5986.018; Tue, 10 Jan 2023 00:45:22 +0000 References: <20230109012207.79457-1-apopple@nvidia.com> User-agent: mu4e 1.8.10; emacs 28.2 From: Alistair Popple To: Mike Kravetz Cc: Andrew Morton , linux-mm@kvack.org, John Hubbard , Ralph Campbell , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Ira Weiny , Jason Gunthorpe , Christoph Hellwig Subject: Re: [PATCH] mm/mmu_notifier: Remove unused mmu_notifier_range_update_to_read_only export Date: Tue, 10 Jan 2023 11:37:43 +1100 In-reply-to: Message-ID: <87h6wznrok.fsf@nvidia.com> Content-Type: text/plain X-ClientProxiedBy: SY6PR01CA0010.ausprd01.prod.outlook.com (2603:10c6:10:e8::15) To BYAPR12MB3176.namprd12.prod.outlook.com (2603:10b6:a03:134::26) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR12MB3176:EE_|SJ1PR12MB6361:EE_ X-MS-Office365-Filtering-Correlation-Id: 20ba68ca-d871-463f-401b-08daf2a3f447 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W9Znr4Vvqy2WBU3CpIMTXIhRamBrO4RG9FNpKAkZwYZgsPlOjCa3iTErXFfUBPl0+7RxsQojXLIyR8b0wNWeLOF7GSbsnbIHzVKgDeX2B7rq9SZT6/S0wgU6qatjdAKL0YrwxF4F5BgIhQXYmg0YUDUOtzjaq65pUtpmRYONkhaQhuAF2Q41ySEtdxuwEFivwNyqLxvI3MI967FBNV5ybgzSzdErzXGa1tUwEYa1zC2bYuvT8HxRm/3N38pjL1cu9hQYVRcrK5dtewwxbXUeiu4fZrDv4IQtOpnk91tATlyt064q5NzoJb2LzDq7PfubETJVByIgDnTR7Ksgp6FEh/DTlh2GZS2ZCiCFrLk2E/y2S1/WAZb25N9WleEjD99o/aeS4OAKQQzv0QsV+dsI9xg09YgBycglLEShqje610u30WEOw6t+3hT7Buw3N1rg9zursd/q4jqXkwcnF5probQ1BZwxSNw9uFLcUPntAo0Ss0Cxeu6pXhAAc7NkwWBumqQKz2E5ljAsXzziggmkFbM9Py6mkyL2oAdsFwJlsfOFrZWmDdk857WrmB2gD1b3WotUCht1qycqZecvymjeZc7F5T3wguk8RJnbTFA4aSUYg8W8g92a5Dy8sWOeqFvPrg8J7MwcnbjbsNW8oO+HiQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR12MB3176.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(136003)(376002)(39860400002)(346002)(396003)(451199015)(8676002)(316002)(5660300002)(26005)(6512007)(6486002)(478600001)(186003)(2616005)(41300700001)(66946007)(4326008)(66476007)(6916009)(66556008)(54906003)(8936002)(36756003)(83380400001)(86362001)(53546011)(6666004)(6506007)(38100700002)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?28v0T5HKwCnjgNns9NWZ1z6WCkKKAVJ+xbO/bcMevEkyqM+AtejdHQeuH88z?= =?us-ascii?Q?JT47XN0RSo3zFAqC6tAygIeQ8xImUUGmFPHFB5Dyemr+FaoL2EinX620OdNW?= =?us-ascii?Q?LMHGxonmYGVpYzwLrHDyz/jYug8I1deVf+NDFw7Rvo1OJly0AVe0d7nCyOx9?= =?us-ascii?Q?QpZC9ouL8uI3UWxNXkTj8SZv3O0CupxJJilwSiIcIjgEwjC8gFzb0ZpXIh1L?= =?us-ascii?Q?4vcwBT3+XBu+4Ed3yvRWiNYSzND1wu8IXR2RHwDj2oIqRBGdYTKrqt84oRdn?= =?us-ascii?Q?blhbtT5kahk8gX6J25kF5qMCO/X7wOUr3mJ9xb5pPeuEBDss73wiVA04KE5s?= =?us-ascii?Q?UUdQ/UBybugfkk/m3tRlR4N7tMUb2ub6nKV1vgD5Lon51N5o7BhoyZJt4RDJ?= =?us-ascii?Q?Z2YQn+Bs5JaRzl8pvyuS0qO6eaP4ZFdOXcvdb2VaoQ0Hyyvl8h39MdXDejKL?= =?us-ascii?Q?uwncyj0RE0EaMW6aY2c+ljHE8kUxWo2PvU77H0PQT3u+GnRBUmA+LEd9u35T?= =?us-ascii?Q?6W91RtIf5Vz/rXEVsXKQPn680LsqCa7NgXnYT5Eb+u3Ew+j4C3KsfobwBs5v?= =?us-ascii?Q?u32mTISvZhHzL5EgZUXZGp6GiXpoLevafX7Eh9EqcV6bTNQABPMDW1UKhsxm?= =?us-ascii?Q?hv0ZFZsD/cbXoOzu/HJcxbECKbBjr8+a8D3WP/onY+TDQ6QfG33CohBMnZJ1?= =?us-ascii?Q?wpggNE7oK3BsvEyYNFbDZNDflUDOpZAOfZoC/rl9NBJeiIGVkmGDhxr16IK4?= =?us-ascii?Q?SNLvkgGRRKnRwhYwZLErM9BVO3JZDvlgqlO9D2IW3t2HfipZsCYLV3PihVPd?= =?us-ascii?Q?JSU6UZWsxbWbZ4U1SCiIU0xI/loTEei4g52FD83LErDFEeLFXCtveyu3r9fa?= =?us-ascii?Q?MajeJegZd7wALQJMwpSBbhq/Ui5rD8nvtII07rgGn7ZKna+fV+YtT5d5ii9+?= =?us-ascii?Q?Ddy3P82FI8Lf3Mp3BZm//SnpVe1mOdsz6nEoK+Hr/MJ7v7y4X6jrJ4Mhm3qz?= =?us-ascii?Q?na5HFrn4mtxtVbeU/rGIdMxQZAuZoRMAEgq+EAwVY5yEK1FhtFSRVBWJP1ra?= =?us-ascii?Q?MSawdwQu2DH7r7CeogjRhFfbkrCO4kieGoaK9gzXo8ckAVgV49FfhQN4ewLs?= =?us-ascii?Q?npzcsNPZ3Hm+3tiNWT9BX0wcf38UZehUatOguRgirK1XtKS0A//KT7Buo664?= =?us-ascii?Q?MQSkqpArjO59AIGel66Qb4n3TCUepRo/EOhV3nA2X5y1fG43bDZPthI1HAe/?= =?us-ascii?Q?pKJkuUQ8mAblgysOajhGqxUM/TGMUEIS/6AYZn4Xh6VfwRm/oCc/KDJy2YwS?= =?us-ascii?Q?BollhETpR5dP4f4jOX40AXxk9ChDZkyT1OgyMMuFcphZSf0DbJMiiAbCVmKQ?= =?us-ascii?Q?J2rCoGQ6k8cNhsSMQeSmT0c8hvYczEK7q4C+VuOx1IvAtdskClwKLxBORwG3?= =?us-ascii?Q?9C9yFEH0d+GtQ8Pvic0J+l28kOl8PosPSX0J0aYLD92w8TUpujz/L9TuyqA/?= =?us-ascii?Q?1ORON2HG6p8ykJ31Mp6v1U0m0V+iRP6IIalz5SJg5elf4njAs0dCJKZkXXOR?= =?us-ascii?Q?aEMKr3WZlxvPq+6roN1V0ctwB0k+R/21fsGmiaDt?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20ba68ca-d871-463f-401b-08daf2a3f447 X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3176.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 00:45:22.0122 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gGwDoh/xeHRnzaKVzJZ0s8xr7usDLE8hYmwv2203tx09iPzNZ9ayOhE4gwxFcMe3dtxzu3QS8R7MyTKvDBFc9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6361 X-Rspamd-Queue-Id: 3979520008 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: gu1rpoqjtkjy91w9i7hnm7hgwu91aeke X-HE-Tag: 1673311523-813920 X-HE-Meta: U2FsdGVkX196GthZDAC8SabXCbd18MdfukuR73rNh/UHEQrDIMkLriGsZZzOTZcGydVOblCJznqELmu+mqA0Vd1OvxF2P1fhIHRXgE2H9cVGgiW5JcoqPaF1y2ZpKg+BB4X7YZF3QT6URL2/ruAJGX15kPlKUc/EC6mUi7utSgz5eBQkljB7ZcKxwgjAIx9Rk+b2l191frEHcOPxyDy4cs4QODSGDQPagmpZhVA6/Hzd9QXev97kO0o3GRhWYdi3dH3bJ3KMaT0V99Eojdt7BTXCC5DJVPlzZmQ7fR98QNx1Tm8ec2V4JF2HtGFUOqMoASsMpjFJXG3cTgc8qMHQLxXChIn2CIunFwEnhWW5izKT/GGvNU21WucA1hEL5GP92Vu2ZjGcZpqLreH1Fa58XGcqznTNUlRv0XqUrsQ22VA+eOTs10b3Ctzz2B1TVewbG9fHfO/TNnptgtsSljDBp99yANFEw7Shgd5dbjmu2zIr7uXF3MG8jC0w+C2yCwo7XsovIzOqf3v0/9xluwyf7a8skpzgI2l/GPzJRQOtY0tWqffkTFbnaj425v7wPI0VGq+olENF1Xob2QtXM8vFgTSlEG9MWGKw7gSCVPFsFNVY7I5fCHKG/5r+FnyFqd81vbuV0cTaKqSqSfaBclYBnN7pxNPGJQA8rCcb4wcqxw2saSehkimXihTbvwVJqVkXBKsucLzkHHwurqM4usVoEpeHPLhUu3gSU/7TjV64Ry4nxM4avUk38a29CVLFnan8k+qFYkKBBIYF7M6gaTydys/YBtY5QdDlllnwhL2pl1qT3QlaC+gyTcPLXutuLstzlBMcCEAvTpMDK33VkCF63TZTfWO8ZhoLI5nuV9+kEJoSo9AW2ybfE25h6WRFog7XjVoYl1nK8vj9efvHMHO7lxnEES7ioIydkphRX7+hbyJSo8jgvMMNbANYsF7zWXxVX06qy6lEtzxybmvBg9s qEw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Mike Kravetz writes: > On 01/09/23 12:22, Alistair Popple wrote: >> mmu_notifier_range_update_to_read_only() was originally introduced in >> commit c6d23413f81b ("mm/mmu_notifier: >> mmu_notifier_range_update_to_read_only() helper") as an optimisation >> for device drivers that know a range has only been mapped >> read-only. However there are no users of this feature so remove it. As >> it is the only user of the struct mmu_notifier_range.vma field remove >> that also. >> >> Signed-off-by: Alistair Popple >> --- >> include/linux/mmu_notifier.h | 2 -- >> mm/mmu_notifier.c | 10 ---------- >> 2 files changed, 12 deletions(-) >> >> diff --git a/include/linux/mmu_notifier.h b/include/linux/mmu_notifier.h >> index d6c06e140277..252e44afcc70 100644 >> --- a/include/linux/mmu_notifier.h >> +++ b/include/linux/mmu_notifier.h >> @@ -269,7 +269,6 @@ extern struct lockdep_map __mmu_notifier_invalidate_range_start_map; >> #endif >> >> struct mmu_notifier_range { >> - struct vm_area_struct *vma; >> struct mm_struct *mm; >> unsigned long start; >> unsigned long end; >> @@ -519,7 +518,6 @@ static inline void mmu_notifier_range_init(struct mmu_notifier_range *range, >> unsigned long start, >> unsigned long end) >> { >> - range->vma = vma; > > Any reason why you did not delete the vma argument to mmu_notifier_range_init? Argh, because I wrote this as a quick test before the break and totally forgot that is why I didn't send it before going on leave. Thanks for noticing, will send a v2. - Alistair