Re: [PATCH] mm/mmu_notifier: Remove unused mmu_notifier_range_update_to_read_only export

[Alistair Popple <apopple@nvidia.com>]

Mike Kravetz <mike.kravetz@oracle.com> writes:

> On 01/09/23 12:22, Alistair Popple wrote:
>> mmu_notifier_range_update_to_read_only() was originally introduced in
>> commit c6d23413f81b ("mm/mmu_notifier:
>> mmu_notifier_range_update_to_read_only() helper") as an optimisation
>> for device drivers that know a range has only been mapped
>> read-only. However there are no users of this feature so remove it. As
>> it is the only user of the struct mmu_notifier_range.vma field remove
>> that also.
>> 
>> Signed-off-by: Alistair Popple <apopple@nvidia.com>
>> ---
>>  include/linux/mmu_notifier.h |  2 --
>>  mm/mmu_notifier.c            | 10 ----------
>>  2 files changed, 12 deletions(-)
>> 
>> diff --git a/include/linux/mmu_notifier.h b/include/linux/mmu_notifier.h
>> index d6c06e140277..252e44afcc70 100644
>> --- a/include/linux/mmu_notifier.h
>> +++ b/include/linux/mmu_notifier.h
>> @@ -269,7 +269,6 @@ extern struct lockdep_map __mmu_notifier_invalidate_range_start_map;
>>  #endif
>>  
>>  struct mmu_notifier_range {
>> -	struct vm_area_struct *vma;
>>  	struct mm_struct *mm;
>>  	unsigned long start;
>>  	unsigned long end;
>> @@ -519,7 +518,6 @@ static inline void mmu_notifier_range_init(struct mmu_notifier_range *range,
>>  					   unsigned long start,
>>  					   unsigned long end)
>>  {
>> -	range->vma = vma;
>
> Any reason why you did not delete the vma argument to mmu_notifier_range_init?

Argh, because I wrote this as a quick test before the break and totally
forgot that is why I didn't send it before going on leave. Thanks for
noticing, will send a v2.

 - Alistair