From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89765C54EAA for ; Tue, 24 Jan 2023 16:21:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F372C6B0073; Tue, 24 Jan 2023 11:21:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EE7276B0074; Tue, 24 Jan 2023 11:21:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DAE706B0075; Tue, 24 Jan 2023 11:21:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CB55F6B0073 for ; Tue, 24 Jan 2023 11:21:57 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9D1B7120BFA for ; Tue, 24 Jan 2023 16:21:57 +0000 (UTC) X-FDA: 80390209074.04.F8CC2B5 Received: from ms.lwn.net (ms.lwn.net [45.79.88.28]) by imf16.hostedemail.com (Postfix) with ESMTP id E1486180020 for ; Tue, 24 Jan 2023 16:21:54 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=lwn.net header.s=20201203 header.b=WPbLObmI; spf=pass (imf16.hostedemail.com: domain of corbet@lwn.net designates 45.79.88.28 as permitted sender) smtp.mailfrom=corbet@lwn.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674577315; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e9Ms9NIy69DBSpc92O0jPbndqt+BbCrpQpQKJy7enug=; b=K1nMNDv7KpCmCNN5+ABkbdPpO22hLtzob9lK0l2Ih8DCVujm2x0L7SyNBjDCq/7XJiKSqQ u3m1tZxLiKG9/wcrjXohjoGUqjht5oUa8pxuzvzT/HHYW0W/+roCFWJEkm2h9Ofd6tfLwn FnTyepncvR+lxIhQyanShVPeI21KIRk= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=lwn.net header.s=20201203 header.b=WPbLObmI; spf=pass (imf16.hostedemail.com: domain of corbet@lwn.net designates 45.79.88.28 as permitted sender) smtp.mailfrom=corbet@lwn.net; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674577315; a=rsa-sha256; cv=none; b=Y0lcN6nnhPhkq9NrtX7Yfp1oFGeGIn1mS2JothJ1CGsXSZmw1EEXMKCBDwtk3iEksV/JUo ArA+Tw/iyApy1+FuuOMb/piG1yn1UqOnpNtkEjEF1ueSbQjbxX0LNhVKBgC+MBCLQexytd QG9Sv8d1TRB8wc4vzdN12XtmHTdCMQ8= Received: from localhost (unknown [IPv6:2601:281:8300:73::5f6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id C4B09FFC; Tue, 24 Jan 2023 16:21:52 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 ms.lwn.net C4B09FFC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lwn.net; s=20201203; t=1674577313; bh=e9Ms9NIy69DBSpc92O0jPbndqt+BbCrpQpQKJy7enug=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=WPbLObmI5eAb0UsjPjiNUr79jLBFhGBDmCGswQ79irtiddDZD2UhaHwuf8wU5gtfI 2jAAKuH+RBriYMbp7LixiK6L7pNeOUSxZFezSVb/0m50PA3orzwhQC4NuRPNqwGCwB XDrYpBoLrZhu/1rM+RSTjEWiP7ym60bfW/4Vo1Lg/rKXyJovUrqZu7VNX82OlQTAZC ZyjzajqT1YDtnHxcrXFSGDlm8v77Ug8RcmouOhagCzpz0AYS92XrGo6W7CfyimkdKa Jf1qzBf10+bNkiATeHsiLRqWoz2H91c1xuBWPntnymecG7+43dW6zNirv1E1MWCaQ7 YZ0dyfisBnmwQ== From: Jonathan Corbet To: Bagas Sanjaya , Stefan Roesch , linux-mm@kvack.org Cc: linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [RESEND RFC PATCH v1 10/20] docs: document general_profit sysfs knob In-Reply-To: References: <20230123173748.1734238-1-shr@devkernel.io> <20230123173748.1734238-11-shr@devkernel.io> Date: Tue, 24 Jan 2023 09:21:51 -0700 Message-ID: <87h6wfhpi8.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E1486180020 X-Rspam-User: X-Stat-Signature: egpo5rojayyiuuoinchodtjbgu3mgxyo X-HE-Tag: 1674577314-412283 X-HE-Meta: U2FsdGVkX1+KyrX8o4US0to4bXfXJTqZOsDyY2R7YPdt/f6AsyB21PrCi0zSjjQnrBEUsOYwDFnPZ45F+4gUsxCJYAW0mIIYiza7pHfiYa2YpPwSJux5Y0ZDxlqr+lLDNYTvUgnTvf+9RmCC2E4jq5aOEr7z9FhlASaSVcHpxk8VcwPsagGBlAYb0+cKmKeYCzVD0H23exLc3uHUOj8y6VspaPFWZ4v9dyFLd35Ql9iV4b5owkXwQwjKsxHu6Pb5bC7WoIe0gjOoz94JLrzIouZufMOh4Nyk+Hjqp52NLJmJZu23AxoJXNwfAAgaKhcfrfh74K2zXu/arSasJHatTbYazjb2r3EEV/uv3FUw0KxKSuAgZ9jH3uwMLHc6x+pvZViTpEjouRNcUNzAbmIZth+S1PS4W7FbZ9b8bWPTAXS/vXzLBeE/9ZI4M8s9EYpafPBXU3wpV9RwDUVQwAHXguDLPndZg1xiEXDn32ULSOGR8Tc32HoShbLFkqpwbhxXzgOuGLPRj8d6n5KptUgWiFoMT44dYlWpSLdj/m0QrUH+88Kq98QBRzy/F6eFLfuA7cBp0a4qY5VidDy7DyU4UiMfeCfCIQVgs3nukODbanEZf1W3uyFo1mzxPgPYp+uWdkXDIUrMe7nB2pooHdc0223nCwMSp27n9CgB9LlK0t7z8i0bmIFeRrUEX8Azdh81HIOAglm9+u7YdIgaL+Q983XHCrV6G556EL4At0pzf1q5O0kfumeoRzufl1oWaI0UeoY7fbI90W90QL1NJb741CtbbY5/prdeG7xmvZ0rT6ip3mXbLW7NfdWAm6/6pvIed88CBQ4uXpMrjxzY1rE++YYxim6CUZL9Gc/ZSP2cOhpWTnRTeyZNPKl7Vexcs9ST4zHnR5OnTrwSdnAW5qXINfywCVFXv1uCTxKj3VzSdsIrZ9v/V/GCY9RxIMoSPI9AC4KArQyVKqPqZrYlhot 7kTGnb6y QzN+DSvx9BTEIeeq/tqlCdrRtqhcmHQJy86bOsFABBOw5pK2ft26OzEmgTT6xCJakh/ajviZOkKD/NGIJH4mRLTTJyv6UpoY1eWtpS2O51WfZ6bLSy4j8a0Ofozu0feyH7JmX2zFYixgQ/5BEP+wJDyrRPcMUPHE+Eoc1oCFmj2NTmmCvQb/hN00Stm0yAdQxVmc4l5YCtGwFqJOhr1rtHaDSSAD/vTElXVCZDtsuLxC503pX8JYSJJhDFaO8M1zehwNFUOkXsOM3iKjfPhKZdPHKFpsfmMf56gEfag3vzxwDLfc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Bagas Sanjaya writes: > Seems like the wording is confusing me, so I write the improv: > > ---- >8 ---- > diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-ksm b/Documentation/ABI/testing/sysfs-kernel-mm-ksm > index 7768e90f7a8fef..5309a912ab679b 100644 > --- a/Documentation/ABI/testing/sysfs-kernel-mm-ksm > +++ b/Documentation/ABI/testing/sysfs-kernel-mm-ksm > @@ -56,6 +56,6 @@ What: /sys/kernel/mm/ksm/general_profit > Date: January 2023 > KernelVersion: 6.1 > Contact: Linux memory management mailing list > -Description: Measure how effective KSM is. > - general_profit: how effective is KSM. The formula for the > - calculation is in Documentation/admin-guide/mm/ksm.rst. > +Description: Measure the KSM profit. See > + :ref:`KSM documentation ` for details > + on the calculated formula. So the original at least attempted to tell us what "KSM profit" is; the "improved" version makes no such effort. I don't think that is actually better. jon