From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2918C636D3 for ; Wed, 1 Feb 2023 23:30:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E11A6B0073; Wed, 1 Feb 2023 18:30:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 490F16B0075; Wed, 1 Feb 2023 18:30:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 359FF6B0078; Wed, 1 Feb 2023 18:30:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 236946B0073 for ; Wed, 1 Feb 2023 18:30:02 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DB55AAB0F6 for ; Wed, 1 Feb 2023 23:30:01 +0000 (UTC) X-FDA: 80420318202.16.4AA6520 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf21.hostedemail.com (Postfix) with ESMTP id 5B02F1C0011 for ; Wed, 1 Feb 2023 23:29:59 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=SqfLzqcU; spf=pass (imf21.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675294200; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uR+jQuD2DpxHGhHrsd5zwHHfmLL8yC/2MzzyP/u43CY=; b=IgVoLJTOPXdKkxtqgYIeT6ZwDAaabpGuwt4HYGHxW3F1IJAJHvPcjZAwZyL3kKl+iCPFPB oETIDH0uFwZwqBEv1QR5CmayIeeXsj4do4BBvT8eikrtPWVDd3t4IElPsY8/xRIlEJG9uR dE18E2PaT7n/ShUb6tgWEi7VWuPk1L0= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=SqfLzqcU; spf=pass (imf21.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675294200; a=rsa-sha256; cv=none; b=cduNtfOw1MF4xwDhqAlRAcj3tCjmJVnXbQIj74NRHEtKqrb7dW3d+2nQtbbasMo8QDLBC1 Wgo+5qR6P+5SNoTF8m7UfSovib4MhwGWqX1R3OsOxR9iyS+L1/K1iu77oaLV0kzCwZNZSK Ij/SUc0Hwg41cS0xirRGq19Hpk+q9Oc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675294199; x=1706830199; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=wxu7TxfYIl4nxVHtHN/mKfBaXo5iAI8ZZC17N6TebWs=; b=SqfLzqcUkvcqNMLONNwgiAe8ywaXSZgiQqhBlxFDVM3yrF1O0mxVu4tu NMQiBiUj4xoW60CbUM0Q2BPOH/o8ZthkpVOCuu7kLKOFV2lotzp4+EKCT mAKXWZPt2iYmY1aHvPO2jCXxFOT+/iANGMpEaMVnFDyjKs4yRzDR//aQG Dzxlpj8ufdfcaljnOdVQn8wS+RR+UJdASvwJ5Fxdas1/R7US4D5L4nTjA R/aZN+la1CidHEIHsLlp4ARPfqpoVji1VMjN8GhFjmLec6YO7hWgDk0Q6 +Bea8ibhfeNnO4+3a+oz+7NCRJEpsM7T2fPOHb/NABodCPK7tJAuQvE93 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="311947801" X-IronPort-AV: E=Sophos;i="5.97,265,1669104000"; d="scan'208";a="311947801" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2023 15:29:57 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="665057362" X-IronPort-AV: E=Sophos;i="5.97,265,1669104000"; d="scan'208";a="665057362" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2023 15:29:54 -0800 From: "Huang, Ying" To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: linux-mm@kvack.org, akpm@linux-foundation.org, Zi Yan , Yang Shi , Baolin Wang , Oscar Salvador , Matthew Wilcox , Bharata B Rao , Alistair Popple , haoxin , Minchan Kim Subject: Re: [BISECTED] first bad commit is c203c6d5b3f0597 ("migrate_pages: batch _unmap and _move") References: Date: Thu, 02 Feb 2023 07:28:56 +0800 In-Reply-To: (Hyeonggon Yoo's message of "Wed, 1 Feb 2023 02:35:55 +0900") Message-ID: <87h6w5othj.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 5B02F1C0011 X-Stat-Signature: icxtdhjjjj1mh3x6kzocq7gjsnzkt4qk X-Rspam-User: X-HE-Tag: 1675294199-813579 X-HE-Meta: U2FsdGVkX1/s+SsxmDJrojqZ+iplOwyIvsla/zmwXvmeApRt0upK0lGoj2/0D3hSkOW3Uew/TRxBxnshVrM6kv9kno6JQC+8gRDcyGggp+YYdLKA8QKxo0mwr8qSIErw9XcISkDeFKOrzUzMTEYliifoSvrbO2RkKP/P//7tNETfrGmzfRlI9E8/iJ40xfNFrsGB8B0SmHVVmPuqeYqqz/+gQWZDK/8TjPA1ORGnx9VImdXQlYi2epwp1nSzld30x9zEpt+8c1VFHrDm24R3nrLmRzYK9LxLVdvygsKgr7Dkxy10d/H4OAu6DN48ToXAsjbPkW77H1NCS/VB3YZueifutCSFAvtUPfadRTQrCD033aTOfSaec4HWEpD9NggtIw/zPhwJiC4uzjzHv3M3wV6Rexb1edNh7EPGnqdNpNE24gLgONfLOabwELd6Hs5/+8B0akcYHZSuwJnAB0yhpBeJl92aYhyQf/Nz33OPvnKSvtYrA24P8rzlyoL6S3ArhnaVNhiCffLmMrDOCO42SnpsA9GiVfYVbsVjuqIo0fq+af5XUmzMkEXZaFqFXRkUsP+oytGBGD0h1pTrYycvt8Q5ToUVQ/TNrmzlX/37RkEdnILCON72Uv+3jSGnxZgLLnxd0sNTpneVkH1gWlr4KyOhONlYddaC7yFsJ9UW5Ejfy5Txf7MLGjyMBJd9LGH3qsBXO3DZgrO08CbJnf5rVdAjU9YFDpnOt7u74FIhBkT+9E1lDgN+xZitL/NXSQ9/Qx3ZEnIPsMHKcfEKnQHZmdLTsoZG69fiBBxM90evMP83oPKW8zpcQVT80oHXpFyKkyJoUocpV1RM8Nxls5mRInvpFVKjlzayxYPJlDz92hIZkaJLGInIdF/+g8uCDt4ENBVNCkZWFYhAYVr7Si4wRW3NZaemzN/S81BiUZGU0U1JAY5++z/vbzrYKAU9SDHgWwaP5gOXXg1TBiKwQR5 VAT2IBO6 ytTl9JZBaa1Wtf9u73FnYAcU+FjLewA/VB7zywgZy+ryBiWyyswXvVrrGzR0lfuKLWH9p5UJLqJgL+ke1VGeZCtZqd3tukG7trLpfH+lZWuC2Lj/TEjdfKy8qzhgxrN2pTHttGbkc+La+IF98+KRIzHfJPKS28WsqgEE6s2grvpS/vKWEyiLX1kZPKN8KZRJCdhcdqLiBC3WK/C4fcUJBSTr4AJGf0teds4/k94FnPkUfdrvc24IXOcSH9jWUe+5OGEsM6sKCSedDmJVYSxmZE9SiXDM7hxinmn5iz8/D5e1u25AUkeswJvbdng== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Hyeonggon, Hyeonggon Yoo <42.hyeyoo@gmail.com> writes: > On Wed, Feb 01, 2023 at 01:09:10AM +0900, Hyeonggon Yoo wrote: >> I've observed random list_del corruption on mm-unstable, >> where HEAD is commit d69862e693c069f4 >> ("mm/migrate: convert putback_movable_pages() to use folios"). >> >> The issue can be easily reproduced by stressing MM multiple times: >> stress-ng --bigheap 0 --timeout 300 >> >> The compiler is gcc 12.2.1 and config, dmesg are included as attachment. >> I will try to bisect but can't promise quick resolution :) > > > The first bad commits appears to be: > c203c6d5b3f0597 ("migrate_pages: batch _unmap and _move") > > the first bad commit _probably_ be earlier, but this is quite > easy to reproduce so at this point I think above is the real bad commit. Thank you very much for reporting the bug. I'm in travel now but I will try to find some time to reproduce and debug it. Best Regards, Huang, Ying > Here's bisect log: > > [hyeyoo@hyeyoo linux]$ git bisect log > git bisect start > # status: waiting for both good and bad commits > # bad: [d69862e693c069f4f67fc55c159ce5f6c6def42f] mm/migrate: convert putback_movable_pages() to use folios > git bisect bad d69862e693c069f4f67fc55c159ce5f6c6def42f > # status: waiting for good commit(s), bad commit known > # good: [5dc4c995db9eb45f6373a956eb1f69460e69e6d4] Linux 6.2-rc4 > git bisect good 5dc4c995db9eb45f6373a956eb1f69460e69e6d4 > # good: [b81cc59c6835bb84e72f1ce516121f25780a42cb] shmem: convert shmem_write_end() to use a folio > git bisect good b81cc59c6835bb84e72f1ce516121f25780a42cb > # bad: [1e2a127908bdbc11065bc08200d0add096d96245] mm: multi-gen LRU: improve walk_pmd_range() > git bisect bad 1e2a127908bdbc11065bc08200d0add096d96245c203c6d5b3f0597 > # good: [4d2eba3fd7c0b3ada6b474e4f13dc1238670ea91] ceph: convert ceph_writepages_start() to use filemap_get_folios_tag() > git bisect good 4d2eba3fd7c0b3ada6b474e4f13dc1238670ea91 > # good: [b22d808ef6c68b6fa2b5a97f5d02e83ab8fb732d] migrate_pages: separate hugetlb folios migration > git bisect good b22d808ef6c68b6fa2b5a97f5d02e83ab8fb732d > # bad: [6d8b6b69ee6a24a89f2552a12e43b7c9b3a7635d] mm/hugetlb: fix get_hwpoison_hugetlb_folio() stub > git bisect bad 6d8b6b69ee6a24a89f2552a12e43b7c9b3a7635d > # bad: [71d4be767f5fde1ac5df2ade1f654f19c24a0a3e] mm/damon/core: skip apply schemes if empty > git bisect bad 71d4be767f5fde1ac5df2ade1f654f19c24a0a3e > # bad: [68611caff673fc59c17f00dcd0cab2704987828d] migrate_pages: move migrate_folio_unmap() > git bisect bad 68611caff673fc59c17f00dcd0cab2704987828d > # good: [7199465b2be061f1b2bd6b5a1a5a96a822f658b9] migrate_pages: split unmap_and_move() to _unmap() and _move() > git bisect good 7199465b2be061f1b2bd6b5a1a5a96a822f658b9 > # bad: [c203c6d5b3f0597a15137b6394fa715542df78c8] migrate_pages: batch _unmap and _move > git bisect bad c203c6d5b3f0597a15137b6394fa715542df78c8 > # first bad commit: [c203c6d5b3f0597a15137b6394fa715542df78c8] migrate_pages: batch _unmap and _move