From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A6CCC7618E for ; Sun, 23 Apr 2023 00:56:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C7746B007B; Sat, 22 Apr 2023 20:56:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 177BA6B007D; Sat, 22 Apr 2023 20:56:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03F3A6B007E; Sat, 22 Apr 2023 20:56:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E90F46B007B for ; Sat, 22 Apr 2023 20:56:57 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B49BFA01BD for ; Sun, 23 Apr 2023 00:56:57 +0000 (UTC) X-FDA: 80710841274.03.FAEF09E Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf26.hostedemail.com (Postfix) with ESMTP id 5BBEC140011 for ; Sun, 23 Apr 2023 00:56:54 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=oH+sy0Hc; spf=pass (imf26.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682211415; a=rsa-sha256; cv=none; b=TgZbFzQLsa1nChlu9X/QQ32Eh0rnfnRfUsILKQj8K36XuHTS/se+zrqSENJSj16JD+9ueV k/FIn1zcAdI8JSkOzRc+hlPoHstd5NLz6Fi0HQIdNny1dQKYdnn4UUw9Dt8YyclbmIWelH vY75odnpVb+AZTFegmRlcONjj5dReyA= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=oH+sy0Hc; spf=pass (imf26.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682211415; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OXmOK/C0O49srEG3oe9uf71CPzuXlYkFRRif5rzmoVc=; b=QlE1zH46OeL7RuYtX5qfTO3r4xtgnxyQ+YVRfjqHvy6Fplrxl+Eix6yj8QSJ/XcXYhaz/M slqQz6pEFKI2qlpd9XgWWgzSkbnFN4A1BXH3m/YBWuRdT/RDMHcX54SuTRI6iDHUkvfBWt 0U9YxTtWgGfKkM8iDa2UDT/0CrUMJww= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682211414; x=1713747414; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=0X/4Q5twC3FRie9aoJ3rmcwKIX0qxnUdDpWJ83Ct1ss=; b=oH+sy0Hcg3A3RameaRJhZuNOq08YZTE8u4cKlY9McCmoRiMnGSFG6Fg3 bX2d2WAIRnITQ6pSdj8EkyTEsvBrUa+9wyvCHR/6NQj+JmMZKvzGpc925 CPYz1ltPYCJ8dRa4KcNiHmJwGBzX0yjJWIgGnPMVy57EqwCFuxfDj9p89 6GnBXKz2zMVeldpq0fccebiD60k52pj33WKdbSzquGPNeMLdLLbpSBFmX wNaRlupG0F1tkUwZSEMmG+g9AoD0vT5QqFBYCI7QgIWjk88anomyy/CCb 7TrUN8ZJYD6+GH7m3LJDUekLd1O9zzuMFWCJ2C6QwA2CQMdQxOS+LUt/6 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10688"; a="346239320" X-IronPort-AV: E=Sophos;i="5.99,219,1677571200"; d="scan'208";a="346239320" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2023 17:56:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10688"; a="686231335" X-IronPort-AV: E=Sophos;i="5.99,219,1677571200"; d="scan'208";a="686231335" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2023 17:56:49 -0700 From: "Huang, Ying" To: Baolin Wang Cc: , , , , , , Subject: Re: [PATCH 1/2] mm/page_alloc: drop the unnecessary pfn_valid() for start pfn In-Reply-To: (Baolin Wang's message of "Sat, 22 Apr 2023 18:15:17 +0800") References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Date: Sun, 23 Apr 2023 08:55:45 +0800 Message-ID: <87h6t7s9gu.fsf@yhuang6-desk2.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspam-User: X-Rspamd-Queue-Id: 5BBEC140011 X-Rspamd-Server: rspam01 X-Stat-Signature: 9f698xnhi7wzeek7ryqnzcha96be4nfh X-HE-Tag: 1682211414-166491 X-HE-Meta: U2FsdGVkX198o+HsnRw1fabVWBmspdJrP1u1mUHozQpNhtdkNXIC152PPnXQG71ZHkrc2fF8tGPu86vabmAoUqVp6GD6KlnjKE4841UObtaDXH+PJ6FCQ2aFYti3F8TD1kz6mG2ZEvwRGXQaIczmim7Wp5P8l49/VljUvkue8M3P9ZPmkdll4IZlHVfTBvPd3c89DuTu3Z0I5tDM5gkpJb3AkQA/J1CKMNL35ApMUZ8EJ/q4SwyswJy19c28RIavEZyBnoX1rovbMQQ/bqewo7KTykKyZuxL9/Q/CujvXEt947tITkJOGQPoUKGwezTBcbikR9TZ3+aMg34NHI5BAkI6BWBk2s29e4akw6Hs7fnLC5XQvsYINXZmBeTI3z8RtdKbGf8cGPwL+K7vyCAsh1MVsHpFvThdAvAuRUolYXf7D365R6gOhkai64LzRnY70GYjDuOxabet/MNojvfrQcFE6Fr4+nESWFRqadiPOM8ozpS27xfliyx0kNBV//nebPmrakvBvE5hxjaxD9WpdGJb2M47uvOfivm/GYDratg4foPvIkBlZ+O51Tk+KyAmrAXzZEXwWvJqxKjzQFFEdd4+Jqet5AegQrhYF7XR4osBK4qZkMOv0Pqkodhs3gh7BwKx8A4XdTeo2SvPRsAombQVi32NfS+zJ1kV5UY0+r/VubXecZPOmv0qtpuFxXAtlW1Vw+bRK1ZX1oULlyyA/w/xx5m3baUEDrIWesznb2yb11RZsZqmf5JgsbIESjuSewlX9ZTFa0P4Yacr06m10c2zVpRxIAqDRyghPHBGv2Q2yFqmkgn+YBYmLQUcsvuTXeBRlsExmOHul7Og0nDe8ga2zfm+ZX7IIxywJzHyteri9wxrbLX9EbvRpG7lV7dO368+PXm0MlMvQ4iiSkwjVUPE1/uBJmuvLX6MHlfoAcZjUYsIc29EU2N2ya81arWWAxQiPvH8g4DKtCxWY5d ICKuUGqJ p1ZhaNRK5Wu+kO6DG4L4whRpdj83/ct1EYD62DLMhvBKTkm0bQ81mjO4Z3KXNqvAAuOu76dHvtyvxmgzyEy4zSiP7ZsRbwoRn+c7WurbRX+LqdJLuv74NcyM42GyHqEvntthPdvM4YPqPJ0q8Ld/Bu++/X+S6qaANmMr+yxLvdxCs+8FwvzLfBgrp/HhmncTPeM25EaMUjw99IG0Db/hNBQx8Rgex+qDGN+9p97ppYvqMHSNgqGMt9iX9yH1EeihaAd2HDEJ0/ExT7FM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Baolin Wang writes: > We've already used pfn_to_online_page() for start pfn to make sure > it is online and valid, so the pfn_valid() for the start pfn is > unnecessary, drop it. > > Signed-off-by: Baolin Wang Thanks! Reviewed-by: "Huang, Ying" > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 9de2a18519a1..6457b64fe562 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1512,7 +1512,7 @@ struct page *__pageblock_pfn_to_page(unsigned long start_pfn, > /* end_pfn is one past the range we are checking */ > end_pfn--; > > - if (!pfn_valid(start_pfn) || !pfn_valid(end_pfn)) > + if (!pfn_valid(end_pfn)) > return NULL; > > start_page = pfn_to_online_page(start_pfn);