From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF985C71153 for ; Tue, 29 Aug 2023 06:10:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 499B18E001F; Tue, 29 Aug 2023 02:10:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 449968E001E; Tue, 29 Aug 2023 02:10:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 310DA8E001F; Tue, 29 Aug 2023 02:10:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 210A18E001E for ; Tue, 29 Aug 2023 02:10:26 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E23E9A03A7 for ; Tue, 29 Aug 2023 06:10:25 +0000 (UTC) X-FDA: 81176117610.18.75A25E9 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by imf27.hostedemail.com (Postfix) with ESMTP id 433524001B for ; Tue, 29 Aug 2023 06:10:22 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=b5tLPQVL; spf=pass (imf27.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693289424; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3LpWiOksUXuZvNwUvn4AUccoKI79SjqTjN7RiXH4nBc=; b=jVvathXasJrr6xpkft3vAHQclSEQllbXa64gyhXONEInCnqqtUgEmqrMXAjKRqZrxhXJMs DpjoTluLctyIONZLZdjMr9NWlLC6KK6pqvh4uknTVuGPR2UZdSWZ2/ADXOe31rDPI41e27 yg8lnk1VZVSN8thJSzfzeTQMdKPnahA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693289424; a=rsa-sha256; cv=none; b=hPEYRZZKqd+xql6wm1paMsSfD2qobLnc7ZfRgGzQy+VAWZKkUs20oEp5laFkcAZ4SkUddE 0sX0DyGffO9ku9x3Fgh2kXBZpxspXMv9J+nYes4Pd5KjpF72PonUhZxnNc7/wVqV61FmDK O+FscG0YtxKccF28p58Vos6TIrnSo9U= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=b5tLPQVL; spf=pass (imf27.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693289423; x=1724825423; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=nvPDIFg377zliRnyEf2uQQZQ8UkypFn5SQhyuarr91w=; b=b5tLPQVLdSoJKi3iGfJ9LjiDsBBjj7IWl+8575aYyBKqRmUNNkWcQPOQ +5OprRs9XaWyZEbqhvbsqEDvFaZuR195k35cKncZkaNFUdUrC9xFLvcMU ipXiBk+pdEyAMouJD71Ys0ocO/tEuegwI0CBJBgIiQiXFntzHojowGY6i WN5EdDP+twsDOZZTXe5uusnuLb2oXffQTxFYC6OYbvihO4qdOz4cC6fAv TOA9Ljl5vs9Aew+vaKb2KQU1zAlVKkpk9nkpM1Xo8rKufGV9FkNddM8Av Pn1ukI8y5vQL8xjbXHF9SpJ7WRXlafFrELOiiAZwRX8Qu/3Ev6aXBozNQ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10816"; a="378007735" X-IronPort-AV: E=Sophos;i="6.02,208,1688454000"; d="scan'208";a="378007735" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2023 23:10:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10816"; a="688381879" X-IronPort-AV: E=Sophos;i="6.02,208,1688454000"; d="scan'208";a="688381879" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Aug 2023 23:10:19 -0700 From: "Huang, Ying" To: "Lameter, Christopher" Cc: Michal Hocko , Andrew Morton , , , Mel Gorman , Vlastimil Babka Subject: Re: [PATCH] mm: fix draining remote pageset References: <20230811090819.60845-1-ying.huang@intel.com> <87r0o6bcyw.fsf@yhuang6-desk2.ccr.corp.intel.com> <87jztv79co.fsf@yhuang6-desk2.ccr.corp.intel.com> <87v8d8dch1.fsf@yhuang6-desk2.ccr.corp.intel.com> <87msykc9ip.fsf@yhuang6-desk2.ccr.corp.intel.com> <94b0e0c6-a626-46a1-e746-a336d20cdc08@os.amperecomputing.com> Date: Tue, 29 Aug 2023 14:08:15 +0800 In-Reply-To: <94b0e0c6-a626-46a1-e746-a336d20cdc08@os.amperecomputing.com> (Christopher Lameter's message of "Fri, 25 Aug 2023 10:06:19 -0700 (PDT)") Message-ID: <87h6oi4bzk.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Queue-Id: 433524001B X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: y9j8buwc1g3uu49psuf5pc8bahdih6fb X-HE-Tag: 1693289422-874871 X-HE-Meta: U2FsdGVkX18aQ7GXJzuj9d17HAAOcXoxPsMZ/c4tdFp2g6dsrp6wGkbsi1V8stVSJnxyD9TspEzHo/LGybMeUs9ollrLRPH0oK7cMH5IouOXGKmAsSzRs1jnVWau8Iw1dba7DdZx9RJT84HlTh8mYzJlRWzl4BJnNtTh1JZPtx2UfXNjsGHLZG+HzHH08t7q//bZ5dur6wuAMoo7hCUWPfw3a/MgenCMacyZN5qTPCStLeQW2tazG6HGI6KfvGDPQFCTU3HH26HpwO236ETu/fmOTOrK9GYabgDFNuxkuZyHcDmI7Z4xaEpqdCkWVd/Vg/0ojVWSjG0hN+Jhgc2bErYs2ugL9YEBiBN2QPhGtMUC6tPPEg3LzvSMoAUIaX20NDi2m21vAh19ZLcQe0aPJokEtKFasjW2QgLo0SjPF87jiKke35zQjzSUuZc/z6kZM4LZi4lr9t33r8pJsqaK6t0EDkS5Jd3vf47OoRtQc/caoE2tgylOSFAwf7SlurzeUZHgI3FDwR7eu0oJmIgkopqMJ7DU7z2HUPwY/i5fZxuJLofNbVQr2GEfeTK1o1mbT48KCrgFBcawxBZfz4XYpHh/1FCm8cBQJrcA1v89/22SbiiKnRJdW58WJwhOt7gRR/v1i3VmG/c3aDhJgaKkEWjvDzwD1B2FYXw3XuThskt0fCQBxM5Q2y6D3G6Fc+jMOcZUJOQIWcy8XIq1aru23HRElxdYeVBJLhyCzieegKvCIA3r08sthVCeboEyCfEokwi3v7bcS21BnQ7SKiVnV9p0/UB9QF5q5TjdVZrqxyoqTXQnGDXY6nXPXxpUhNZaz44UEA30rt8Z418eHAwmB89knzlAJAyggSNCdN3wr4CEaRbN5OwBHA8lh+f9wfIUpkUXVwvoP1ISrorAJyUMLygvmQ6gt6zfVPqti/RZ9DPeSkn5w7DwjQpQcPuZ3lbYct6HnIhIs6k+vS3gURk ZffdKiGp IEZgTxwERKWCj10nPEpddz1XuxWyXxDo7EWL0QTrfJV1H5VZFfqMEaNTC6lYPOtqJS1XHQoJWHVj9GnRMVVmAcY8+MqCgbXJdtEbqXy5WIA7S6iGibUewxCN1NArP0uH4UtJvXe+GAqt7L2Gj0wy4WLZ+QmgRvzk6ldgG0nu6iWnEq7yd5N1l2/GGoNvuw9oRGb/3on9HdMysbuM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Christopher, "Lameter, Christopher" writes: > On Tue, 22 Aug 2023, Michal Hocko wrote: > >> Yes, this doesn't really show any actual correctness problem so I do not >> think this is sufficient to change the code. You would need to show that >> the existing behavior is actively harmful. > > Having some pages from a remote NUMA node stuck in a pcp somewhere is > making that memory unusable. It is usually rate that these remote > pages are needed again and so they may remain there for a long time if > the situation is right. > > And he is right that the intended behavior of freeing the remote pages > has been disabled by the patch. > > So I think there is sufficient rationale to apply these fixes. Thanks! Can I get your "Acked-by" or "Reviewed-by" for the patch? -- Best Regards, Huang, Ying