From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BDC9C54798 for ; Tue, 27 Feb 2024 08:36:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D322D6B00B2; Tue, 27 Feb 2024 03:36:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CBAC74401FB; Tue, 27 Feb 2024 03:36:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B33256B00BE; Tue, 27 Feb 2024 03:36:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9FCF56B00B2 for ; Tue, 27 Feb 2024 03:36:28 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7533A1A0AFA for ; Tue, 27 Feb 2024 08:36:28 +0000 (UTC) X-FDA: 81836927256.15.E12082E Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by imf09.hostedemail.com (Postfix) with ESMTP id 6428C140010 for ; Tue, 27 Feb 2024 08:36:26 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=metaspace-dk.20230601.gappssmtp.com header.s=20230601 header.b=r9EuXzSW; dmarc=none; spf=none (imf09.hostedemail.com: domain of nmi@metaspace.dk has no SPF policy when checking 209.85.208.47) smtp.mailfrom=nmi@metaspace.dk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709022986; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tBm5IIGFhkgiqabszftedxFLBNT4N4zs7aN7ZnS5cF0=; b=G9872uSBW0qncENFnkEhTGrVrOF3RpW7CNmFthDjeq3IgjCtlVyxe+E06Ktp3oT3ttbFaF SUtvE+Kert7T0SQG4idUz/AJzQFyBQp9ihhXN/1TtNtZTm8BGnRcpcMtIaBbFNAwZbUWMB LvYH8mDSYYL2SDFWxAzodD5sgJk7fzY= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=metaspace-dk.20230601.gappssmtp.com header.s=20230601 header.b=r9EuXzSW; dmarc=none; spf=none (imf09.hostedemail.com: domain of nmi@metaspace.dk has no SPF policy when checking 209.85.208.47) smtp.mailfrom=nmi@metaspace.dk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709022986; a=rsa-sha256; cv=none; b=ZjiV1/PNap20WlIHKDnC6OkuzeZGv6T+cDAt7Hs6UTLtB8h3lRH4aAIQrxE4GXs1ajd2dO ue2yELP/ZKdPX0UiM+LzMlMrLIIYQAM6brOb+FQOoQ9SBn/QXxK5qUgEb1oVW3SoucqjAe a4DOeURglIvAb7Vguf01n13oX0xqkXs= Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-564647bcdbfso4053504a12.2 for ; Tue, 27 Feb 2024 00:36:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=metaspace-dk.20230601.gappssmtp.com; s=20230601; t=1709022984; x=1709627784; darn=kvack.org; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=tBm5IIGFhkgiqabszftedxFLBNT4N4zs7aN7ZnS5cF0=; b=r9EuXzSWC6SFS6XJIZGi8AICxHwEWSpDJN7Bv6enBn/lIEiRMx6XUYqMnKGZZWw/gm nuACsvecDGTKZlVLZS8AelvY8L82vCzj/yqEY5sKYH8yM7FLAtF5ZtLiPH+Sx6NX1ZOI mXqq8XEHIL/p/7T032uhoAu+PZffn0eVlS+n75bANtv1PfuB2TSDlgwKet5k+tMujobI 2frS41ZItrULw/0j0QdZfz2FZB68HjaMSHlT6djoYKsMquDb/UyDABG+RJBgvZB5BGlW lO3g+NFN9CCd+F0eM3WkgAenUIZ/9+9kOtrrEusMfFUI3y5SFJjRkqIoWuHlnmXlCvec BVGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709022984; x=1709627784; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tBm5IIGFhkgiqabszftedxFLBNT4N4zs7aN7ZnS5cF0=; b=omR0Z02luR2T0VaIiRVfk9UFdmoDJlLRvtYDyKwyi2wutjImHPfbGOlRR4DnITNdqb dY8fY1mY3fe/q+Zc/tedWu5cH1GRNNnzB8nRLzfGe1TPB+yG4bAH9Rmqc3EBnvnHu/x0 tWLwQ9/fNajb7Nr85uLBbr7L4CW2Hu9vefpA1TU/bjkphpvZfuKNqWSlMa5i8a7NhFQz cnUwKAAnEMddKr3r8cXRMdP2HnAUDHDbarVEoh3oMehYKFli86U/TV5nPgdEr9ZiZBDE t2/djtIv2Sz2UmSOiTLc+N/NtpDWa35mYLa0YOhPTwF4LlC8jSWikgCUjYMmRZ8rs2MX SrFg== X-Forwarded-Encrypted: i=1; AJvYcCWBdG6dtpi1IVSGS7EWtU2Ub7Z9Q9/RiTFKJIwP6qQqkQBLAu9mXZ4NWODL4+YD/t47NGaAB2MFnSfnP0gmO+SAEuM= X-Gm-Message-State: AOJu0Yy3/XQbOPr+RN1erSX4nUeH1lQ4+LJ2+ooQkXnQl55Z1fy0wuDK Id9yLu2cvYJ38Jp1ZiTAsScmm1Zd0frheamLEIEJKgsM1iqvmP7raz5wjUXNZd0= X-Google-Smtp-Source: AGHT+IEmSlqSqeopobEyVgC92+uCi8Y34RHVrtsYAkNKK7bVxD/WCyfc9qMKmBQUExQLWATnFTHthg== X-Received: by 2002:a17:906:c7d4:b0:a43:20c0:6f7a with SMTP id dc20-20020a170906c7d400b00a4320c06f7amr4112372ejb.48.1709022984519; Tue, 27 Feb 2024 00:36:24 -0800 (PST) Received: from localhost ([79.142.230.34]) by smtp.gmail.com with ESMTPSA id hu11-20020a170907a08b00b00a3fcbd4eb2esm532864ejc.1.2024.02.27.00.36.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 00:36:24 -0800 (PST) References: <20240208-alice-mm-v2-0-d821250204a6@google.com> <20240208-alice-mm-v2-4-d821250204a6@google.com> User-agent: mu4e 1.10.8; emacs 29.2 From: Andreas Hindborg To: Alice Ryhl Cc: Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?utf-8?Q?Bj=C3=B6rn?= Roy Baron , Benno Lossin , Kees Cook , Al Viro , Andrew Morton , Greg Kroah-Hartman , Arve =?utf-8?B?SGrDuG5uZXbDpWc=?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Carlos Llamas , Suren Baghdasaryan , Arnd Bergmann , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Christian Brauner Subject: Re: [PATCH v2 4/4] rust: add abstraction for `struct page` Date: Tue, 27 Feb 2024 09:32:27 +0100 In-reply-to: <20240208-alice-mm-v2-4-d821250204a6@google.com> Message-ID: <87h6hu9udb.fsf@metaspace.dk> MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Stat-Signature: nzuh34fgn9z3gniiz1ykd4njogeubr8b X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6428C140010 X-HE-Tag: 1709022986-789399 X-HE-Meta: U2FsdGVkX1+dFerqApLoqBYyRWyrzD+i7YnWH7CdtfUZyBK8QIo11TIMwEcw/qynVgxVaJNe2tM3I1VjaakmreAv+CnPS0NuFnahUawa53RNDANMSGeVkARm352J444FNkeX5TERCSFdDHi18NXo3QkTNMRm5urD47F3eud/ggj0bE7/KfB4gjDewcWbC+WGqa8M+6Aa9S0M0x/fQ/maqSlqRCYJzHWlP6HYYTCm62rGmG2ESrIrDUEiU4vzwai5TkQvNibD3j5c6SETz/oOYAd+QWhBjlWX0JEdyb9n0g8dU5woLYNRLEwsDb3vX4N075fCTf+7z73qvfoS1kPFMvJ06lFDwCetB1EeP7tZpt0Dg27ceLTEHPdjNTKsLieeKyhLtqQsSj88DhnFIHidgF+dnXT1yjgNFepBgRSjgidVyh25M2LJETNNuSoFpXZl+zGOLnirN7iecJcS6RbpWGrMCOa3U76cfx+om6ZFuyWRGHH5O5CE1eCFJHEDxC9glE9dJ0PoCG/01qybd6/krKa97I8cXk9ax1QxzZ5mXxNnr9oPn9/M0+FO6JgGODCSG7i0Iarl5A6LjklvZ7k2KIgoczCoGWn0asp/5Q9lsF4EAEV3+70ZzJkSY4AhBsOoS1LuQ84vnydEf8bFp9yhoNo1yVz4rAHpNlZuIXGjDGbc0144RT83Dx4Gjr+ggzKhAAeBBJsLWe9aMwu8lKLxSkfQJzpmCYCRQ+7aLnLQXY8oxc30uMm6tApK5fbjnSkHe36Kj4+QOgtWxdoEPkq0rveP6tc8HOocpj2wSKAQPXtWmRDe80NC3SyHGtuUaK0Ma6VI9wYLOm9/sB364+Xr8MYwdV1CG/niz1d85cszj5rVndJhp7ycII8Vn5WL4bUzxxfA7CKth5LptwSoUl7zkO6kQQaOJLl1W2C8Q6gGP/d/YwTw2xmoNb6vZIVJ0Y2TJLnOWzS+fzR/3XmEVlt iKGktyZu Kxqc9zspWrzSwMO38NnVV5VlVcO8Suqs3HwxhNsqDeZxeM88nvbiGw6lcjn0V5JxvQpsp1WoOoui/NYOhBv7WdOWMWwBr9vu16OkImlvNnEOZkrKHg0mtPS3FXvEC7zdJNe+X/eI6aXSSR+j7FY683ALL1KLyxb0Gcx5Z96F5Z2Cj9s9a5lVT3C/Tt7rZMDwszbo5TiYjidLgJeOayWQXGcCJaWTUXchI1djZ4C2rx8ZTuuVXyt/F9lqgPDMBm4vkDfgd6yinu+HsulQr1RIuZWfMq49EZMSxH34gn2qNzl2/G0MydBcRG3GVApb8VeoA+E+OMbM0C7Cdn0i/iI5u09z+w2CRQjfLOFhnTFofYw0v3wJVqyzWw6MVvSFwyOnNievZDYM7NzT912kesnWK+xD7Om6h/afG3hZhTxCkXTaRrT0zWrMMLYXhxY1licLXy61Bw4qT31qF5rFX5/hDVtEK0+10/nARae9NE9Ot84Loe/GQvCEKJ+nRjMGVY1BeBAa/4JY23/8CFfl2kHP1U2Ah/4b48SgB32pi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Alice, Alice Ryhl writes: > Adds a new struct called `Page` that wraps a pointer to `struct page`. > This struct is assumed to hold ownership over the page, so that Rust > code can allocate and manage pages directly. > +/// A bitwise shift for the page size. > +pub const PAGE_SHIFT: usize = bindings::PAGE_SHIFT as usize; > +/// The number of bytes in a page. > +pub const PAGE_SIZE: usize = 1 << PAGE_SHIFT; For consistency, could we get page size from bindings as well? The folio patches already do this [1]. BR Andreas [1] https://lore.kernel.org/rust-for-linux/20231018122518.128049-10-wedsonaf@gmail.com/