From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6895BC52D7B for ; Fri, 9 Aug 2024 01:13:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C69486B0089; Thu, 8 Aug 2024 21:13:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF21D6B008A; Thu, 8 Aug 2024 21:13:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A92B66B008C; Thu, 8 Aug 2024 21:13:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8A59F6B0089 for ; Thu, 8 Aug 2024 21:13:29 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 34F3B1203B0 for ; Fri, 9 Aug 2024 01:13:29 +0000 (UTC) X-FDA: 82430934138.30.AB19EE8 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by imf24.hostedemail.com (Postfix) with ESMTP id 567B8180025 for ; Fri, 9 Aug 2024 01:13:26 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=h8R4EGTa; spf=pass (imf24.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.18 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723165941; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b/8PDvmN5Xe1hyA5jCvd+DP8DbZVcpAzH+OIpOcJjRs=; b=2RDegDNVg2Cl3Ku+QUeL0R3Audqbu/Rhp9lkvXS4Cdl9tDiXiswyC0xot6Dya3tPCdLT2I jUtg1p0Ce1lt5MOyqjoolaWIOq7pdS89jx5MMFoP70h79AJmXr8bFy+07ruOOAEdLjONuI oygI2s+oPR5r3QB0cBP4368dW3v3Bxg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723165941; a=rsa-sha256; cv=none; b=D148fhe4/N2M1puJC+XmIIOLxI+dhAAEu7+wQiYLkjqmsF66obnU69qp+Eu3BPvW3z+Lxd rxrZuJUvEqSCl6Edng9pcLxI2nfT7Ge3mcVAudsMZdcGLo7wFzpN7/V07xcWGUDjJPp3OK BanM83Jpq7e9R3BYy5F5oy+fIuNQc1U= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=h8R4EGTa; spf=pass (imf24.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.18 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1723166006; x=1754702006; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=b/8PDvmN5Xe1hyA5jCvd+DP8DbZVcpAzH+OIpOcJjRs=; b=h8R4EGTay4VjvjmR7s9XTJ2Eh3MLEslSXsn4o23v2U5FsOAErNdZHO2g wovzyAPxt3M8EU1JBXK39fx5nJHYsFwZlgAiIG3aINo3lqBfxaZ/j3IaY PAX9GJXoGq6IXUsefvwaPfvje71dU1qehskSPGp5J1+rD6WyKiVuJEKvW C8djmJs+iWJ60SifXJm9w0Mp8KN3stfANYn6H/s3BgMpL2uCiltlPBxE3 5HX/QApMUU/Dp6WGOMz/iP7U8oPIo6qQeRiGB/IUFsvvOXN26k1yuO4OY Jfk5UPboT21eZrJXKCvzKll1Fj3swrkpHrU03R8Wgh88KMhMHUofoPptF g==; X-CSE-ConnectionGUID: 8Pmt7tkxSaizxqYhYj4nsw== X-CSE-MsgGUID: k2wfUR2kSE+GExiDmxTWXA== X-IronPort-AV: E=McAfee;i="6700,10204,11158"; a="20890957" X-IronPort-AV: E=Sophos;i="6.09,274,1716274800"; d="scan'208";a="20890957" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2024 18:13:24 -0700 X-CSE-ConnectionGUID: BRPClLLHSOS4qeCu8qwPzg== X-CSE-MsgGUID: Gm5uafUSSqW/nOgT7Oqqpw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,274,1716274800"; d="scan'208";a="57283865" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2024 18:13:23 -0700 From: "Huang, Ying" To: Zi Yan Cc: , Andrew Morton , David Hildenbrand , Baolin Wang , Kefeng Wang , Subject: Re: [PATCH v2] mm/migrate: move common code to numa_migrate_check (was numa_migrate_prep) In-Reply-To: <20240808233728.1477034-1-ziy@nvidia.com> (Zi Yan's message of "Thu, 8 Aug 2024 19:37:28 -0400") References: <20240808233728.1477034-1-ziy@nvidia.com> Date: Fri, 09 Aug 2024 09:09:49 +0800 Message-ID: <87h6buzele.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Stat-Signature: gek1osk1y6gt5csyu7qa4g136sngrpdr X-Rspamd-Queue-Id: 567B8180025 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1723166006-891736 X-HE-Meta: U2FsdGVkX18335yxukSrqXcS7Qf6oHYZhQ/HZiXBaoMtolvGG8foEJMq8rVQ5ieLa0ZGDqrGcMwrxP8Y+u3Egzb1V7w+dRQ9845/Nz9WjY7wH0GdUwghUmC8zPVtfM7VPY/tbTTjakrP9NhHOp323VkF5ueE5CLQLX8rmlJZoSS43K++MP9+tEwJCK06E9TZgOkQKdDyxl0plbSTa7glX8HlM/nn4rcQI/naSJTsgCkWmUvcPqhueAFNqR/N1DO8Yw9HSCfUnAiZbFjAq0kHtU7TATAvnnIL5GnmD3IJAoKuYdARGw6Nn0q9dKJNyz/qkv9PGE3n9Q/HTO7n/X040sYpXvK5h6+mpaEsZsDtGC8AFLb7Z3d/50UnkUMPthfy3/f4ye45VEeZaDSVdaRn4PhVLzDv4I4sdXPTzXs05G+w+q2aC0N2Jx5ksq/bvxqXAYzwhHbiqKShiMvmBhw0AuRnZ1zksXtEXOq0ItQiba3pY/wTuXC047DACgMXvyKD8kOZ4civ8y/K06zxtxTY0aEhdKRsIvu5jqOR9cSa7eDl97qJ3K7mZD/F5jeLq/v9nSTove70IodbJ9wrT+h1hA3lxLQkyJTMwhLApwFk4eccO7MKweAgB5g8//fnVAj+lU6uDUvyIa3NnejKAiTk+4rtDdkepqM5Qg1D02VIz74zSDZTc9OdldnxLgxb154uVUXjtjd1F5oSXhT4cvqZXOt4R7FVHw69YYtlLjMmZ6UdhBSWznVGnKPjq0IZxAnV7+EYoMmOGEs/yEGJxO8vtgWkNDf0cI3/sPgx19QJO1V6u8cbbIkoA7e28bp9p3mr9oDU5dhmQjosm9HImBChwH+09tU8+sz7xSJFkyfvYwPxPWuIHe2mpwhoHvgUK5txTG9ENwJ7ZHMpg6X03I8QBmFF6PMt8q99pET53LFpq8Jahf90LW9AsEZokPyLjqfeGkqHDjhyD658UuD5lEE qytVVcNm jhpJt7/mzdsOvQcZOk9RvckZSw4qEfKMffRMR5swFkC4ZuyCm36+/vdQUODABESse2LYiPpO3A6grUQTn8Ht+OXBGiHbgZZnB+uOyFyKZX6AbX+Eq82uejGWBfY7EiZfKr9lM0KBklj3Eac3XU9N2OXiXeCPVF6Z5JQlW4CKotuGmMJ2FGFTCz10HEf/IjhfpgdICguP2Z3ZHbxsVKXP+GB38umlqbbwNQsz3c4sn6nC9UA+2iC0x9DLI/mgwwpuWerdu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Zi Yan writes: > do_numa_page() and do_huge_pmd_numa_page() share a lot of common code. To > reduce redundancy, move common code to numa_migrate_prep() and rename > the function to numa_migrate_check() to reflect its functionality. > > Now do_huge_pmd_numa_page() also checks shared folios to set TNF_SHARED > flag. > > Suggested-by: David Hildenbrand > Signed-off-by: Zi Yan LGTM, Thanks! Reviewed-by: "Huang, Ying" [snip]