From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C14DC3DA7F for ; Mon, 12 Aug 2024 08:23:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33B8D6B00C3; Mon, 12 Aug 2024 04:23:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C44E6B00C4; Mon, 12 Aug 2024 04:23:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 165736B00C5; Mon, 12 Aug 2024 04:23:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E8EC16B00C3 for ; Mon, 12 Aug 2024 04:23:21 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6D7B9C072D for ; Mon, 12 Aug 2024 08:23:21 +0000 (UTC) X-FDA: 82442903802.03.77F1C19 Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by imf29.hostedemail.com (Postfix) with ESMTP id 843EB12002F for ; Mon, 12 Aug 2024 08:23:19 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b=GLLPI1hd; dmarc=none; spf=pass (imf29.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723450988; a=rsa-sha256; cv=none; b=K/Z8ko+UwwCukn9IEPJpw31QNyH5xu6WP/M79n2quqzY1NXxJp+cmdz/7DE3JE7hZCYK9h Tt9eWO9g6q9BkLF7IViTm+AvnvTeI/E/A6LM+v7v9wnu+MQ2saXvmv45xLgjge+mpqilMS OiB9MQTzDcH3yvfGInq4TVhP5u21wWg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b=GLLPI1hd; dmarc=none; spf=pass (imf29.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723450988; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SjGutqBaqZgjd7wqw4U0lQPoWxYx0nIAM9EvIIKTQn0=; b=s1K9dXR2Be6vCQdPBlyEBL321Q4aJCIn//c0arnKMCiUyNPCTPZ31qH0BH3vUsuvUJM4Gk YPfhFQwxrq+a9CU4sN5K51YBkTkxmjZpF8EZVcj7X0c29wsF5sAQOi6EUJdw7G5obF4IQb /zzuUzBU9yHqQjJpx+Pr2R3pNEY/YSs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1723450997; bh=SjGutqBaqZgjd7wqw4U0lQPoWxYx0nIAM9EvIIKTQn0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=GLLPI1hdFzEgX6nkjZVe0VO4bsQo5bRJxASR4AK5UZ78M88a8/LssElM6PKMmC3FK 3FHQdyReAjWheTxnqGT7t23bQ0IBRdlmv3TBpQ5DDHq933iufgF1u6FN/ZQi/IJb0k ZriXOcGwHS/ejpyF93YpxnyuPukCO5sKBRmscjuW1gUsHB3jNWQ8Ci7RQcAJlxli5b FhqIqopot8q2+bt3mhtybarzrcFDpJHuovtkTSIESV0VBicL5JyqQ/SNWk6LBn6nEy DRQi1jZIQQfXwfvWWRqP6SHKC/92pw7L6xPhGF3AmFbQTsrtjzZqJytysn/t714aRR k4UxPTtzp1goQ== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mail.ozlabs.org (Postfix) with ESMTPSA id 4Wj6wP2FB2z4x8M; Mon, 12 Aug 2024 18:23:17 +1000 (AEST) From: Michael Ellerman To: David Hildenbrand , linux-mm@kvack.org Cc: linuxppc-dev@lists.ozlabs.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, christophe.leroy@csgroup.eu, jeffxu@chromium.org, jeffxu@google.com, Liam.Howlett@oracle.com, linux-kernel@vger.kernel.org, npiggin@gmail.com, oliver.sang@intel.com, pedro.falcato@gmail.com Subject: Re: [PATCH 1/4] mm: Add optional close() to struct vm_special_mapping In-Reply-To: <1b0e07fb-33fb-4397-b03e-65698601bc70@redhat.com> References: <20240807124103.85644-1-mpe@ellerman.id.au> <1b0e07fb-33fb-4397-b03e-65698601bc70@redhat.com> Date: Mon, 12 Aug 2024 18:23:16 +1000 Message-ID: <87h6bq880b.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Rspamd-Queue-Id: 843EB12002F X-Rspamd-Server: rspam01 X-Stat-Signature: dz97c3946wzpyjesmkfim5z3iha7pwk3 X-HE-Tag: 1723450999-800315 X-HE-Meta: U2FsdGVkX19QndbLdjTGJuzgCEv2FIPGNvM8fFj7gUUKx2fPjxhEN0Y4DW7MXuvN3D4E2QTRBHNRhRi5gcwsnLvb70EyLjXmOiCRS+yAaOdWLkaWQzFgWMBlCf+hbCw/Q/AzyTX8u57+3/Bj7hBvkzJp7/e5s5bEHXVw0o8yd88RF95Sv9OlBDcfww3h7eX3Evnp2YMhwDictjTjcXdNPPXhQyqiCQXhAjxruymDA4YV6gHKN322jw9NEwsx7kpjG5wUMEWPn+0FOe4hc+dpQy1tP8Kx8OPaAqRPJT9c2Fpkw2oyyrqXmPe+OycKvue9rqs62WJ8q7avOLCl4yF/kdeochnmM1aPA8iD4wbT2f57zjVd7iDfv6vFLjmQv8j1osqLIamsz3OWeti0so42U/BkYmB8HmcumpJ4c/S2MGob8cy4bpchMHTesGmLKHUwhnC7uAAKrgclczqebnoAtmub9Jlg8DG8eOslggkapLwUZFn0OcARzYv6OTiGM9Xfaor9TExWWlNknES7hsB/AarydSB3BvQi2/Mg4gVsdBDdXQGAbz+r5brS87ZhjfFaj+7AE4bTd6DoBTdUCuTBxIqIg57sxrzOv2xiVWfs5w6jZVYQ0cE2eQixSoJVgKaQXwdbEPVQeYfj5LXq5B4RTxmvSB6ux1Ym0pbTFSHoWDBcD38EI9faIjVHZL3+tC7DzEohSQnToUhCMME9NxiB8vSfUKHCwEfP8Y9x5OVvB71LzrGcevg+W/BLusO51GZLvAahr9VpmazP0bsE/LonYmrlanRG+jTQqakDqKTJgRMjJQFopJzqW780CDuLVs7/wCKOdKur2tFxbeVDW/dzmCDbHf9eUMLZ0uF/LDspBFEtK3Cx1mDc140TONuiFy9NZAAaoc5htJuV4L9O3ZuMo2E5Tfk/oHayVm98woF9/2biZnLZZP/ezsTL6DyV7EiLxuWkk0W8guAkQwq+56F fFrUQ0+K 8xPYHY5dPyXvTpY7Q7TnkTgY+tG8s0NP+LVgmQRp2MpFtUz+JETd3e3HI2sqtHePQTo5MczsISSoI1KH1uaRWgL+nP1buw2fqROpGUQQ3cUgIIfLqXruYJf+0Kf7UmsKNSkij2BILlGaViEXkKZ2Ybzu/c10fF9cWfHHjU9FHVFCcuyXYacD+uj+Bpw+7P55XYQLPjw26opxJi6FBhpgD7Yr2hrskgCNTnBXt+l06/NiLJzx40l2/RLOMuzuFXaNSUxm957CNBemmpYGDezjghwSo9tTe9z9wIUHxuyuTxG+6KG3Z96yeFHYN2i2G4iE8TlE1Dcuj8HssEminxn/UiO3eFFtRpD4FAwR4XJkp5vVCVt8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: David Hildenbrand writes: > On 07.08.24 14:41, Michael Ellerman wrote: >> Add an optional close() callback to struct vm_special_mapping. It will >> be used, by powerpc at least, to handle unmapping of the VDSO. >> >> Suggested-by: Linus Torvalds >> Signed-off-by: Michael Ellerman >> --- >> include/linux/mm_types.h | 2 ++ >> mm/mmap.c | 3 +++ >> 2 files changed, 5 insertions(+) >> >> diff --git a/mm/mmap.c b/mm/mmap.c >> index d0dfc85b209b..24bd6aa9155c 100644 >> --- a/mm/mmap.c >> +++ b/mm/mmap.c >> @@ -3624,6 +3624,9 @@ static vm_fault_t special_mapping_fault(struct vm_fault *vmf); >> */ >> static void special_mapping_close(struct vm_area_struct *vma) >> { >> + const struct vm_special_mapping *sm = vma->vm_private_data; > > I'm old-fashioned, I enjoy an empty line here ;) Ack. >> + if (sm->close) >> + sm->close(sm, vma); > > Reviewed-by: David Hildenbrand Thanks. cheers