From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D785D597C4 for ; Wed, 13 Nov 2024 01:55:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA20F8D0001; Tue, 12 Nov 2024 20:55:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B29B26B00B8; Tue, 12 Nov 2024 20:55:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A44D8D0001; Tue, 12 Nov 2024 20:55:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6FCEE6B00A1 for ; Tue, 12 Nov 2024 20:55:56 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D6652A03E1 for ; Wed, 13 Nov 2024 01:55:55 +0000 (UTC) X-FDA: 82779404904.05.33D49E1 Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com [209.85.167.180]) by imf29.hostedemail.com (Postfix) with ESMTP id E3CBA12001F for ; Wed, 13 Nov 2024 01:54:56 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=S1xrDKrF; spf=pass (imf29.hostedemail.com: domain of ritesh.list@gmail.com designates 209.85.167.180 as permitted sender) smtp.mailfrom=ritesh.list@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731462760; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references:dkim-signature; bh=11EhO1dZz6gEnF3YkMG0XqMweNwg8PY4ZG+oYYjEKOc=; b=06Ua0+B8W1HxlsAGwTK8e7YQQdrb1+rb1dxcZwkPXy81hq8LGHXfSoFlf+Ijo1CCVXbpAc oq0VRxxk5n72qQLNTeMOMaiPwUhJSmGLpsAaKsc7mGnHV1+EeXw7FTDCVhH1bc/CNbyPrl aQLBqq87BW1iaelYO0TQ3aYIaxgkSDs= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=S1xrDKrF; spf=pass (imf29.hostedemail.com: domain of ritesh.list@gmail.com designates 209.85.167.180 as permitted sender) smtp.mailfrom=ritesh.list@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731462760; a=rsa-sha256; cv=none; b=OdE5WGFuJt+2NESh6LPzGJBH2TlIk9lHVtMs1GsnWwt1kw/czzm+srV4/xE0E3ydgZzMAo r0sxAyeGxfNJ+y/P4cpHma7gRsJ8gOZz0u8YwSkGsRzxVlcQxss77eWUSxe80GYPebaO7e qNCqbEmvBmzd3JbOb1GBXEMXkZuVEAg= Received: by mail-oi1-f180.google.com with SMTP id 5614622812f47-3e5f968230bso2822472b6e.3 for ; Tue, 12 Nov 2024 17:55:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731462953; x=1732067753; darn=kvack.org; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=11EhO1dZz6gEnF3YkMG0XqMweNwg8PY4ZG+oYYjEKOc=; b=S1xrDKrFLZoBCwkeaHua+cprbPErAToaVoAsoZH/JHppN2aBcvplWT4HUrjAUecAyS eJ068cnUPQO3DCNwg4N+KfqugNDI7bZWrgiv2xT56w7CUPiItLBqJyYPnsRFKoiu6HXU Bvzk9JnRSLm4h2ucb5WvcEQaaUdIj7vaFdKvnXZdHJGtK/bHq+pBTbs61isJqECur0wj hiQoyQc8KX6KNDnKfryI5aciFvAvmq980cOGi45upPnyqyQHsr/+lbWHcbZ0SkWRP1oC ksI+AnSSiX7mK9TOHmCao9MKGcgS64IREX6m0gozSV5CDeo4YKkcczaBALqEuHkSA6ie xpow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731462953; x=1732067753; h=references:message-id:date:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=11EhO1dZz6gEnF3YkMG0XqMweNwg8PY4ZG+oYYjEKOc=; b=cJZurJozAdaepe9ql7gYd3wwDZ0JluC9hMzZ9yNZqKJrJmmd6mPhYdC1LbmtEZAHXT QTY8Vd7nr8aaYl7zXl26csKeicb/O8AFrf3WQ1pdo57yxkZjCIad5AxDHcFRma2XkHrN sDjzXkBnHyLG4npA8IZDmJ5yoEjiSOZDK8ZcWgsxvva/seXuIlVA3Z2ltqWqYOH9s/0N hwanD3h68CRPr0sDWQnoGMh6IRfw0BvGrrQQx6gXSlG3wI3062fYmjcy0/nRkD/UitRk +ZdhX3t/m+jnDnauchR1QNOzGA+VMFtZn1nw6j+5SnTLoGjBV4pXhIIPBVBDPFpDkdpE M6Wg== X-Gm-Message-State: AOJu0YxWliOdYsqtTiDuNDljHUn8ps2XRfovld2eUk0fqcr2WytmS0Ie 75g0LmIEj1C0TKn0yxzgi975UTj//ZJSGjO4Vk3J+1TA9cMwtcUj X-Google-Smtp-Source: AGHT+IEw04kTyzxcDHeFkrUT0IqyioyF+6yN2dm4ArNEx6RbxWzlwtPmy+r8/kX0HzwsE7aRsIYj0w== X-Received: by 2002:a05:6808:e8a:b0:3e4:863a:91b3 with SMTP id 5614622812f47-3e79469311dmr18550625b6e.8.1731462952993; Tue, 12 Nov 2024 17:55:52 -0800 (PST) Received: from dw-tp ([171.76.87.84]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7f41f644db5sm11310584a12.55.2024.11.12.17.55.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2024 17:55:52 -0800 (PST) From: Ritesh Harjani (IBM) To: linux-mm@kvack.org Cc: linuxppc-dev@lists.ozlabs.org, Sourabh Jain , Hari Bathini , Zi Yan , David Hildenbrand , "Kirill A . Shutemov" , Mahesh J Salgaonkar , Michael Ellerman , Madhavan Srinivasan , "Aneesh Kumar K . V" , Donet Tom , LKML , Sachin P Bappalige , Andrew Morton Subject: Re: [RFC v3 -next] cma: Enforce non-zero pageblock_order during cma_init_reserved_mem() In-Reply-To: <054b416302486c2d3fdd5924b624477929100bf6.1728656994.git.ritesh.list@gmail.com> Date: Wed, 13 Nov 2024 07:23:43 +0530 Message-ID: <87h68bnbko.fsf@gmail.com> References: <054b416302486c2d3fdd5924b624477929100bf6.1728656994.git.ritesh.list@gmail.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E3CBA12001F X-Stat-Signature: bpedhmxcg4bkjy5sqmm7ehwutgqgimy1 X-Rspam-User: X-HE-Tag: 1731462896-400724 X-HE-Meta: U2FsdGVkX1/koQ6UFirMGcJIiAFirtt71p0nM8wCSXq/qCGwZTE6a8XJ8Zq0tRAez1/1UwBKW1E/D5m5xkPYK9k4cuPhuOHlz62R4HYNQZRfQD+ZkK7qnUWfasheSfETkNvUSpDO1YCwPrNRGUXROUAl3Wht111qwtLqzyZiw+IT/a9P8QgRSE/9CSUDP0FB2yDJsHu1hLcjw+sfGAIL2xmtC1clebcC1ieEk1KIi7vEqDJonqxmCJanwfQmmQ1neqevJM6gGuKQc7/1+w5YR/r9l4fdO1BTULOltZTYrJ6977qL1a0Kt/dpSBptWtXc2G0WUrxdZkrkpE7BvcEy62pRdvWnDCXSGud0vo6D2DBIez+oGp+Fvyxj3FxfWa32/mDVGNB7KZDR6SWX88u5zK9mf9QxOyagMFX2e9PfYQ+LSvs9KSssJbq+4fEqugwQ8wkL+KIQ7Re9TizNviEwSNMfYHKDmC/UsD5NvKXQCvNrr1A3WTlPZORu71yMLOSxrmzV5M+8T7frT7RR/CN7IML8zDyeQdjsOHc5sXcHL/IkmsiJCDO1FjJDksk0IfAJSy4pjUs+yw2/KLZUnDlVwy/EJTLR6geTwjiIHgS6Jeetv+Iq76O6x3fqpQ2gtnqIuvOZ+dUYLj8XhZT07Uhld4+0ke6QM4bDDEsCECeh0ZbvY6qhbszvnaMbfA83+SR3apuxI65ei5nJw4nKkqgVg5t/yfOIkgrQXx3MH7pqpHQtGnJCeMIGSp5vfLBTzQzQyst9Ou65QAPkKS8Ms2wcsjm0UUQFamlE7QwYDL5nDKVSRDkrFwbsE863r3Hlg0khbMdTVEKFJX7LsJmDGqQjmrSk/w9pJnW9Zf6IWqJbqIJ96KrfLCdBRaGu9mzXax4xQvjpJQYNlV04BRsvyPbxQgilZlm23wuITiWI7iyQtEowHJiRW4zVK5rGmsaUhysVQgeGrgpZhsZA3ftyB+X F9bBzBqa VaSBCd+9u63N16pkU5ZbzOeYonzXlSYu+aDb9ICIfaINwEr1lNjfhR1J/tS2gXPqT8kxm5tQJ+TIlfxioUgjGfy26qQgGeI/50Rq2WNiDsTtfrMvpBfET+4Oh8XxDGYL9vK/SSeJB3GvqdzJ0xMEnwvXkoE/ZkqxoKQp9afSJW5TjC1kwhbMrHpDBnuC3sKWTXvlxyaOWK4W+Md5qegFC9/KkbGBAb6G03Aa2qZPnCH6wA7w89FSvSqUNz/2QQlFjtiD5ngKwNf/MV+hQnhMuk/kTQEhLBkaouuURiwo+iPf7PdX+JWsTiJxV6iRoqsrT3rs4qfJmUfzG+ddOoGdhsw+R/nJKR4jINRTyCKHic6dPjvzvNcpEKhNu+JsHRW1xBXTES2jx9WP8pJBgme/Dye2RXyLBtOperikrZcp2PueO8wTo46nejuZVro9256JaOGUVteHYd4Z23dRKgSaElhzWVendjz21vgQF2+xgCBxGNyPFHsyS4xMpbA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: "Ritesh Harjani (IBM)" writes: > cma_init_reserved_mem() checks base and size alignment with > CMA_MIN_ALIGNMENT_BYTES. However, some users might call this during > early boot when pageblock_order is 0. That means if base and size does > not have pageblock_order alignment, it can cause functional failures > during cma activate area. > > So let's enforce pageblock_order to be non-zero during > cma_init_reserved_mem(). > > Acked-by: David Hildenbrand > Signed-off-by: Ritesh Harjani (IBM) > --- > v2 -> v3: Separated the series into 2 as discussed in v2. > [v2]: https://lore.kernel.org/linuxppc-dev/cover.1728585512.git.ritesh.list@gmail.com/ > > mm/cma.c | 9 +++++++++ > 1 file changed, 9 insertions(+) Gentle ping. Is this going into -next? -ritesh > > diff --git a/mm/cma.c b/mm/cma.c > index 3e9724716bad..36d753e7a0bf 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -182,6 +182,15 @@ int __init cma_init_reserved_mem(phys_addr_t base, phys_addr_t size, > if (!size || !memblock_is_region_reserved(base, size)) > return -EINVAL; > > + /* > + * CMA uses CMA_MIN_ALIGNMENT_BYTES as alignment requirement which > + * needs pageblock_order to be initialized. Let's enforce it. > + */ > + if (!pageblock_order) { > + pr_err("pageblock_order not yet initialized. Called during early boot?\n"); > + return -EINVAL; > + } > + > /* ensure minimal alignment required by mm core */ > if (!IS_ALIGNED(base | size, CMA_MIN_ALIGNMENT_BYTES)) > return -EINVAL; > -- > 2.46.0