From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D562FC021AA for ; Wed, 19 Feb 2025 08:38:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 60311280193; Wed, 19 Feb 2025 03:38:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B701280122; Wed, 19 Feb 2025 03:38:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47C16280193; Wed, 19 Feb 2025 03:38:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2BD20280122 for ; Wed, 19 Feb 2025 03:38:19 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DB38F14134D for ; Wed, 19 Feb 2025 08:38:18 +0000 (UTC) X-FDA: 83136042276.09.96EE06F Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf30.hostedemail.com (Postfix) with ESMTP id 5C18380008 for ; Wed, 19 Feb 2025 08:38:17 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CdiEO0bX; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of a.hindborg@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=a.hindborg@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739954297; a=rsa-sha256; cv=none; b=YRjIeImHRvEvC/sIO4wirLgelVYf2a1LD3aZSUm5vnmJ3CqeGkc7DDgMcmtEMMUWBzdjDP YbWV2KzoV+K96wK9gKkxnrFKN+ubjxO9ofE2Q8AruhyPotcd/3vqP+wwkTaDrzc8VzYMDq r5VGExYW8uRJeA1k31ZnBHxps4RHPhQ= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CdiEO0bX; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of a.hindborg@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=a.hindborg@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739954297; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hk/K7Xy7+TFm7X+Cn6nnIxxhnI2tKh7frk+g37U2Q3I=; b=3BYiOoAJSdzUH5pEXUHsYvjVVdZRaTW702a6qmNSWrml5TaEk8yN9/kZdYlJs+ei38snrZ c9fp/o8wNPSe6r+lkAcH3E6FZWAXFbZTlXwl1dZ9y04wwSdUrr5OVZzL9wCj74YbMmb3Ir /566dYnT01qDOLU7lVWv7WNfuZCKlRc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id EB112A41F69; Wed, 19 Feb 2025 08:36:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9381CC4CEE6; Wed, 19 Feb 2025 08:38:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739954296; bh=hk/K7Xy7+TFm7X+Cn6nnIxxhnI2tKh7frk+g37U2Q3I=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=CdiEO0bXmEsZKXKRm0QcP4p39t9yOvQaGKeztiXyCnaLcA+iLGYNj3M7FDnz60HT0 IlZRSHn5bf8rt8snl1f97UsInPv0X+dtmdiwfqW/Son+bpG512eW8srjisHQ+NjyeA Lht9aAWWsN1fkZlJAXCyBovI6hMUp6xNPciTCEdnTUbXl631eqHtSVunWCVtcEPCFF c4/pGLrZTSqfoIZs62RSylT05bhAGNYWhluDhB3HmOeJqaHpuz5MRXYBs/Lh2554Yu W8M5soPpqrgv4BpgF2eAI22kg6QjPB2eHie8rS5eNWykXdgBjMe7qGYuVMs+jf5xK3 jHy8G32JIuT2Q== From: Andreas Hindborg To: "Asahi Lina" Cc: "Miguel Ojeda" , "Alex Gaynor" , "Boqun Feng" , "Gary Guo" , =?utf-8?Q?Bj=C3=B6rn?= Roy Baron , "Benno Lossin" , "Alice Ryhl" , "Trevor Gross" , "Jann Horn" , "Matthew Wilcox" , "Paolo Bonzini" , "Danilo Krummrich" , "Wedson Almeida Filho" , "Valentin Obst" , "Andrew Morton" , , , "Abdiel Janulgue" , , , Subject: Re: [PATCH 1/6] rust: types: Add Ownable/Owned types In-Reply-To: <20250202-rust-page-v1-1-e3170d7fe55e@asahilina.net> (Asahi Lina's message of "Sun, 02 Feb 2025 22:05:43 +0900") References: <20250202-rust-page-v1-0-e3170d7fe55e@asahilina.net> <20250202-rust-page-v1-1-e3170d7fe55e@asahilina.net> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Wed, 19 Feb 2025 09:37:50 +0100 Message-ID: <87h64qe3dt.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 5C18380008 X-Stat-Signature: srrq3q61hbrhyhhuirw4xmtgzfirdt1m X-Rspam-User: X-HE-Tag: 1739954297-522825 X-HE-Meta: U2FsdGVkX1+UfUdQlpQa3gsawOQbSTpVZpwDq/jk03AH2hIKVmks2GFzIY3BoexiP1OnTUKWfRqjBBJGiPSj0Hnx+ljoesvjkY0QjnYxrc/Uoor6HQqYLp7vIkumhHCvLfwH6vdojwMgyw0kQaLLbYr/v33nuat2tHaTkerPFlKdwUMkhkCGSvLkzvrXtp1q3b9xvBx6zCOIVXX3jStZwNbrgvLu6Ly1xplErY5RLI3uBQM4Xz7AitHyGcCCvqa45joA302N5C2aB/w83Pnv41Db3eMkSgkVPR8oQSEad29hLTuCRhRDSsSWGel0aaKI8oKrTdQew2N6sSwBj2UmkoyZLnF4nqdZP42aGiuDmRwx/dH41CBm6E+nnsdYzxlH/YBYlbQILuEfH4FRvKh5AthDQO78WbtmkB4TEjviKHemqQnz3GekwPp5sTHScT87KbyBImdkQxGz6Faw1yQ8soJc88PT4Io0mgJLEUf3bnTuSVR8h9U/iqI0MU0lGf+3/6wgjuu3VP0O69cEC3K/IrAIIBPsu268zqUFKds0NkSkPTtKzErbupXFAZLYJza6BNlfwz5hypvLbUMEJ/1EhP3ZTz6UonLTAO4ZAM+yUpDzzms0fLcpxC4S2siJnnjioskKEg+SGdQZ4+Qhe+23uEi/ro65gPEQyxZiDmatqW6YoApBwqA3bgJEXdC3lMr8a/JfMOFFlVu/u3kp1A+/nD6CrLWaXqpJr5O9WjijHKJ1BIcp2QNe7okEYmuw5YrU0AgKXEraEpyHFG3hDl3vqQzlk3h+LYV67Epd7vC7uHjtXRR7zKzZk9E29DxCv36tye8bUDjx9J+BCn0r2QRs7D2hME0xtO4bsaFFzGeaCKFTwnRaWjtL9LE5SCyCjgGHHuVev0xh/y/Ymu0O1VF0L476q/q7Nxu7llF8xLXPvadZLUROQV50uAYCN3RVWHl+U/w6Lx+Fgk7PnfBz0nM IXeyYISn aqD4ws//vzW0JH3tpbi5EJl1wrLhOHEU6CDnXPosDm5CXvQW48Jsgk+TAPu1Khx0oxcUDcA8BbWyDTZssFJAFRdHEbsM6S3F8FFajLJBXJhdmClPj0sPESRQiWEthyRsOcoJKiox+RYdIU0bSST+yOQG1JrbL3gCPp98YbVMRV7LhJEW3rN3ZGPnU7LglOWJ5g5GrYYdul8hsTSesNEFWVaGivmBl4SIFMypYZmjSDCQprcYnoF97Pjad3gxlRi3zFpzPdrJbaw9zKWbqwwbAvAIhN4rCDs3V7wz4tnm5w1OCnp0= X-Bogosity: Unsure, tests=bogofilter, spamicity=0.500000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: "Asahi Lina" writes: > By analogy to AlwaysRefCounted and ARef, an Ownable type is a (typically > C FFI) type that *may* be owned by Rust, but need not be. Unlike > AlwaysRefCounted, this mechanism expects the reference to be unique > within Rust, and does not allow cloning. > > Conceptually, this is similar to a KBox, except that it delegates > resource management to the T instead of using a generic allocator. > > Signed-off-by: Asahi Lina Over all looks good to me - I agree with the points already discussed. Could you put it in a separate module and file? `kernel::types::ownable` and then `pub use` in `types.rs`. `types.rs` is getting quite busy. Best regards, Andreas Hindborg