From: Johannes Weiner <hannes@saeurebad.de>
To: Linux MM Mailing List <linux-mm@kvack.org>
Cc: Rik van Riel <riel@redhat.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Nick Piggin <npiggin@suse.de>
Subject: Re: [patch] mm: more likely reclaim MADV_SEQUENTIAL mappings II
Date: Sat, 25 Oct 2008 01:48:21 +0200 [thread overview]
Message-ID: <87fxmlimgq.fsf@saeurebad.de> (raw)
In-Reply-To: <87myguhsv4.fsf@saeurebad.de> (Johannes Weiner's message of "Fri, 24 Oct 2008 18:15:27 +0200")
Johannes Weiner <hannes@saeurebad.de> writes:
> Rik van Riel <riel@redhat.com> writes:
>
>> KOSAKI Motohiro wrote:
>>>> mmotm:
>>>> normal user: 1.775000s [0.053307] system: 9.620000s [0.135339] total: 98.875000s [0.613956]
>>>> madvise user: 2.552500s [0.041307] system: 9.442500s [0.075980] total: 73.937500s [0.734170]
>>>> mmotm+patch:
>>>> normal user: 1.850000s [0.013540] system: 9.760000s [0.047081] total: 99.250000s [0.569386]
>>>> madvise user: 2.547500s [0.014930] system: 8.865000s [0.055000] total: 71.897500s [0.144763]
>>>>
>>>> Well, time-wise not sooo much of an improvement. But given the
>>>> massively decreased LRU-rotation [ http://hannes.saeurebad.de/madvseq/ ]
>>>
>>> My first impression, this result mean the patch is not so useful.
>>> But anyway, I mesured it again because I think Nick's opinion is very
>>> reasonable and I don't know your mesurement condition so detail.
>>
>> It may not make much of a difference if the MADV_SEQUENTIAL
>> program is the only thing running on the system.
>
> As said, I had a big dd running in the background. The box has only
> 768mb RAM, so there really was VM activity going on.
>
> And given this small standard deviations, the numbers seem pretty
> stable. Even if I had taken more samples, I highly doubt that they
> would have looked much different.
>
> Perhaps still not enough VM pressure...
Okay, Rik was kind enough to explain me what was wrong about my approach
on IRC.
Yes, the benchmark pretty much missed the point. Please ignore.
Hannes
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-10-24 23:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 10:32 [rfc] mm: more likely reclaim MADV_SEQUENTIAL mappings Johannes Weiner
2008-10-21 10:43 ` Nick Piggin
2008-10-21 11:33 ` [patch] mm: more likely reclaim MADV_SEQUENTIAL mappings II Johannes Weiner
2008-10-21 22:13 ` Andrew Morton
2008-10-22 0:09 ` Johannes Weiner
2008-10-22 0:51 ` Johannes Weiner
2008-10-22 6:39 ` KOSAKI Motohiro
2008-10-22 7:15 ` Johannes Weiner
2008-10-22 7:41 ` Andrew Morton
2008-10-24 0:21 ` Johannes Weiner
2008-10-24 12:55 ` KOSAKI Motohiro
2008-10-24 14:02 ` Johannes Weiner
2008-10-24 14:31 ` Rik van Riel
2008-10-24 16:15 ` Johannes Weiner
2008-10-24 23:48 ` Johannes Weiner [this message]
2008-10-24 18:59 ` KOSAKI Motohiro
2008-10-21 14:40 ` [rfc] mm: more likely reclaim MADV_SEQUENTIAL mappings Rik van Riel
2008-10-21 15:20 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fxmlimgq.fsf@saeurebad.de \
--to=hannes@saeurebad.de \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox