From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f72.google.com (mail-pg0-f72.google.com [74.125.83.72]) by kanga.kvack.org (Postfix) with ESMTP id 16A756B0008 for ; Tue, 13 Feb 2018 05:09:14 -0500 (EST) Received: by mail-pg0-f72.google.com with SMTP id x11so9000154pgr.9 for ; Tue, 13 Feb 2018 02:09:14 -0800 (PST) Received: from ozlabs.org (ozlabs.org. [103.22.144.67]) by mx.google.com with ESMTPS id bc11-v6si7085343plb.688.2018.02.13.02.09.12 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 13 Feb 2018 02:09:12 -0800 (PST) From: Michael Ellerman Subject: Re: [PATCH] headers: untangle kmemleak.h from mm.h In-Reply-To: References: <87zi4ev1d2.fsf@concordia.ellerman.id.au> Date: Tue, 13 Feb 2018 21:09:05 +1100 Message-ID: <87fu652oce.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: owner-linux-mm@kvack.org List-ID: To: Randy Dunlap , LKML , Linux MM , Andrew Morton , Fengguang Wu Cc: linux-s390 , John Johansen , "netdev@vger.kernel.org" , X86 ML , linux-wireless , virtualization@lists.linux-foundation.org, iommu@lists.linux-foundation.org, Greg Kroah-Hartman , sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Dmitry Kasatkin Randy Dunlap writes: > On 02/12/2018 04:28 AM, Michael Ellerman wrote: >> Randy Dunlap writes: >> >>> From: Randy Dunlap >>> >>> Currently #includes for no obvious >>> reason. It looks like it's only a convenience, so remove kmemleak.h >>> from slab.h and add to any users of kmemleak_* >>> that don't already #include it. >>> Also remove from source files that do not use it. >>> >>> This is tested on i386 allmodconfig and x86_64 allmodconfig. It >>> would be good to run it through the 0day bot for other $ARCHes. >>> I have neither the horsepower nor the storage space for the other >>> $ARCHes. >>> >>> [slab.h is the second most used header file after module.h; kernel.h >>> is right there with slab.h. There could be some minor error in the >>> counting due to some #includes having comments after them and I >>> didn't combine all of those.] >>> >>> This is Lingchi patch #1 (death by a thousand cuts, applied to kernel >>> header files). >>> >>> Signed-off-by: Randy Dunlap >> >> I threw it at a random selection of configs and so far the only failures >> I'm seeing are: >> >> lib/test_firmware.c:134:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration] >> lib/test_firmware.c:620:25: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration] >> lib/test_firmware.c:620:2: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration] >> security/integrity/digsig.c:146:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration] > > Both of those source files need to #include . Yep, I added those and rebuilt. I don't see any more failures that look related to your patch. http://kisskb.ellerman.id.au/kisskb/head/13399/ I haven't gone through the defconfigs I have enabled for a while, so it's possible I have some missing but it's still a reasonable cross section. cheers -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org