From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51155C43603 for ; Tue, 17 Dec 2019 06:47:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1ADEF2067C for ; Tue, 17 Dec 2019 06:47:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1ADEF2067C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=renesas.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B00828E003E; Tue, 17 Dec 2019 01:47:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AB1F98E002F; Tue, 17 Dec 2019 01:47:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9EDC88E003E; Tue, 17 Dec 2019 01:47:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0154.hostedemail.com [216.40.44.154]) by kanga.kvack.org (Postfix) with ESMTP id 8CD2B8E002F for ; Tue, 17 Dec 2019 01:47:44 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 472172C32 for ; Tue, 17 Dec 2019 06:47:44 +0000 (UTC) X-FDA: 76273702848.27.land14_2648fe5618b59 X-HE-Tag: land14_2648fe5618b59 X-Filterd-Recvd-Size: 2700 Received: from relmlie5.idc.renesas.com (relmlor1.renesas.com [210.160.252.171]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Tue, 17 Dec 2019 06:47:42 +0000 (UTC) Date: 17 Dec 2019 15:47:40 +0900 X-IronPort-AV: E=Sophos;i="5.69,324,1571670000"; d="scan'208";a="34626889" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie5.idc.renesas.com with ESMTP; 17 Dec 2019 15:47:40 +0900 Received: from morimoto-PC.renesas.com (unknown [10.166.18.140]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 401C540078A5; Tue, 17 Dec 2019 15:47:40 +0900 (JST) Message-ID: <87fthjh2ib.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto Subject: [PATCH] mm: memcontrol.c: move mem_cgroup_id_get_many under CONFIG_MMU User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 To: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Kuninori Morimoto mem_cgroup_id_get_many() is used under CONFIG_MMU. This patch moves it to under CONFIG_MMU. We will get below warning without this patch if .config doesn't have CONFIG_MMU. LINUX/mm/memcontrol.c:4814:13: warning: 'mem_cgroup_id_get_many'\ defined but not used [-Wunused-function] static void mem_cgroup_id_get_many(struct mem_cgroup *memcg, unsigned int n) ^~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Kuninori Morimoto --- mm/memcontrol.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index c5b5f74..8a157ef 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -4811,11 +4811,6 @@ static void mem_cgroup_id_remove(struct mem_cgroup *memcg) } } -static void mem_cgroup_id_get_many(struct mem_cgroup *memcg, unsigned int n) -{ - refcount_add(n, &memcg->id.ref); -} - static void mem_cgroup_id_put_many(struct mem_cgroup *memcg, unsigned int n) { if (refcount_sub_and_test(n, &memcg->id.ref)) { @@ -5153,6 +5148,11 @@ static void mem_cgroup_css_reset(struct cgroup_subsys_state *css) } #ifdef CONFIG_MMU +static void mem_cgroup_id_get_many(struct mem_cgroup *memcg, unsigned int n) +{ + refcount_add(n, &memcg->id.ref); +} + /* Handlers for move charge at task migration. */ static int mem_cgroup_do_precharge(unsigned long count) { -- 2.7.4