From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE84DC77B7F for ; Sat, 13 May 2023 19:42:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0FA856B0074; Sat, 13 May 2023 15:42:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0AB246B0078; Sat, 13 May 2023 15:42:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB4956B007B; Sat, 13 May 2023 15:42:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DB77B6B0074 for ; Sat, 13 May 2023 15:42:55 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id AC732A107C for ; Sat, 13 May 2023 19:42:55 +0000 (UTC) X-FDA: 80786254710.12.5D2995A Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf07.hostedemail.com (Postfix) with ESMTP id 00DB440007 for ; Sat, 13 May 2023 19:42:53 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=4j5yDWsZ; dkim=pass header.d=linutronix.de header.s=2020e header.b=FuUB6NJJ; spf=pass (imf07.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684006974; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xhIUhkm/3QxY0cQ35omU8A+ztIuN9wN4GJw2r9D9N8c=; b=8IruGsunD0hpjbj1HTugsKQXxfSLPavcB32Bd0wWLr+z9YUN5qQobhzq0r245WAv7O+g5Z PglmNbjYdxow8qmEFf60NNqzACtQFO6rwSeHFIl3GJNmoA3Zz9R1peuyDtvqcdNGhCBvUw ne+loUfH/hbNKW/g1a482yN5PghwlG0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=4j5yDWsZ; dkim=pass header.d=linutronix.de header.s=2020e header.b=FuUB6NJJ; spf=pass (imf07.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684006974; a=rsa-sha256; cv=none; b=jPQbgvTe2dyF8vPPuqW79NYmgZmOoUYM1TscOxYp7k9xPp9JRWpjz/rSICmVD+wY+xOhd1 ZfsoRi9oLgcmDznLKEZ6nNFgGttLnV7kB9dSH3K0FOpmFG9ptMcJ50I4DhKYQtc7E8X8Kw kY7Vrwgogs/MqvgKU2acjxkuuGs03+k= From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1684006971; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xhIUhkm/3QxY0cQ35omU8A+ztIuN9wN4GJw2r9D9N8c=; b=4j5yDWsZaysSy25nQ55wrWrPJWnm9WFsLnteMJ92iU+X5vqMz9/sgIOgPPvscoCmFxAPlT xGfKRi0hHldOz9J/TvQaTfle2Bv5h8nra2WAiAi3BtCuT9nHAt1DRCXaV6ZNoSiwKNplq2 b/SJXx4cpr4wgmI8ESC0x/5uCwASHEvIdILO6MKFEeLy1YZY1KD3gs5z0cxENJDCzLNZzu FxRCtgCg9stdEZdWfd2F8PUJMl+V0LPdJeW03wq8+oPqzHdmeHIccIhUMjU2sPY0LkJqJH cOnKrhRXBCXB8IMhJNoIkm654+v3PSaqPeCOW5g/a5aMBNgKWi9OELsi6P+t/w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1684006971; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xhIUhkm/3QxY0cQ35omU8A+ztIuN9wN4GJw2r9D9N8c=; b=FuUB6NJJ8piz48iH2rmyp4RMcQPrmrPihGRisRlSDu9P0zpwEuq2dlrdvoje3pqAVOz17d 9Exm3eB02HcJtSAA== To: Tetsuo Handa , Andrew Morton Cc: syzbot , syzkaller-bugs@googlegroups.com, Ingo Molnar , linux-kernel@vger.kernel.org, linux-mm , Peter Zijlstra Subject: Re: [PATCH] debugobject: don't wake up kswapd from fill_pool() In-Reply-To: References: <000000000000008ddb05fb5e2576@google.com> <6577e1fa-b6ee-f2be-2414-a2b51b1c5e30@I-love.SAKURA.ne.jp> <20230511204458.819f9009d2ef8b46cc163191@linux-foundation.org> <87v8gxbthf.ffs@tglx> <39c79d27-73ea-06a8-62fe-2b64d0fd8db5@I-love.SAKURA.ne.jp> <87bkipbeyr.ffs@tglx> <61d7ac52-3352-b7cd-8908-890a29a007d9@I-love.SAKURA.ne.jp> <87lehsaavo.ffs@tglx> Date: Sat, 13 May 2023 21:42:51 +0200 Message-ID: <87fs809fwk.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 00DB440007 X-Stat-Signature: hcyxnpmkzifhuix813fcu8oh6xadaeor X-HE-Tag: 1684006973-231087 X-HE-Meta: U2FsdGVkX1/oLIx61iwGI1W8PDfvohEWzhwtfFGzXrA8EdiZ8+lkHqijWHMkuHp0z8Ml/Rlespih4QP04nIONI/2tQYJrf6IX2nL1p0IfU77kIHdygv9QzhL3i18GYotXE1n90OosxOceUto+o7Ke53d+pp6CyEBlQD5cSukvry6+mNSUYt9epNi55dtgLhneUWh6um0am8b3t/8DQC5B6VC6yA606IwCqiDrLPlKUIDWyuxQ9xVAIUAujs2+284kAwIdnE2w54iyQSVNjTBogYIxjgprXmgv3TxC51IrtPyYawuCbLyzGD9LeblH9xHXyRr5aa8+d4J50VpjGzevU+Y+S3mRAvAEuYIXLd0E2yKLFeZdvKLU+mruTDK81sAS/phvM5HonuS2Jmrwei+WvjZbAA3fNor6jjTn1rroYQnKkfTVyA2+CL/ZZKJTKoMNi3WdxciK7R5fT1q35xM7kwxK9220DEFUnH2sAk37dFYR/+f+2u+/VWgPdJplTBEcDRPiXp7UTkiKVr8LOBXgvYR4Z8c6oRbiK6UpjZE0m+oGGETTE7k4c5mx3g8yW9rfkxUisdSyiilDdXpgI7e1y9VmnoDTJPdWxpvZmDMXo+FriPtjEzd3+1HJIxXCM6Fwolp+eypLHqsIBV4BCyKNSFvm0VpLp2k/7bkgmu5wktSoC/bbtqNhSE5IT3x/Q/J+bheyqKdCnd5FhsFvuHV/aoH3Q8ds5THNhD+P9L/tiBUy9ZhEcQcUmg2YPiXq8PcW2huF2s4twD7TMiA66Q8Q6JwiKt+J+DGRmYCPC1aBtiIxwp/7X6LLG6gV/ZTPRMpaVzYkZe0M38WepYUaup/FYHsHDPOWYUrI5nK8AgHLOgyyyn1+rx/fGbVR52b3pa3n0LMNNEICFiIEv8B9FxLvVZHcnzsb2d4YFjG91ZwT18YXg9y2/GwoTdVshwzhp7rxle/RORl7KiVNo0In/5 G17tBB0Q KqF+lMkgb+GZh10K1XAU3R60+wVv74IgeuMjBJsmlHPHUTqVasB6XQSJTm+eRLepNu4XgWaUKnOeALduvrCoyljm9LU2vgJrI7ej0jmA/Jvfd4Gn9SjrCXBBf0SCOvy+AIrP9SvBRt5661yzN+MZwSfWoMoQOqo+Jl9f161o3jTRZPdVinHH1gdANaXyLMxe8Zslf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 13 2023 at 18:33, Tetsuo Handa wrote: > On 2023/05/13 17:33, Thomas Gleixner wrote: >> Now I just stared at __alloc_pages_slowpath() and looked at the >> condition for wakeup_all_kswapds(). ALLOC_KSWAPD is set because >> debugobject uses GFP_ATOMIC which contains __GFP_KSWAPD_RECLAIM. >> >> So debug objects needs to have s/GFP_ATOMIC/__GFP_HIGH/ to prevent that >> wakeup path. > > Yes. That is exactly what my patch does. Indeed. For some reason your patch (though you cc'ed me) did not show up in my inbox. I've grabbed it from lore so no need to resend. Actually we want both changes. - Your's to fix the underlying ancient problem. - The one I did which restores the performance behaviour Thanks, tglx