From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 048E4C77B7F for ; Tue, 16 May 2023 08:20:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8509E900003; Tue, 16 May 2023 04:20:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 80128900002; Tue, 16 May 2023 04:20:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C972900003; Tue, 16 May 2023 04:20:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5FDA1900002 for ; Tue, 16 May 2023 04:20:41 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3F9331201BF for ; Tue, 16 May 2023 08:20:41 +0000 (UTC) X-FDA: 80795421882.09.0C2B738 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf13.hostedemail.com (Postfix) with ESMTP id 86CDD20002 for ; Tue, 16 May 2023 08:20:39 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=mFOaKqBL; dkim=pass header.d=linutronix.de header.s=2020e header.b=9I6sZ984; spf=pass (imf13.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684225239; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M1sd/lpDf/MCX2vWDYwloKV/3NMa6WZqr15rTyJlP5A=; b=vu9PdPnt1/3hnScGZJymwel3uk7312lsfdT3AB7JS4pVaWhKqiehvt7OMbe9NZk13DWCUv W2V0EZt3EDEvs9PO4HCnjiCg3GKh9d7Sj3CJ+QqHgq2n/1OdStE4BhIAK3bE0TkZEAxLeT tATwUVpK78z15Zud98YX6sNLhNA8KEk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684225239; a=rsa-sha256; cv=none; b=iw5Jlf7/6/HwaMI8QuivIwjgSpNRYNbqp8UoOoBDCBxPfkvO+As3VNv0P7XFQEineYo5Uh bOeg7yDgA4ORhsxIH9P5nY2FoGByx71qj2jG3T3yREzDETcUAtEkWTz3u+HoM/38G1fJtd 4bGRMmKzcpacHPV5myK55tZ23Z1Aw8Y= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=mFOaKqBL; dkim=pass header.d=linutronix.de header.s=2020e header.b=9I6sZ984; spf=pass (imf13.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1684225237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M1sd/lpDf/MCX2vWDYwloKV/3NMa6WZqr15rTyJlP5A=; b=mFOaKqBLYl4XAgzjtWo/hPSwSsfmaxNfiHqaFr1drTXF1UQi/A3UhlMBm7TtENZSl4xX5P t/TTIAi9EwnP159o1Jdc6g5LW0Io8CxZ2ZyfhrhHtNRQ+KdnM7NwIyAWH55QgTYME0jpYf LEUl18wmWcLX3rlsHVZtoO1BVx/TPQpftpZaJMDBdhWXrZrGWI0Rlmjrdz6rUdEVF6C3s4 um1+F3rREcGQVAPOpvSeseRXkiavi+8SzXsJXdzMpdomaf7jW0rIuNCEqju9CbDtLdZsN3 FrISOOpntKDvD1OFg9CeAeE1Mqunuwb/jt+GLYet92hxSelhq7cqw/fOWZlh3Q== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1684225237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M1sd/lpDf/MCX2vWDYwloKV/3NMa6WZqr15rTyJlP5A=; b=9I6sZ984bu6NajzitsNs+FqPNKEaQ8a89V8kMrHCz/DIFKznAZqcWGDZjYlypHLUAwW8LW hYYEAqsaAUXHxaDg== To: "Russell King (Oracle)" Cc: Andrew Morton , linux-mm@kvack.org, Christoph Hellwig , Uladzislau Rezki , Lorenzo Stoakes , Peter Zijlstra , Baoquan He , John Ogness , linux-arm-kernel@lists.infradead.org, Mark Rutland , Marc Zyngier , x86@kernel.org Subject: Re: Excessive TLB flush ranges In-Reply-To: <87ilcs8zab.ffs@tglx> References: <87a5y5a6kj.ffs@tglx> <87353x9y3l.ffs@tglx> <87zg658fla.ffs@tglx> <87r0rg93z5.ffs@tglx> <87ilcs8zab.ffs@tglx> Date: Tue, 16 May 2023 10:20:37 +0200 Message-ID: <87fs7w8z6y.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Stat-Signature: ma6i3mkncwrwy8n34orict7oucyx8t3r X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 86CDD20002 X-HE-Tag: 1684225239-98635 X-HE-Meta: U2FsdGVkX19dcKqRDE4PaQWbDjX6JypGcumayPK+KEw9ZmATAd613h4+PCb+N4vbuItzxTrB0gxpXqYNoFPBrBKeG09rOdE+wcnP43hwrT/BWFiCEEQkpUQocfrMeaghzQ+DpnmpKMgeb+LkURoaVw0x5hVn3S2S/ks9e87cnP3l8cu342XQtTTsMkc4TCeVys2VAO0dExb0j0rPZ/rHzqPoqY+43D+gLTnyDTal9WSZ+OvrCnHsGjt2CPWPou6Ii+eFZdMnqd3r2yr3TXPoRV4bEGFl19oTlxtwaF3NPvGLH10MOZ4xfFWT8wFDxWdeErBQJxUTeLOkaNLIaAbLaxsxDlVva3Ct5iyhR7Qtgdt+nxJapXGGago2EKcFIgI28FLpzYNSDw6lvjJMgS3r8OhMNcCk5lRXAVtbVNF+nZJwmpliyMgEWF79EjCZlDPdNxftbR9xxFslV5X3+7ub93fH/evMkLjruQThsRrK6lHOdefz2KGnJTzN5kHO2dwaZ/mxuwJl+YPOgwkcfwAnXrMcJTOFNLXvW5rIu64MbxFNQKToKVBUOr8ziMGyb+M/WtMI8fubdzsS6L/vuzjmX6/h2IryCnWVfAMAubNgyWVV/2e8gdzHLXVMJyj1fuQNcXZhwhp1MsrVcrZNppXw1S9RJQ87DGfVPXFwHXkGxJV2DWrKeyeSbBibTpi8ot9QN3w7aCC1+LBZjW2AKQeLBv6U3VfasSFTNaaHpJvzikv1jiW9vlo8453OdquR51sVvR0JL77Fk8jjsjOyKUMJjuwX0m+wVYxwL1LgjedbxFQvYg0ONFTwnvPfDs8HuoIq33Q8wmu4HJv6XKItJuAmpOVPfc/NgKg2PfvoXIZBcp0hUSwg6FVSpVvTgRMCQ8cegOYHyMgN/YJWmS0g9aAdP6OmuzGCH0VY5Fscvku9blQkEXbyvrgx3qrrrtefMQrN7bsdgYLHmOCTxa63BNt FEU5kh4o lRMqqLkHKnXcCF1CLcML4Ugckj3kv5o8KY8Lv2/a+qY0eoDk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 16 2023 at 10:18, Thomas Gleixner wrote: > On Tue, May 16 2023 at 08:37, Thomas Gleixner wrote: >> On Mon, May 15 2023 at 22:31, Russell King wrote: >>>> + list_for_each_entry(va, list, list) { >>>> + /* flush range by one by one 'invlpg' */ >>>> + for (addr = va->va_start; addr < va->va_end; addr += PAGE_SIZE) >>>> + flush_tlb_one_kernel(addr); >>> >>> Isn't this just the same as: >>> flush_tlb_kernel_range(va->va_start, va->va_end); >> >> Indeed. > > Actually not. At least not on x86 where it'd end up with 3 IPIs for that > case again, instead of having one which walks the list on each CPU. ARM32 has the same problem when tlb_ops_need_broadcast() is true. Thanks, tglx