From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97C33C10DC3 for ; Tue, 5 Dec 2023 09:04:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 214016B008A; Tue, 5 Dec 2023 04:04:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C3D56B008C; Tue, 5 Dec 2023 04:04:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B3356B0092; Tue, 5 Dec 2023 04:04:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EFA066B008A for ; Tue, 5 Dec 2023 04:04:14 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D70AAA0B1C for ; Tue, 5 Dec 2023 09:04:14 +0000 (UTC) X-FDA: 81532178028.11.413A4CF Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by imf19.hostedemail.com (Postfix) with ESMTP id 9FEE41A001D for ; Tue, 5 Dec 2023 09:04:12 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Yy9fNRM1; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf19.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701767053; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JwjX9T99xgBPRxcGXnj+CAbZpEIta0hjzsol0WymO+s=; b=qZznyl1cVXPoXnravA/NNgzimgi8E0lGkOjcj748aQUqtGJtWKru4kdC8IfThrNUOHX1ey nuzTLK9/DqlCLinDjgOGQLZ2fEkPDGyn/ph41cpLpQGPJu9vM88uvvWyHI1EjwpK1YkAhV lNwk4fDKAPC/D+lTfOjm9n04gyszTpY= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Yy9fNRM1; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf19.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701767053; a=rsa-sha256; cv=none; b=MRasouVl+CI6KlsR8ibNre/xBayPWwI4wcDfdj7ALpJVdST4Ul6stRCDK4SiyJpDwLaNGe BbiwHH3gs6gT5v+5u5Unuhry9HQ/pm7YEa9KjBO6hN7jnTPnhrJaUzIkG1HA856Cn3xW22 SN3fSKoGUaoPqIpzx0s6+dnmlKcYFgM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701767053; x=1733303053; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=0Xoq+rJyY1UIp1LJiIIxaTDxo/bpE9rs+1q3pFVff/c=; b=Yy9fNRM1sdGnmzX2vQ3OZPTuhmPX8xPCTQdT0UMWgMUQwc1UU65dPmBV vD4xqFCdfPUOtW6EmV1ilxBIKw5NPiqi+50bpOi5i2+M7fSECPHGFxUuE i7XgYcpxt5lyk5k0cR+LblbNtASkJPBuYsnlocunB9CLCMOUhi1LleKc9 5PS2KXXFKdKiMRX/vZ00luXqEOUgjolcL6ab2SNhR2bqfx47gHKFRiUrE ubn7ystHDLzOwMS1exKgqG0HrDW8o1vk8vkhGHWd6EaThFl64Z87mCYJr NPmcu1W3VJktz1QI9nGwYgT8NjSPYKtBcRCEM9ymjI+VB6KWtoAU4REf8 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="708164" X-IronPort-AV: E=Sophos;i="6.04,251,1695711600"; d="scan'208";a="708164" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2023 01:03:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="914730523" X-IronPort-AV: E=Sophos;i="6.04,251,1695711600"; d="scan'208";a="914730523" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2023 01:03:51 -0800 From: "Huang, Ying" To: Gregory Price Cc: Michal Hocko , "tj@kernel.org" , "John Groves" , Gregory Price , "linux-kernel@vger.kernel.org" , "linux-cxl@vger.kernel.org" , "linux-mm@kvack.org" , "cgroups@vger.kernel.org" , "linux-doc@vger.kernel.org" , "akpm@linux-foundation.org" , "lizefan.x@bytedance.com" , "hannes@cmpxchg.org" , "corbet@lwn.net" , "roman.gushchin@linux.dev" , "shakeelb@google.com" , "muchun.song@linux.dev" , "jgroves@micron.com" Subject: Re: [RFC PATCH v4 0/3] memcg weighted interleave mempolicy control In-Reply-To: (Gregory Price's message of "Mon, 4 Dec 2023 08:50:12 -0500") References: <87o7fveeze.fsf@yhuang6-desk2.ccr.corp.intel.com> <87sf4i2xe1.fsf@yhuang6-desk2.ccr.corp.intel.com> Date: Tue, 05 Dec 2023 17:01:51 +0800 Message-ID: <87fs0h2fb4.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Queue-Id: 9FEE41A001D X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: iourcmehf3zneod9s7o48tkh17iazua7 X-HE-Tag: 1701767052-706204 X-HE-Meta: U2FsdGVkX18L/l755K3XHBSMbNn2QIWX3k9uDhWBKjb8aBnPEOA49K4NHIOhdJVg69DD8hriu8DHvDRdoHH3AxYl52/XnrkI05B/02qu1MH6Xz0k8gg9ETF7N6mo/s2EzRL/i7gkgIGAsJrEFhjpTPL7JXiHK0x14IoWE+g8b2k6auIILmfun/XLQ+y3ajUghhHL2q410H8oIOLwoYjCov2n5n7Ouk3hOKXZbp2HHapUoR2BT3B/EokvIyME5a1zuEPVuIthazkSenMagD3D+PojRrImPY1WTMydBqJ9MedOZ3DdtbcC54syt87r0tZs7BZKBOi5Z6UTA8wcI+WKSclvTqafoC+940hnMUaa7hrbv/31KGduhT2ocw/HmTq3gy7JO/51o9eUizBQFnSPsOnEIf/ibR9j3V3WfVw4226L6s/rokS+rGj+HqhToq1vISGDhJqRxhD93S4P0ZLR/w3uvGSpdSElupAy5LpnYdoZyqPXgizZBPx6qoYGxBM8cxYqI/Qq9h+/kfLwbAVKOuScoSh+MFV3XRmA8h/OAdlw98bqhLIbVFtPPAGEp6B43n9lPFX2Cy+gFsJb269lNeRAAA1TALTN7PbQgqgh8aJpQXz5Zig3rspal+d8/CH3VDYtNZgUkOngg+/4XdM/wZqXv65rAkNV1ISJ0FGYjmuyLkSfQYLV6U5P+R73IvjXv1+k2QxBjYxV8a3P3rQNRlCvkvBEdzZ/1fcO79+6RBHMHypT133CB9hwIc4ydOZOirvQfi8wNAFNeQeR/rgFowkZsPDfbji+VgGgl2Ee/3wNnZk3mAl6ImEfiT8O9XulGfkkVpjVRtwo0lgZVT685weHQxr8H9YXUBJsChE6qQu0lz4HcRd6D77ZQGOLuqFofBAL4ZmUz1KuuZuAcZQ6bblrPUkz2eEaACrmFTM7Mpj5DcqhCRywCdDyGYY+x/1182be7LSJSRCpdi8ekMl iaWmQYW8 QKGLFQC+MLV/TFtbPrE9mLYfZkIhK6DCIlIjcr3LLgK3mmUUEMs8NGO1Bu/JPw+BJ5VnGjtlz1uybi3FB0g+CGYLGxFUMquMCdOn6/34ZkPCO+3XLRcdOiNZ28jBDoGR0wuJ4u7YDxVFaQKPDxtw+WNhU96qSPC7z/MJABMspX+AhxKG2Qu21PQsmOMPIdeNfsEzYY2SL1akWDGPrHGyIowmdqMq6njJrIEkFhnyGasibD4do5TSNe4c9W6gzRA7ZLMqV5RNXcFdd1sNFe07dXIZZsGkdW+DjHGx2i2eatEZ9dVqQM+XiawxP9ekdfIzh79PP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Gregory Price writes: > On Mon, Dec 04, 2023 at 04:19:02PM +0800, Huang, Ying wrote: >> Gregory Price writes: >> >> > If the structure is built as a matrix of (cpu_node,mem_nodes), >> > the you can also optimize based on the node the task is running on. >> >> The matrix stuff makes the situation complex. If people do need >> something like that, they can just use set_memorypolicy2() with user >> specified weights. I still believe that "make simple stuff simple, and >> complex stuff possible". >> > > I don't think it's particularly complex, since we already have a > distance matrix for numa nodes: > > available: 2 nodes (0-1) > ... snip ... > node distances: > node 0 1 > 0: 10 21 > 1: 21 10 > > This would follow the same thing, just adjustable for bandwidth. We add complexity for requirement. Not there's something similar already. > I personally find the (src,dst) matrix very important for flexibility. With set_memorypolicy2(), I think we have the needed flexibility for users needs the complexity. > But if there is particular pushback against it, having a one dimensional > array is better than not having it, so I will take what I can get. TBH, I don't think that we really need that. Especially given we will have set_memorypolicy2(). >> > That feels very intuitive, deals with many race condition issues, and >> > the global setting can actually be implemented without the need for >> > set_mempolicy2 at all - which is certainly a bonus. >> > >> > Would love more thoughts here. Will have a new RFC with set_mempolicy2, >> > mbind2, and MPOL_WEIGHTED_INTERLEAVE soon that demonstrate the above. >> >> Thanks for doing all these! >> > > Someone's got to :] > -- Best Regards, Huang, Ying