From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8760ACD5BAE for ; Thu, 5 Sep 2024 12:18:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 20BB46B0127; Thu, 5 Sep 2024 08:18:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1BC386B019E; Thu, 5 Sep 2024 08:18:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00D8D6B0496; Thu, 5 Sep 2024 08:18:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D20076B0494 for ; Thu, 5 Sep 2024 08:18:52 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4B3541C6A73 for ; Thu, 5 Sep 2024 12:18:52 +0000 (UTC) X-FDA: 82530588504.01.C33042C Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by imf04.hostedemail.com (Postfix) with ESMTP id 8488940029 for ; Thu, 5 Sep 2024 12:18:49 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b=K9RNtijG; spf=pass (imf04.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725538682; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uHtMyZ0mGdGut63ipl9pSNEPhg4gQFAZt25TdNzawnM=; b=XFlSyJ5UKw2Lk0oaLd1LzAYhpmapTjeFps8WMBZx6p0cLQ1etwmdDSpaeBFpLS2IKVCPmK AD4pU5i1OdbBW/7sO9qfdchWvtORQYESa54kS7LT1YJoHJlbmwdduvUueuxd2ne488Kbg2 9yi1Se4HaJ/TNqe22tyVjsX7nIxTrUI= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b=K9RNtijG; spf=pass (imf04.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725538682; a=rsa-sha256; cv=none; b=dMUYUdvE0y7CrCznQDDX2cguPmvNepgX4EcQ1vfUJMm4SVtuVh1v9ySVCG/gZ59vLvAUjN hPwURZVJvsOpxnhoDQKHh8YmVUB5BKg/isqy6PGP+vSXv9SZgwmVEU3PGsCsSodHrtP5xz 6sLm4ee/mqugYwkGH8Gq/U7KbpfuJ0g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1725538726; bh=uHtMyZ0mGdGut63ipl9pSNEPhg4gQFAZt25TdNzawnM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=K9RNtijGnQSSSovlUF+85A4m8nKayeSvx/Ob0UZe5MJZyqYtM2pQp+6L4nOcFBaL8 BMvvg2k7bpp41TQpyqsAUXWRf9BykbfFXJDdQCMgNnVRzMXGqdYM3Sm6ZG58e+Zzi8 xqDI/zBSXPr5VH16d77RzHiYS8QQhrpNG+LVTWOYc8PJiopRQ7aKFTBzvlaxwbnjCz 6ss+QYEqmuStkZsohKp2idavtqXQSJWsED2PrAQKG3qsuvIpbAmxC3YKMYwXrruEr9 LEfLpNhWcsB0I1NH6JCVZcsdgJSq7qa1g0AzaMpAXveSikpyikaPbous9gKJoszvTM yYb9S47fFXRUg== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mail.ozlabs.org (Postfix) with ESMTPSA id 4Wzz0y4N1Rz4w2Q; Thu, 5 Sep 2024 22:18:42 +1000 (AEST) From: Michael Ellerman To: "Jason A. Donenfeld" , Christophe Leroy Cc: Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Nicholas Piggin , Naveen N Rao , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Shuah Khan , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kselftest@vger.kernel.org, llvm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, Adhemerval Zanella , Xi Ruoyao Subject: Re: [PATCH v5 0/5] Wire up getrandom() vDSO implementation on powerpc In-Reply-To: References: Date: Thu, 05 Sep 2024 22:18:40 +1000 Message-ID: <87frqe5m5b.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 8488940029 X-Stat-Signature: hdgpbcc19w8a9kxk1pgm741ngf4b3cbg X-HE-Tag: 1725538729-119254 X-HE-Meta: U2FsdGVkX18z94HkDtN+eH0Dz72SacMCJGeFLcgDH6I0/AYzqIvx4CErmRJjmpIgH8YBUHI/GvjA1qprI3IW3EDqT8wmdKbrjxP1bYGTtQ+vTiCoSdQnB77evrz09A+VZc6OUgEhscgo6DXFjHgwLKFQTCD3DcSANzQl8vD9l2/QdmxBGEG1KXw47x+PCpgKdq39YAWvcQvogW2zvAsQcNQCPO5CM4WTOGb+so5bHn106I9PslGDTPC07fgI5u+yEGjM1n00Q+K1CveshaCj9h2ixqnIWTuryDTGwEoFureLW5eR0JRKbwKMaXeMcmlWhVx9YeE/SZ7SULSnqqbtABdQ6OA5In8uD++ru2/M+QaQbJw2vSg8X/Tp9akpycTbgVI2+/sW3rX1XxMiMUFL5Q1PRx5KHJOm4CaxGgIBRgmc9U6E7PfDL6thDCCAU99g7ojEMyEF0XCoPK/UWFStc5xsmgL4sVNd7jW77cO5xyFF0sjlfH0id2bVowI/LcR/G5WFE8xjwbrRK4z78VZN7/LE9Q88ds+UP83QBlSUM7z10DJ5MAHAVk6Mjb+yVN57bgMv1g+2DCTzFvoF2/aQnSprHdNrYtbJ9zGpGoAhyHvizT6bvUeTvVD2vC5TvzqiuY2Ezbxp+inzC9ky0nh0rJKjYVc+dM6V63qTd8YSgzwVuipzHLCxBq4o9teDR5/1MdGmz/E+m0McVZK80NizDi//SKSIfBkA1MU/pcELzxWoTg0VUB5qCRxzjW18yMrHetSu0NgyUB3/vNcRJHw8m6R8dLykfCkIQEwmE3+oZOSBvR9Bt/tJImjkfluMw/FSnkEUsRMPD0hHc6rb2eIs+dbpq+ac3o/paKbyhEP5FAZmyYprG6L4SXGPhPYfqHVMMyKGUx4dXe8cdM+b95VIBYFSdhEXfuT/edwNYc/SlLp0m3ceiMhXuvYMMRjrJU4VlLqSSf3wehcKI234NAP O6kJRnjA pilu4KHp1r5h0yHv3jLGF0hI3hdoxpZ9k2+nHvXyuVFhqZ+1Iy3WgFv9Kg0v2PgGiYtD+wk0cmbwWaKlCsoBFVQUZwQM/gBSOtLJH4IDaUG1iyeS8YH6wvTZuNXE5yuABtmxB/KX1GsYnh6Tyw5g7JlzKfP7oWD2ngcwhwjIkt9zyuG/EhtkhVPJwTA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: "Jason A. Donenfeld" writes: > Hi Christophe, Michael, > > On Mon, Sep 02, 2024 at 09:17:17PM +0200, Christophe Leroy wrote: >> This series wires up getrandom() vDSO implementation on powerpc. >> >> Tested on PPC32 on real hardware. >> Tested on PPC64 (both BE and LE) on QEMU: >> >> Performance on powerpc 885: >> ~# ./vdso_test_getrandom bench-single >> vdso: 25000000 times in 62.938002291 seconds >> libc: 25000000 times in 535.581916866 seconds >> syscall: 25000000 times in 531.525042806 seconds >> >> Performance on powerpc 8321: >> ~# ./vdso_test_getrandom bench-single >> vdso: 25000000 times in 16.899318858 seconds >> libc: 25000000 times in 131.050596522 seconds >> syscall: 25000000 times in 129.794790389 seconds >> >> Performance on QEMU pseries: >> ~ # ./vdso_test_getrandom bench-single >> vdso: 25000000 times in 4.977777162 seconds >> libc: 25000000 times in 75.516749981 seconds >> syscall: 25000000 times in 86.842242014 seconds > > Looking good. I have no remaining nits on this patchset; it looks good > to me. > > A review from Michael would be nice though (in addition to the necessary > "Ack" I need to commit this to my tree), because there are a lot of PPC > particulars that I don't know enough about to review properly. For > example, you use -ffixed-r30 on PPC64. I'm sure there's a good reason > for this, but I don't know enough to assess it. And cvdso_call I have no > idea what's going on. Etc. It all looks good to me, and has survived some testing. Let's get it merged and get some wider test coverage. There is an existing comment in the a/p/vdso/Makefile about the fixed-r30 thing, tldr is it's a workaround to avoid breaking old versions of Go. For the series: Acked-by: Michael Ellerman (powerpc) If you can include Maddy's test results from Power9 in the change log for patch 5 that'd be nice. cheers