From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87AAAC5B542 for ; Mon, 26 May 2025 06:39:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 21C5F6B007B; Mon, 26 May 2025 02:39:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CD696B0082; Mon, 26 May 2025 02:39:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E39C6B0083; Mon, 26 May 2025 02:39:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E9CA76B007B for ; Mon, 26 May 2025 02:39:10 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 97540584FC for ; Mon, 26 May 2025 06:39:10 +0000 (UTC) X-FDA: 83484106860.11.25F852D Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by imf20.hostedemail.com (Postfix) with ESMTP id D31EF1C0005 for ; Mon, 26 May 2025 06:39:07 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=QOHdLoa+; spf=pass (imf20.hostedemail.com: domain of rcn@igalia.com designates 213.97.179.56 as permitted sender) smtp.mailfrom=rcn@igalia.com; dmarc=pass (policy=none) header.from=igalia.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748241549; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dzPA0wCJq6nCRh4A0bzOMqEcZWel0GiR+aFE6GArilk=; b=ysPr3rgD9xTOeVh1fhi8fx56WhCNsStnuHlJ8kJymW2UEsu5W4w6l7jmx6bnHbNcZIXI/T L1k4Gz/Z7gwUEPPEBhzkTL6cVYkW9HoqX7WPiQcRBMx0uYzV9nFa0y0CpNkkJl5N+9WLp7 W3vAZ7Od6k3VQqPwFuHOtktUjCaIP1k= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=QOHdLoa+; spf=pass (imf20.hostedemail.com: domain of rcn@igalia.com designates 213.97.179.56 as permitted sender) smtp.mailfrom=rcn@igalia.com; dmarc=pass (policy=none) header.from=igalia.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748241549; a=rsa-sha256; cv=none; b=7vhMz0v+N1n6tPYfyPc+XwYXmPc87nANenRL1GPbWCS/NVg87yL9crpV9/42bc9HQXU7Nk k9eC4eylEeVlWlQCcYnGUnMSYlNgAMzW+P5/X/ac0ZE/Hv+zAgpbmxLXkUt6LATUKHYVQU hhsnbGa6K65DXMVueUXO8doqPvrP/28= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dzPA0wCJq6nCRh4A0bzOMqEcZWel0GiR+aFE6GArilk=; b=QOHdLoa+cMuzjijaD4C2Un/WJA Zy7G8no7Gw6z7waXbmUsbiI5Aqb8+oWMCrrpLs7njYvL2VZSkyBCE6yesW12DYF/7YYENJOfkOc0z 7CUBMRIWngFXb28oQs7zSOYlrADyTp6zysCjHolIuvjd7x4+hL2yIzRPRVDRnVDmtWJ98mqcqA7uO J9sgTj0RNp3h0rdvaOyTVl/5tv4R9SlA2azbZ0zqO0+9oFnduXFTBUQMP9Hr5R9zMpg52VJ59Wehw 5NE1vt+EaP/cVIhWVH4wapifII/PM2BcrItX6CHeB/qBmKzlY9I2mC6jQ4LKdA2gADJR4Bzly6DS8 bRQAbHgw==; Received: from 53.red-81-38-30.dynamicip.rima-tde.net ([81.38.30.53] helo=localhost) by fanzine2.igalia.com with utf8esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1uJRUA-00DCdJ-5m; Mon, 26 May 2025 08:38:58 +0200 From: Ricardo =?utf-8?Q?Ca=C3=B1uelo?= Navarro To: "Liam R. Howlett" Cc: Andrew Morton , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pedro Falcato , revest@google.com, kernel-dev@igalia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oscar Salvador Subject: Re: [PATCH v2] mm: fix copy_vma() error handling for hugetlb mappings In-Reply-To: References: <20250523-warning_in_page_counter_cancel-v2-1-b6df1a8cfefd@igalia.com> Date: Mon, 26 May 2025 08:38:57 +0200 Message-ID: <87frgrc1vi.fsf@igalia.com> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: D31EF1C0005 X-Stat-Signature: 1siyczrxi7fpks5kdboiktkdgey9gxf3 X-Rspam-User: X-HE-Tag: 1748241547-863929 X-HE-Meta: U2FsdGVkX1/TjJhxKWkIAV9TDkWbrvf5S9tcGY0QH4XAaD9TcIa1CvBc/ZNEZdhRcY7FRRG63dWZVbYFFD/QaTfvhv5KBFKKUudQ9532TOutPm+s39hL1oeYpSlfamo1Zp2gxcsNnn4clUGvoiSp3Mz7Fy8s4SFraSne9ta0AK0IsCMIWZFn+sTPYS1irvRi3YztCE4AM3xt8lPys6zchAQ+TE6R3DJtcIoQWu3Yd7sfHzxui3t/pyLarV0rLXIn+GsK/QEANjotB8vmhMTfqaJJS2FZYmmRpqsQAA6i87eEa7Haizx1eG0pqKllGVyDctq3WI6P1HMHi6bsXLFcnb+4pvJ9cETWDpJNjYO3tQacqkJvAufYC1I/4LqCDWLpt/oN7nN0JzOEWzYZqwTFvfKzCuye5OryD3sLaNIsP83iBttjgB9ax7UzZPZH6zXoMRgaNrcZpBj6btBF2H7PbKoIEhWDu4bMe9AoLerLRQxmlrneUC50Lhi7DCJYiFlizqLWGdRMSxO6Vu3uXB+3gK2BIntRmBrkDy3Xsll/2ndV3S/wFOlw5NcEOkMZiVUGy8tM6xY5Lam7MQWFi4nnqM5+gyns77VN9ZVhB3uDSmoUQ8BjZdJ0cCBXB+Ihh2waSU1etqbYAPr4NcafqG5I+bU9jGDKDdmh+B9iP3ShojVOENHc+K4/0RxjJI7K1VKXrGRWqsgRzokNPCYxvz68gu+364FtYDIHvqRAHw+cocUaSkt8+pnfycT6gmu7JGARfMpjmKaFZWX7JAKbDpvgNaAOb17GNQeaV3MeEfCF6VDL+3TAboq01JAgrzzwuYppbikD4WnRiF1kGKtjCbMHW9J0wrgRbeodatx77S/+VyWelkAYaiL7e++hE5JHChyuO+VacDUOlRUp9zRAy4OUgOlbvdnYk40919haeUyNN/QNdZ5jS8MDKYmLEVVCCJHdhwzHZGp4ClWstjEW7HD PAWsRgnN RmcdIn3aQcTuQGktTD3DT3gZCniRoGwsFe3lagCdGjmLRGBMhVrmX0Pnbc5xnr12FMAIFFRajbNvRudwQzGYc7w7Hx5QYxJdnDLaK8O7A3O9V07ER8RYQi+ha2LyS1XnThX35h3zpTVruaa9h0m6VPm+bHS3PB2qWyy/BS847XZW/fMywx5899rG3h1bGuN3Igg/IvD+W9+mGfPayaoSV/8PUj+pm0mKJ/VjWiK7GZ4oo4uesjqfOUl08wRb9Jggtd5aFvnU2dphRa4TZjnK0ckYxrNoXDRv1SyuRX8A9MRY5iioSsSzPemsIug== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Liam, thanks for reviewing: On Fri, May 23 2025 at 13:45:47, "Liam R. Howlett" wrote: > nit: mremap(), do you need the ()? (is it literally this function or the > call path?) The mremap call path. This function isn't called directly by mremap() but it may be called by some of the helper functions in the mremap path, and I suppose the specific callers are prone to change in the future. Cheers, Ricardo