From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B840C47092 for ; Wed, 2 Jun 2021 18:38:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CB05F610CB for ; Wed, 2 Jun 2021 18:38:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB05F610CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 583EC6B006C; Wed, 2 Jun 2021 14:38:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 55A766B0070; Wed, 2 Jun 2021 14:38:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FB6C6B0071; Wed, 2 Jun 2021 14:38:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0051.hostedemail.com [216.40.44.51]) by kanga.kvack.org (Postfix) with ESMTP id 0DE686B006C for ; Wed, 2 Jun 2021 14:38:08 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 8B4CFBBC1 for ; Wed, 2 Jun 2021 18:38:07 +0000 (UTC) X-FDA: 78209643414.14.6501CBC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf02.hostedemail.com (Postfix) with ESMTP id BA0F54202A16 for ; Wed, 2 Jun 2021 18:37:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622659086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mdvTs07LMgFf85cjcKT6lBxwefQ32Na7wsSXKwDVKtc=; b=fVVoH81YUV8nBV0xwFqCOqbOrNk9tDB4T9A4uBXyEz/mbfCPcEmQsrEvM8RFyljVkwHq06 COpKJ+sdbTQ1LOd7R8CbEb9+hbnlpU9iLQyEr8VSeI74ej1Yyy5jH7VQz94PvITGO30v9i 0C32eIxdMb5vV5zR6OsjbDNvAfAnQrQ= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-315-gWQM9aHxP42JQO1WmsCvTQ-1; Wed, 02 Jun 2021 14:38:03 -0400 X-MC-Unique: gWQM9aHxP42JQO1WmsCvTQ-1 Received: by mail-wr1-f70.google.com with SMTP id q15-20020adfc50f0000b0290111f48b865cso1395932wrf.4 for ; Wed, 02 Jun 2021 11:38:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=mdvTs07LMgFf85cjcKT6lBxwefQ32Na7wsSXKwDVKtc=; b=TYFwkQPndmFyABIRzpnLI3tgbZrXOQUa6FaCVpedtpG9tETvRcXZwyUIf/k7OArG8K Gp/dmzrhqvjVmYJdD1hT2iL1gHP7KKccU0iHEKskrLErqHUqSwVb80O/+jePmX8ouNL1 xg79dIu9sgJD7DFqSMkVDJ0KkfhqUF/KCjg3xOgrb+fawxi5tb0sskzEh7woj3lhKtKI 6zxiJ1WeMkc9vEgAwR1r1lGUrmvJ9uAlWRCM3/C+ttbvwKSAji2LKihl+ZWkzStvycKI hFPeasRt8MkE2l6QkFzlvienFFaei7RtdyYsB8V8zMufL+INxCCLmdnqeL5lcLGIfmOh KhIA== X-Gm-Message-State: AOAM5316fWlHhWCxMUbl36oDqyKKq+jrcjeavg1IS3fOevlodbsqCk96 qaeFvrTUBMLDmxWZVjuf4fdA0pLjeBhFuCfFwcGoRWor4g0ezXw5Hab1K5x15uaujWA6UeytSmE +e3d5cSEJNOc= X-Received: by 2002:adf:eac3:: with SMTP id o3mr18326625wrn.157.1622659082043; Wed, 02 Jun 2021 11:38:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxuyef6KiBAlsn74PrPiXXROCnyunw+ZL/ZOZ/+jpYJUWZ39koRwxeHgGsq8eHVAhNJdVmnrA== X-Received: by 2002:adf:eac3:: with SMTP id o3mr18326603wrn.157.1622659081808; Wed, 02 Jun 2021 11:38:01 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6b6d.dip0.t-ipconnect.de. [91.12.107.109]) by smtp.gmail.com with ESMTPSA id w8sm822572wre.70.2021.06.02.11.38.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jun 2021 11:38:01 -0700 (PDT) Subject: Re: [PATCH v2 3/3] mm,memory_hotplug: Remove unneeded declarations To: Oscar Salvador , Andrew Morton Cc: Dave Hansen , Michal Hocko , Anshuman Khandual , Vlastimil Babka , Pavel Tatashin , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210602091457.17772-1-osalvador@suse.de> <20210602091457.17772-4-osalvador@suse.de> From: David Hildenbrand Organization: Red Hat Message-ID: <87f5c05b-f107-26b9-8c5d-d2394bee2002@redhat.com> Date: Wed, 2 Jun 2021 20:38:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210602091457.17772-4-osalvador@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fVVoH81Y; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf02.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com X-Stat-Signature: ooboz1wgdoiskzpoj46cqnmyxinz8ti3 X-Rspamd-Queue-Id: BA0F54202A16 X-Rspamd-Server: rspam02 X-HE-Tag: 1622659079-225429 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02.06.21 11:14, Oscar Salvador wrote: > include/linux/memory_hotplug.h has the following declarations: > > extern int zone_grow_free_lists(struct zone *zone, unsigned long new_nr_pages); > extern int zone_grow_waitqueues(struct zone *zone, unsigned long nr_pages); > extern int add_one_highpage(struct page *page, int pfn, int bad_ppro); > > These declarations were added by the following commit: > > commit 3947be1969a9ce455ec30f60ef51efb10e4323d1 > Author: Dave Hansen > Date: Sat Oct 29 18:16:54 2005 -0700 > > [PATCH] memory hotplug: sysfs and add/remove functions > > It seems that zone_grow_free_lists() and zone_grow_waitqueues() were > never used, and add_one_highpage() was always declared as static in > arch/i386/mm/init.c and later on in arch/x86/mm/init_32.c, and was > later removed in: > > commit 5e7ccf8635c93b493f7d378a57ce300fbe1484e8 > Author: Jiang Liu > Date: Mon Apr 29 15:07:12 2013 -0700 > > mm/x86: use free_highmem_page() to free highmem pages into buddy system > > So remove these declarations. > > Signed-off-by: Oscar Salvador > --- > include/linux/memory_hotplug.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h > index 0d837ce6ec11..9a19e97d4f1a 100644 > --- a/include/linux/memory_hotplug.h > +++ b/include/linux/memory_hotplug.h > @@ -80,9 +80,6 @@ struct range mhp_get_pluggable_range(bool need_mapping); > /* > * Zone resizing functions > */ > -extern int zone_grow_free_lists(struct zone *zone, unsigned long new_nr_pages); > -extern int zone_grow_waitqueues(struct zone *zone, unsigned long nr_pages); > -extern int add_one_highpage(struct page *page, int pfn, int bad_ppro); > extern void adjust_present_page_count(struct zone *zone, long nr_pages); > /* VM interface that may be used by firmware interface */ > extern int mhp_init_memmap_on_memory(unsigned long pfn, unsigned long nr_pages, > Right, that's a blast from the past. Thanks! Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb