From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12B46C4332F for ; Fri, 21 Oct 2022 08:20:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7367D8E0002; Fri, 21 Oct 2022 04:20:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E60F8E0001; Fri, 21 Oct 2022 04:20:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D5A78E0002; Fri, 21 Oct 2022 04:20:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4C1268E0001 for ; Fri, 21 Oct 2022 04:20:20 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 14E131A1327 for ; Fri, 21 Oct 2022 08:20:20 +0000 (UTC) X-FDA: 80044259400.15.AE935C0 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf10.hostedemail.com (Postfix) with ESMTP id 7E790C0014 for ; Fri, 21 Oct 2022 08:20:19 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6FAD8B82B62; Fri, 21 Oct 2022 08:20:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDF98C433B5; Fri, 21 Oct 2022 08:20:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666340416; bh=AL7mXijTs6cQLRrsvSBh0aBo019UQxlKxyn5vhQ+MhM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=TwMlRFBPBMzrJvbmMOfgbS+lp/iyywdV5zNYOm6pWMY5RUERn1yX3jVPQEFSJ2CJn nKnrVgC72ZN7Trmqo4pP8Td6rAajwkHDE3MGL0XBdcrB2cYzBzT91/zQ+/xEfRSFSr H1eTJ9drKNyRnic98r76bPjyws5kjKwp45Z06UZVO6niW63lfPDkRFukBB7PR0t/JI LD6O/hm8aCaSlErEyuFHKv2qf4P8aECkMADkTRKf7nvTn1vZT/wDGb1KEPloyvrIam Lj0rUafs4Hl0BiDppBbQ3fh4PNxNNTpWAGEErQrJTvKh8KN777UNGYjhuRoJ4B1jJO j5PHjzHpJOpXA== From: Kalle Valo To: kernel test robot Cc: Bitterblue Smith , llvm@lists.linux.dev, kbuild-all@lists.01.org, Linux Memory Management List , linux-wireless@vger.kernel.org Subject: Re: [linux-next:master 637/2652] drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c:432:7: warning: variable 'hw_ctrl_s1' is used uninitialized whenever 'if' condition is false References: <202210211531.zEaM6hBM-lkp@intel.com> Date: Fri, 21 Oct 2022 11:20:10 +0300 In-Reply-To: <202210211531.zEaM6hBM-lkp@intel.com> (kernel test robot's message of "Fri, 21 Oct 2022 15:43:30 +0800") Message-ID: <87edv1lhad.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666340419; a=rsa-sha256; cv=none; b=Y67yTH2PpuNbdNXsJFfaZgUOfLjbz93nXeDXFpWoCQPfLn/ftNmOOwZ2zNmEjDH7NrIwBy w1+P9uhD4ocLgav2zy2/vTCY3Z5e96aV4CWVdHxzB7k0Y7eTc4YpvxbGkoMd47C6bhI4Z5 fiGDCdbHzdDEFl0NfnoesxYesmAh65s= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=TwMlRFBP; spf=pass (imf10.hostedemail.com: domain of kvalo@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=kvalo@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666340419; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5xxHzp9wAHJVv0f8TxIW2qQHNMQzMNCHbaOq8iMHxlA=; b=4uJouLT53hoqYJElzNVSrGTgcevv4CO/5SS4f0Tuk2U6mkij4UjM4hrcN/OEgvdc/u5n0+ JPOXRW9ZzBcWWXwKoQU8WnmhZfRLHL44U4hl1/3kfLb39R8vUAo5ZcC6usQkLIB3aVkmMi t5gsa+qaO8T/9zRdyqNmavRzHtHEXxA= X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=TwMlRFBP; spf=pass (imf10.hostedemail.com: domain of kvalo@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=kvalo@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Stat-Signature: gxsuhq7q3mcmihogziy3ek8cc6i7xqf4 X-Rspamd-Queue-Id: 7E790C0014 X-Rspamd-Server: rspam10 X-HE-Tag: 1666340419-767138 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: + linux-wireless kernel test robot writes: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 4d48f589d294ddc5e01d3b0dc7cecc55324c05ca > commit: c888183b21f36a247bb166ca9365705611bea847 [637/2652] wifi: rtl8xxxu: Support new chip RTL8188FU > config: i386-allyesconfig > compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=c888183b21f36a247bb166ca9365705611bea847 > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > git fetch --no-tags linux-next master > git checkout c888183b21f36a247bb166ca9365705611bea847 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/drm/i915/ drivers/net/wireless/ath/ath11k/ drivers/net/wireless/realtek/rtl8xxxu/ > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > >>> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c:432:7: warning: variable 'hw_ctrl_s1' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] > if (hw_ctrl) { > ^~~~~~~ > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c:440:7: note: uninitialized use occurs here > if (hw_ctrl_s1 || sw_ctrl_s1) { > ^~~~~~~~~~ > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c:432:3: note: remove the 'if' if its condition is always true > if (hw_ctrl) { > ^~~~~~~~~~~~~ > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c:415:45: note: initialize the variable 'hw_ctrl_s1' to silence this warning > bool do_notch, hw_ctrl, sw_ctrl, hw_ctrl_s1, sw_ctrl_s1; > ^ > = 0 > 1 warning generated. Bitterblue, could you submit a patch to fix this, please? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches