From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82F0EC54EAA for ; Mon, 30 Jan 2023 08:18:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E04C98E0001; Mon, 30 Jan 2023 03:18:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DB3D66B0073; Mon, 30 Jan 2023 03:18:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7B938E0001; Mon, 30 Jan 2023 03:18:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B676D6B0072 for ; Mon, 30 Jan 2023 03:18:58 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5B1E31405CE for ; Mon, 30 Jan 2023 08:18:58 +0000 (UTC) X-FDA: 80410764756.18.E4DF60C Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by imf30.hostedemail.com (Postfix) with ESMTP id 1A0698000A for ; Mon, 30 Jan 2023 08:18:54 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ZpF09QN0; spf=pass (imf30.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675066736; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=54Wdvz4krThrXZdZXU478LX9iA7z/k0g3ONzXRTvIV4=; b=Kh7QGoJoe7g8VV+54rqpfa///lQTxQ2XqKPxaF6CVdzllbo75ZTkVIXD4x+96z8ITneGe7 aNgn9RMs3KpeGXPXYdFvLg0ZiLQ6NkapVYjk3WwxnWYeSpHTinSuUfUiTr7n2nxPZjUnkj Tbm8xatjObouMAGG2PTCW9Vu2+5YWWA= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ZpF09QN0; spf=pass (imf30.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675066736; a=rsa-sha256; cv=none; b=6gLhLZaKCgfujQ51jHkm8gXZwWZNfGGvnrRT1NWZuXOLESwfZXgDLlQvKWuBoMk60RPTVB dwY+U30rFHw3o5eoeiuIPz0Khrl/me5MLQbxI7ZEd6xE+KNs1VpvhAmkFlThFXM2HAZu5M huwsarATiq4Kqfb0xy9hDfgBY8HAUc0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675066735; x=1706602735; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=+IYcHzTI7nRCOMHj/i2LpW/avtATij2NJKdYGvwOqcw=; b=ZpF09QN0Hy2h144VIO5olovr7ECoQ3dj5gO0763XBTiMvaKuPpxasGsC qGjOVqnl5EBANn/CkfE5b45IBq62/YF5Vb7mY0U3lOSY20UzfHpqWESHE QlocNWsU9J5qneDwrbwTAKFvH3hYLc56Bb/xZHuxTvNKAKm/3gbIWHK2R Tjc5obpbkOOkzhU0pgBxK1+7YsfPIf5oAtS5W3t0gII1Jj9AXEHtCJxAh yfArq/kygiDGHe4Z4iiFW3bOOCXPGl5+D6o9ekXKNbsOyrBue5lV1W/sF 979pCZwBVXOpqPRugsjPfMQEWIgn70vvmu19vgRl3N9mpZXL8oELvcKp8 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10605"; a="307847951" X-IronPort-AV: E=Sophos;i="5.97,257,1669104000"; d="scan'208";a="307847951" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2023 00:18:53 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10605"; a="806580987" X-IronPort-AV: E=Sophos;i="5.97,257,1669104000"; d="scan'208";a="806580987" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2023 00:18:51 -0800 From: "Huang, Ying" To: Tong Tiangen Cc: Andrew Morton , "Aneesh Kumar K . V" , , , , Guohanjun Subject: Re: [PATCH -next] memory tier: release the new_memtier in find_create_memory_tier() In-Reply-To: <20230129040651.1329208-1-tongtiangen@huawei.com> (Tong Tiangen's message of "Sun, 29 Jan 2023 04:06:51 +0000") References: <20230129040651.1329208-1-tongtiangen@huawei.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Date: Mon, 30 Jan 2023 16:17:55 +0800 Message-ID: <87edrctozw.fsf@yhuang6-desk2.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: he8wby36x5tf85zz9aqtxajcdyn1owui X-Rspamd-Queue-Id: 1A0698000A X-HE-Tag: 1675066734-858676 X-HE-Meta: U2FsdGVkX188Z4TsXLID4ZC+qyOk/fCSn2g3J9BlKUJiY6nQ/xv/lLWDDmtQEu0yUsWCMskwNvCjQbU8/XVrLw4wlSlGS+rvHm3x2qev1S43Q4c2oUqOFZkkX0sWsPY2TG8sQj1HmNOGPJOL9k9eVSRWZBZt95YMHmJ7mYo00YVO8WlinXZEIGCa7SrdlmJU2IbgCCjgtjI2TvArdkCycMHYa0RE7TekK1VacQTbGzljqBvX278CXkya5jNJCsAHzLc2rPSPx+Ct2ofFIlRBcwkD+MBjjtKIuQ/9FqOmtfZzMA9IR50XGSYC19ta4LanfCF/3DppKWBgMFXkx1w+QnIaPHogpS3RG3CYGNosoRn1Ma4Qlsq3IuwY1s3buXtfJfWSAvXO16EMIOT9zOd/fFQBsCtBczrkIRWVgF1vNhnHCKpP2skLT2nPBVua3rhhxmoQx2kXX6TSwl4eX3wbcBO7vj1DLbHbHgRftdjNQyqjthHLAZAq8DaEzSOFLOfoMBnNno8Xt3ATah0DcIhbfAUOeZhUZnaPEjVCciq1ixRSjFSgKjHKLx7jVVE0EfW7+/aa1E6z8LHjH01C+k44nGZ8pSMQmbDmVx20pUdgLXhtLsCOnilwHGROwkKM1z/3niK/YjqKWQmuRQZnXRDQlMTzFTcuG3mz1RqXpE/hlJxxXPcDr9PuYJxbJujJsWxvulwGD2jISAN2gWOoot/qRsXn+7n4PzbWqYTtF4Cm+yNVYHL9EDf+5z+aq20nAxxoyNMFC4w4EkGYCo/WTTHtzmLVuvPJDXJqffiOb7/dxPX+acWpfN3vymiR5KFRcWr6vN9n+NyVWscZItK9rydThll+1U/7anDq7d5qKZMmQ6cHQwOIvqkD6otcGst29VU0ZfjWZeuGYtibKHZNUHeDxpU+XnsQ5mEkZtpFJcOwruC9h5ZEZxXvi1zxGRtigoF20TpdqeQ6rCvxJtyiEOD 9S+E8tJR 5fcWJYNK1EV6jEX7BgbtRzyZjo/MxOLO+6GzagubPntNvw/AfWoURe4ZjhWvgkkw8xFAy3EU8SQU7zVNKXwjuc89nVGFlqYjRE3RG2UViplB4XcY/CX/wXTx4u7owPjI67vcJ2dAJy054K1fIO+KWtI6LB07rPoiEra2DnIXjaQszp2bP8hoitGJmErZn+tLB+cZpm5D5lmrLGEVxyYE5uDNm5iFX4sw+P56S3I1TR5+cB2I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Tong Tiangen writes: > In find_create_memory_tier(), if failed to register device, then we should > release new_memtier from the tier list and put device instead of memtier. > > Fixes: 9832fb87834e ("mm/demotion: expose memory tier details via sysfs") > Signed-off-by: Tong Tiangen > --- > mm/memory-tiers.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c > index c734658c6242..e593e56e530b 100644 > --- a/mm/memory-tiers.c > +++ b/mm/memory-tiers.c > @@ -211,8 +211,8 @@ static struct memory_tier *find_create_memory_tier(struct memory_dev_type *memty > > ret = device_register(&new_memtier->dev); > if (ret) { > - list_del(&memtier->list); > - put_device(&memtier->dev); > + list_del(&new_memtier->list); > + put_device(&new_memtier->dev); > return ERR_PTR(ret); > } > memtier = new_memtier; Good catch! Thanks! I think that this should be in stable since v6.1. Best Regards, Huang, Ying