From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FF5FC636D7 for ; Mon, 13 Feb 2023 11:32:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC04B6B0073; Mon, 13 Feb 2023 06:32:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B702F6B0074; Mon, 13 Feb 2023 06:32:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9EA8A280001; Mon, 13 Feb 2023 06:32:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 91CAE6B0073 for ; Mon, 13 Feb 2023 06:32:33 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 56C631214EC for ; Mon, 13 Feb 2023 11:32:33 +0000 (UTC) X-FDA: 80462055786.29.FF1ECB8 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2055.outbound.protection.outlook.com [40.107.95.55]) by imf05.hostedemail.com (Postfix) with ESMTP id DE0DE100020 for ; Mon, 13 Feb 2023 11:32:28 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=d4MJhPJ1; spf=pass (imf05.hostedemail.com: domain of apopple@nvidia.com designates 40.107.95.55 as permitted sender) smtp.mailfrom=apopple@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676287950; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=btLVYfIKNnZxSevx6q+E+h9eoZUw7/7Y+cNxUcIKQyE=; b=VZOhRq1qk6IFmjcwyd7DILBfVSkXCzF/wTeWm3ypH3j3Vzv2pbOAJWlQfhGCrwtqJX60QE q3ValzzdMjGwshZf3HICWNkZ4B+UAgVVEF3hRhX0TJo64EyYLo4erKUOdY+BfzwcRA4dES ncXvVzHJCFgKwIUu8DdrnU0cD99f5rA= ARC-Authentication-Results: i=2; imf05.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=d4MJhPJ1; spf=pass (imf05.hostedemail.com: domain of apopple@nvidia.com designates 40.107.95.55 as permitted sender) smtp.mailfrom=apopple@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1676287950; a=rsa-sha256; cv=pass; b=1/Z8zfd6CSQxdotK1EizsotjUpUBMMX0X3nnZQz0k6hXN677hfq0ByJkG9AurLlBytzZ7I hTcIjrWNGw1yWccziD7Yq9940aRvgF5Fheu8wH4bdUSiIHoH7jnmnz6HAWWTWnqMJCyzdN 4VR1hN7c9ktgppPTXXsEn5VAk/UfTA8= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yu3wReix/6wrH+G7k4LUuOs757B0YBQ86tp3NtiGMix1TUlc6iu4B37pAEWpsglOKRBN/C6bwLfQJsegtbqVo8yDR3WBhA7Bx0RRTXKu8n4XCG1Wg+AU5ncHsqJdjJ1Xr9tDyl229x9LhnPGmGWyCT2q3zVEYIXo6Tu66xU73xw4yn/ICuymA1D4Lp1qsHhGLJYgc7j/19py8X7LvIlOYPdkca5XPUtsP5U8X6LZP/e7OHXjcnRIC3uYUkMh1fFiqusyz9d1pZa9mV+MhhE0T3GXL9RMZjma12paeBdBAwjuvoBIBfqadeqAsKhqaJilrHW2QVOaPghoJAIYcrsDiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=btLVYfIKNnZxSevx6q+E+h9eoZUw7/7Y+cNxUcIKQyE=; b=DqKrtt5bk3wBVK5byqiJ1yVHS32UISYc2Q5GmSYeBoWO7GCE/0EybchEhQR6JpOeNvDOfo+0W/NOhVKk4FzUuhe9D2L6/F7WLa7KeZlnNUkNN+AvbGoB0t51NF5ao/AoO3bQ30yOFSIWOJg+f2ReZ00L5NUZeqi/rAt0358YgZApY42N1tabRAXCVhaRShbhoK4PcmDmGIhSEPLvSw48SBTWWW7hFJxUYnwk4IDCpFVJXRjV1P41M73jKBXtb5Vz0IsQAcH6YOu/pzlQ1TRbyoNk3m/+R3EuCGle+x+fHhsBtI6oBJkyUY2g+HLYTlE9gc7JCuOaaZuxiCrVB/fxtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=btLVYfIKNnZxSevx6q+E+h9eoZUw7/7Y+cNxUcIKQyE=; b=d4MJhPJ1CovhcKa/Grfh7FHWAeTHCNKWJbijzt9JOxNwbmWgqQSeLMUEm1Zs+mp/b4IbYfOqoWCMOvRE2c006u7EvbNiQyxLfKYJe4h89RoPPW9i8VvwuuaKuHbWkWm+4x0MPCYztz4Y3FpUtAswgpvt7J+OM+KkYDE5ytKHdNEssLCuVXIxhlArnEtb2kZnolBVOi1jY+0eC5LOFa6sUjSiNi7HFDtSOO6HLdxN/RPRUGgKEoq8645ILg8UM0/+T9xWT62v0gfseawejSFemieDhAgxzbyW2+zbydFhV2C7krRm6F6Pg0p+KbFcs9cyadoS7fvDN3JlzzxDVSx/4Q== Received: from BYAPR12MB3176.namprd12.prod.outlook.com (2603:10b6:a03:134::26) by IA1PR12MB7565.namprd12.prod.outlook.com (2603:10b6:208:42f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.23; Mon, 13 Feb 2023 11:32:26 +0000 Received: from BYAPR12MB3176.namprd12.prod.outlook.com ([fe80::4bd4:de67:b676:67df]) by BYAPR12MB3176.namprd12.prod.outlook.com ([fe80::4bd4:de67:b676:67df%6]) with mapi id 15.20.6086.019; Mon, 13 Feb 2023 11:32:26 +0000 References: <44e6ead48bc53789191b22b0e140aeb82459e75f.1675669136.git-series.apopple@nvidia.com> <52d41a7e-1407-e74f-9206-6dd583b7b6b5@kernel.dk> <87k00unusm.fsf@nvidia.com> <53816439-6473-1c4f-2134-02cd1c46cfe8@kernel.dk> User-agent: mu4e 1.8.10; emacs 28.2 From: Alistair Popple To: Jens Axboe Cc: Jason Gunthorpe , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, jhubbard@nvidia.com, tjmercier@google.com, hannes@cmpxchg.org, surenb@google.com, mkoutny@suse.com, daniel@ffwll.ch, "Daniel P . Berrange" , Alex Williamson , Pavel Begunkov , io-uring@vger.kernel.org Subject: Re: [PATCH 09/19] io_uring: convert to use vm_account Date: Mon, 13 Feb 2023 22:30:42 +1100 In-reply-to: <53816439-6473-1c4f-2134-02cd1c46cfe8@kernel.dk> Message-ID: <87edqt243d.fsf@nvidia.com> Content-Type: text/plain X-ClientProxiedBy: BY5PR04CA0021.namprd04.prod.outlook.com (2603:10b6:a03:1d0::31) To BYAPR12MB3176.namprd12.prod.outlook.com (2603:10b6:a03:134::26) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR12MB3176:EE_|IA1PR12MB7565:EE_ X-MS-Office365-Filtering-Correlation-Id: 8b228acf-9532-4b7f-9fc8-08db0db5fb22 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: U2ZCppw5OcGTlEAga3JDY0KU9gTL/AbFb1EOxhVz63c8cnr+4mbUCv4plM5d6wOljOFYMArOmU0cE/yKN4gZnEtA8+Kc+YfFH+PrnsCAdtdgCrk0qaWM/nRQ7h29HuoZqGwp/yEHI4c44xnKfhJJSE3kOwsL5V455hJknoje67/Gn267baoy6xhMg6RPO9kav6ebIGrRZB9Zuo4EoE9z+ZZvaZb8xPXLMvbFH7Ega1yolbR03OnUajyI+X3ALmVtgsspg8Qz1ZOeHTtn1QI6S9ZJKUMAGgUhk2yRXFdIiFIdWTlBYYqDqs43rOwTXb+M2zEpTm63BrhoaK0OUkjuYbpb0oRSDBbUNAbRy7MlxiCgWDBm1DZrdJWxuoDRSpJ40qif99sJlYHlMFg7Pp8OV16p3wU3N6bF5m80gVSvpffR0kdUkuu5xQcgAtWxpi2EW2RHgMyYTEECDTkijhkZL12dvK3N7EWnYGDyKVDO0ZPETujEanocM75cG5R4sm+LPzBkKuDWHXwvwmeWGwuCeq4A959g4C5WA6s90y5PURBEqvbwd4sTEA1M1uxSunkMoFaSM6Ews8/etrbIojzfnpeCB3aFo/lETSDyXmG5BBAAy4ZJAqAsi3V6InOf9yLuRtpniByQNsDH1GYvOIg8gA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR12MB3176.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(376002)(366004)(136003)(396003)(39860400002)(346002)(451199018)(8676002)(7416002)(8936002)(2906002)(38100700002)(2616005)(6486002)(36756003)(5660300002)(86362001)(26005)(186003)(54906003)(6506007)(6512007)(6666004)(41300700001)(478600001)(316002)(66899018)(66556008)(4326008)(6916009)(66476007)(66946007)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uULDRm+rMwtycwowVJGitE2mrRvX5Cjts2EV9FX+S1YoXxFzUSOvQwrYJMoA?= =?us-ascii?Q?1DOYSiiIOSETufJcr2cXzqt61gT5W+JjWuzV/Li9NfdcuSLw+HpOi1OUnXcs?= =?us-ascii?Q?AOZNtU4KHhPfc0MZJh99zD47HcVgjAoLSkcQfUP+SzWwtnr2UpOEbjqCMJ69?= =?us-ascii?Q?Mv3WQkv4Sa2z7t0OsBHrcWixDygxFFnfrCM6HSDT3YDBM9FXuuA+Dh+GFrAX?= =?us-ascii?Q?ufs/8P98IKhrSZQPiMkg+GTigiwacit28bb6Q/CS4UewZ2rJ3LKi0RRYPvFU?= =?us-ascii?Q?7BKhepBbmvtezE7Fz+vjJX4a4c4wbBcuXns/57s8AJQo0d/zPYWzZ5+Nf2kf?= =?us-ascii?Q?4+YD1dIppO+lYgtDd4tIeV51K1coTe2/v7NYLP/CMNjdnvF5gZgJ93YVrAgX?= =?us-ascii?Q?TBbPpZgB8DBjJVeCJzqxvhvR2+O9hXoLI8Ec+CKpwWCdr4W/nSDUHxcvDrwx?= =?us-ascii?Q?vNOrApqiF6TyX8qg5sdHKcWOYWe0N8OTalIT2skTE64kw0bML/CLyRYy+g45?= =?us-ascii?Q?XIuRNJW1BYF7Z0y4bg8HD36bTos9YEejruTH36/bdDLEAVIulztD0CSajLAF?= =?us-ascii?Q?aO0Pq1l4gwNgHM6LUqdTdEPUoWVJjOvIPK6qh9k6NX2iEr78P96hBp8D2fgu?= =?us-ascii?Q?0WiWhnenEgU8HnV/qKQHHVXYuBZa9vKUXJ6LLLvZTklysZTxGbiT0bwk4zrN?= =?us-ascii?Q?RI/HDxN/vF/oQei8wk5V0NhQt1r3YqKI0D/GGt5rlX8BKgNlp3Sw2HU2z6zs?= =?us-ascii?Q?VzyWZj49nPFdxLqh+bI3dxes+QkcjKUwe5vDjyMuuQ2giHr9jfSbQdtdmPZs?= =?us-ascii?Q?udexUdwwpvQBP1vKOl5i0pNYObznNCBk9uS/E57uNV62knrj1+9TMhBkscMM?= =?us-ascii?Q?XLkhgXhbzXpq6JJrT0SAv3kzNRscPeLDTzdZrFsNeCYB/uJlMzfRPWfJ1nEu?= =?us-ascii?Q?CzTYsw/zL6qf6n26XJre/7WYz4iqWhMZksfqHsC3ER/TrdN6xG7PYS3oz1KN?= =?us-ascii?Q?/jqYroajY18uWB3A6HDb9omyoyW89GfDnAzY37AioX8Qreltmrul+X50pYMe?= =?us-ascii?Q?+7T3JkrMCtp2cf1YP+28ntLTwMJPLhHZjN+c+pAbBrNDBVv+blU/pgV+D6qO?= =?us-ascii?Q?pgsP1TJzfnl5TuJncrZw7mr5KRwidaUu+dmF/vthJhYFTWxoiRpydX+24SpM?= =?us-ascii?Q?nr9Iuev6IXTi2+TfI6qz7+QgLuJskbZMbihJkSjbA1IwFTah3M9xvNiyjnD8?= =?us-ascii?Q?wUPDfUFPQAl+wGTmlyxs2fBy9UV3IuEbjcreDwFUwQIxr2W2l94gt3RykDgs?= =?us-ascii?Q?6CQrfuekZSStM22iuT+lZt3lrWystvjdVDajUlgSHTJL3TFHU57m01QORPJ6?= =?us-ascii?Q?b+mHAk2i6GHLAaiHE+dtQ/ljyoOHmqt6Cw9vTKE06SjWIYCUN+hKyhTULFF5?= =?us-ascii?Q?9NMjVeEu+yaazZ7deFgLKq8XDYlPLoZ7EP9X8Du5ZfnBUZdJHZV2WNOGfSBW?= =?us-ascii?Q?OiJhQchN83SDNyXcbVmg1TrdnV4XCo9LgG1dLDHWaay+nHykAtXB8JtnodM3?= =?us-ascii?Q?cnOSbHRVp5MpUxf7R5mPgYkqmD6KCiuH6HA3V38R?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8b228acf-9532-4b7f-9fc8-08db0db5fb22 X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3176.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 11:32:25.8680 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6ZrVFgFnplDZoq0jWMlqXW0dOPWSB9+JZMPqFFK9UtOCJtxZKczNyT5TcXoCv+5I+ktKiVwLrwjmjUpIL1HnFQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7565 X-Stat-Signature: r65bessjtqofuip6d13rec8ud4gz3eis X-Rspam-User: X-Rspamd-Queue-Id: DE0DE100020 X-Rspamd-Server: rspam06 X-HE-Tag: 1676287948-337972 X-HE-Meta: U2FsdGVkX18ngWl24BqCXQCGxll4X3GktNQCdBy0AbMzO4oNLB0wMFhNOc6XS0I6GHZrnDTQqoEEDuuUW8vPAhzcpxb7QcgSonvclTDab1lztvOSShfRKU4ws1dDkIUsysEzeyl6LYkKBoYR+Src702VSwGnp5fERJYL8OkkLcoLiklKkCqerur64suoNhQyWkg1Uv3v/igU53eAHZiHdaAV+w0OIL41wAxNHun6ra+d3jCqVsyRzGsaqiHm4jW/JU1YWaKKxsthkuC8hgf/QPn7SKCepJnGCdhTnL9agXNPv+3z7aKKd0xEp3JVlECAHzhrKFEfa8UwH9+ScZlBLLfztji2fiU8bwoHuBrouxCczBf9dA3oBC7yvas/Arrbu4+P2DnPcNMmq6y9UMfoRMdGjw48oxiBw0rgmILn8+ncycuh5RCPH75Hn3NTv4prQn/BAGNaSYLZc5guQ2iXl2fqPnMU1Rd4OFJtaeB14H+K4uGpeJVTM+PvaKxvdIU/Fojt3ZvSqm/bZlm6qSYz2VUDrq5ztBJn40ONQlQ6AJiLTuTQwQsBua1nLxbjMek8onqDg1sO/z83gp0H5SnYNyd7YlVp5Au+Kdcw3LIiCvMYsAKU2t/RuujI9yoK35lLiIEZvGYxgxPER16f4TLBT+cRm7RKmaN9otBenCuHlrHzScL8yL5FtKYYbKNeqy10My9gyPzxdrFHDy/65ucQfRv+KA31Nr7rHClFXmoC21I1Mv23OhZuIozkQys+DmWI9Iqgsd4m1dSu+X9Ns9h1EzInLxTmFggNlBqJho0QjsaYzb6CtVv+Ghur9jalE30HfPgkyP226crWIii0n7DCymTiLvS8pgxfj01oHOyEJokkoDtW+/fhX0fqIx/tUsvzygM8O0dkBrAw/y+/Kd8EDgKuZX+CdSiRklm8XkHVGkUTp+Q5QI2IgtHdZCtadnKNHLtgUZjCMOW5c4CezCF d4uoi+cu q2cpItH1LjymSh7V/EjBr0ltUkxwcOjaokccE6Tl0hF0/9tCAYh4po6fiDwDVa+bR2RRewJuTwcj3+buGLWYwrs4z1FyVGQKXLirUUbC0Bma1VrQcQR7zFl8pJVuLGYEfjBR87pnilkVx4W/7DzEWDITpNdzKYEWfeQmG8xYy84PAIlkpYfKN9lJ9hBuYXium8RcOrtS6bcaRmqRoCVlxK29uIB5+oBo40ZPetFDMi/cQVGwFN8L5ocB5tNGlxtcVgW5TcocnQLqaRiM/cR9f7F44XN4drlSktt9gXLlj/Y4nlkE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Jens Axboe writes: > On 2/7/23 7:55?AM, Jason Gunthorpe wrote: >> On Tue, Feb 07, 2023 at 07:28:56AM -0700, Jens Axboe wrote: >> >>> Outside of that, we're now doubling the amount of memory associated with >>> tracking this. That isn't necessarily a showstopper, but it is not >>> ideal. I didn't take a look at the other conversions (again, because >>> they were not sent to me), but seems like the task_struct and flags >>> could just be passed in as they may very well be known to many/most >>> callers? >> >> For places doing the mm accounting type it cannot use the task struct >> as the underlying mm can be replaced and keep the task, IIRC. >> >> We just had a bug in VFIO related to this.. >> >> If we could go back from the mm to the task (even a from a destroyed >> mm though) that might work to reduce storage? Yes, it's the going back from a destroyed mm that gets a bit murky. I don't think it's a showstopper as we could probably keep track of that when we destroy the mm but it seems like a fair amount of complexity to save a smallish amount of memory. However if we end up tacking this onto memcg instead then we could use that to go back to the task and move any charges when the mm moves. > Then maybe just nest them: > > struct small_one { > struct mm_struct *mm; > struct user_struct *user; > }; > > struct big_one { > struct small_one foo; > struct task_struct *task; > enum vm_account_flags flags; > }; > > and have the real helpers deal with small_one, and wrappers around that > taking big_one that just passes in the missing bits. Then users that > don't need the extra bits can just use the right API. Thanks for the suggestion, it should work noting that we will have to add a struct pins_cgroup pointer to struct small_one. It may also help with a similar problem I was having with one of the networking conversions.