From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0580AEB64D7 for ; Mon, 19 Jun 2023 03:27:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FECC8D0002; Sun, 18 Jun 2023 23:27:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B00E8D0001; Sun, 18 Jun 2023 23:27:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49F418D0002; Sun, 18 Jun 2023 23:27:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 381708D0001 for ; Sun, 18 Jun 2023 23:27:20 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 039AA8039C for ; Mon, 19 Jun 2023 03:27:19 +0000 (UTC) X-FDA: 80918061840.24.342E57B Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by imf23.hostedemail.com (Postfix) with ESMTP id 2D16714000A for ; Mon, 19 Jun 2023 03:27:16 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=KOsOlY1M; spf=pass (imf23.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687145238; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P3D7ckisKrPIXp5i6Rnst4b9eauRMMu7/gWyECT4acU=; b=Y0qYjXbQu6EiRT1jWeAnqmigTPmJuksfE1xBO3PzUI0WmbMZIrxkUmbQ9jPbqRHe3ybvXv t2ZqBbhCZxkxplJKF015E2dhMUhsms7f6EPXzr8c0cQ158DTuahtgfJRuHsByBvnXsZ6Ou ToDkVwk+PzyQwHMENC20f3CIFTNR2MY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687145238; a=rsa-sha256; cv=none; b=hgiJMt9FPMtGHsyCqJZ0LcW3mcyaLJNs52L4frTrf6sA4HM23UUneDC9cMpfbdq9j7ZCMK BOP347quPACprZ7KmwbhH1NviAmb/CHTUEW/Sikok2ienGN9JpkpK0FAv23lRJ8onS0PL5 g11ReKdZKaUr/x8zG1l+1WtL+LbwogI= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=KOsOlY1M; spf=pass (imf23.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687145237; x=1718681237; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=O5zztc/f2oQYxwqzTnF+e2glrsNYbDR/DOPtIyJtEdc=; b=KOsOlY1MP/JqoCOhIY18P7YYUPEPsjsRHIEPS8Da7oMlfyvl95bhOJbn QlyIF6aTMv1yxAV1/Ct70iiqX+wVzIMrTnPP11Zd9QsRYo2+jt47X4sO8 wrTo4RPizw+jgP9Fhbs6UmD251TX/AAsep0Ogd+utXrGVsRplHP1DTRlY sNS7kKGv46lQbu/66nebrVFojlU5rkcGbVLfTI75/1Pj1RiS1zMBh90ec YwAOMFueo8iyuxc2U9tlIpUTaDM5Gtl5HLYAVDY37mzZ04ZwcNSq27aBx N900M/JC8V3Yp7jP1psucqphRTYqSLiYC/xYLK3RZg5wRfsBXDpAUYHbq A==; X-IronPort-AV: E=McAfee;i="6600,9927,10745"; a="339870382" X-IronPort-AV: E=Sophos;i="6.00,253,1681196400"; d="scan'208";a="339870382" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2023 20:27:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10745"; a="707739014" X-IronPort-AV: E=Sophos;i="6.00,253,1681196400"; d="scan'208";a="707739014" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2023 20:27:12 -0700 From: "Huang, Ying" To: liuq Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka , Mel Gorman Subject: Re: [PATCH] mm/min_free_kbytes: modify min_free_kbytes calculation rules References: <20230609032552.218010-1-liuq131@chinatelecom.cn> Date: Mon, 19 Jun 2023 11:25:38 +0800 In-Reply-To: <20230609032552.218010-1-liuq131@chinatelecom.cn> (liuq's message of "Fri, 9 Jun 2023 11:25:52 +0800") Message-ID: <87edm88765.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Stat-Signature: qhrdfftdgud5wgjj34rkxf435kokbkfu X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 2D16714000A X-Rspam-User: X-HE-Tag: 1687145236-485423 X-HE-Meta: U2FsdGVkX19LNYtF6i681owFw9eBbkmpDgM+QlL0sDbCEALi/tFsgzkulcxZjf/b8/VtiOGZBtwl+ICfPg87haRv1ZGQCjE6g1B09AAtsH8SFaD65SA0rLplMLradN9Qtm2V9Uwf9Z/KeHyaiQkCFYZ4FjWHQyoFq11CXGUO3lwrLajeEiOkeca+1RPC+VAC6LkyekXzbe2a3+yOiEd7pTt7+9rS2MoWT1/GJLAzt2FoDNf/o/Ccp76ZHSMuQdCMf+PA2hlsEzGjDPWgwkwAdfX8Gm7sUv7AYYeazuvT2PzzxX3FjsMwyt6YdC3BownBsKnB3vk47LGkyUOc96q8RJ0/KE8x4wIJLxDkZQ+LiEqFv/AU2rENDhYvRRX+Zlo64VW+iRgW8IXxnZKLASP7MDxm1MuNcfhC6H/3NTg2taL26Utb500AnPd+hBeMF7i28GeCrh8L6+ldPcOE4KF71s9pHyk9qRjBk7igynTIrY7KXX+JER8lR26SkoL4MS7wJ/pgYZuRiZFXdYiOpoj0Kk0cf5C/nreBI7QyU/Ws1PVqnJy0JRoqR5lxwjSUzlYKbcgHhRNOccc1RvbTq2++B5/LvebIhQnXiGiKUtMowCaat9oGT66W0nZXMMQnmgFjOh5X4hnMJIlnuEV+LJd6e8dG7FuI20MnkwNqG3ksjKv/Mp2Q/wHmc9cqYUERMKXHOi8/4UZQa+cGCxDbDrxb/mDB18GvLpwhGT5jEhd8jswVfo8Q/pGcJnifNyxcy0ee7F3jiEHbjDdoRDawq5cz1/UXdeqCPzPHqN8HvGy4a/P1HMNsz3HZk45YH+4tay2DvqSgnCSiX+m63XnCUXNPNs713oZPZI/woHwfXeklrPTe3byo09muW3jiST8RqgFHcFT2ynsLeJGyMcIIvB/AZ6fgAmuWoYC6NXf3RBr3QTZnjKYCyq0k4AghykFPNhCfY7SKLSVZb98I6msUjp8 fgvjUT89 Yxy//WrVPQ8kafwEwb3cG94VCPsAXJpJJL6ME4EInU5dZhcsM8RZQb284fRpeD9wNcP2VSlmraqDYgvJ1SD1hYFuGREoVH0RrXNoN4JcuL07I7FOgpchHosh15ylpm1Ypagw8rMzvO6rRFfX1OPEbUCoCVMGGPgP6IdQ4HdoWRxvNsoMQ32wnjB5eXiQJr8cDQbWwafZcgM5Hs+7ntsP1VF4sZ2bkYn0MSUGzr4MdMlpkEPs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Added Mel and Vlastimil. liuq writes: > The current calculation of min_free_kbytes only uses ZONE_DMA and > ZONE_NORMAL pages,but the ZONE_MOVABLE zone->_watermark[WMARK_MIN] > will also divide part of min_free_kbytes.This will cause the min > watermark of ZONE_NORMAL to be too small in the presence of ZONE_MOVEABLE. This seems like a real problem per my understanding. Can you show the contents of /proc/zoneinfo on a problem system? But, per my understanding, min_free_kbytes are used for __GFP_HIGH and PF_MEMALLOC allocations. While ZONE_MOVABLE will not be used for them usually. So I think we should treat ZONE_MOVABLE as ZONE_HIGHMEM in __setup_per_zone_wmarks(). Best Regards, Huang, Ying > Signed-off-by: liuq > --- > include/linux/mm.h | 1 + > mm/khugepaged.c | 2 +- > mm/page_alloc.c | 15 ++++++++++++++- > 3 files changed, 16 insertions(+), 2 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index cf3d0d673f6b..1f91d035bcaf 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -863,6 +863,7 @@ void split_page(struct page *page, unsigned int order); > void folio_copy(struct folio *dst, struct folio *src); > > unsigned long nr_free_buffer_pages(void); > +unsigned long nr_free_pagecache_pages(void); > > /* > * Compound pages have a destructor function. Provide a > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index 16be62d493cd..6632264b951c 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -2342,7 +2342,7 @@ static void set_recommended_min_free_kbytes(void) > > /* don't ever allow to reserve more than 5% of the lowmem */ > recommended_min = min(recommended_min, > - (unsigned long) nr_free_buffer_pages() / 20); > + (unsigned long) nr_free_pagecache_pages() / 20); > recommended_min <<= (PAGE_SHIFT-10); > > if (recommended_min > min_free_kbytes) { > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index e008a3df0485..489b564526dd 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5775,6 +5775,19 @@ unsigned long nr_free_buffer_pages(void) > } > EXPORT_SYMBOL_GPL(nr_free_buffer_pages); > > +/** > + * nr_free_pagecache_pages - count number of pages beyond high watermark > + * > + * nr_free_pagecache_pages() counts the number of pages which are beyond the > + * high watermark within all zones. > + * > + * Return: number of pages beyond high watermark within all zones. > + */ > +unsigned long nr_free_pagecache_pages(void) > +{ > + return nr_free_zone_pages(gfp_zone(GFP_HIGHUSER_MOVABLE)); > +} > + > static inline void show_node(struct zone *zone) > { > if (IS_ENABLED(CONFIG_NUMA)) > @@ -8651,7 +8664,7 @@ void calculate_min_free_kbytes(void) > unsigned long lowmem_kbytes; > int new_min_free_kbytes; > > - lowmem_kbytes = nr_free_buffer_pages() * (PAGE_SIZE >> 10); > + lowmem_kbytes = nr_free_pagecache_pages() * (PAGE_SIZE >> 10); > new_min_free_kbytes = int_sqrt(lowmem_kbytes * 16); > > if (new_min_free_kbytes > user_min_free_kbytes)