From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFB89E95A8D for ; Mon, 9 Oct 2023 06:00:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4CF56B0196; Mon, 9 Oct 2023 02:00:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CFD326B0198; Mon, 9 Oct 2023 02:00:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BEBB16B019A; Mon, 9 Oct 2023 02:00:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id AFDE36B0196 for ; Mon, 9 Oct 2023 02:00:43 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 71D1CB45A9 for ; Mon, 9 Oct 2023 06:00:43 +0000 (UTC) X-FDA: 81324873966.02.7A1251F Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by imf28.hostedemail.com (Postfix) with ESMTP id 3D5CCC0019 for ; Mon, 9 Oct 2023 06:00:39 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=KYftTSkJ; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf28.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696831241; a=rsa-sha256; cv=none; b=l6b1L7fXCcralRuYTFVnRS0O7C/+g8GcvXxG+Yh0w6JafyN02BJv6rAahwSPm/3R2dH00U j4tlIx6TSWuED9t1KjXspfmJ0oSMxtNLZCEHKshuSmyaKYPuOVy0ojNplhyU1dyAXUV/Qa wGSRnzOJiRxo5eU0O/r1TlRRn9jFY7U= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=KYftTSkJ; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf28.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696831241; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vw4rJQNNvZJ/UOvfE6IjuLRJMi1/mwzx5Es6OzC80yY=; b=g1N4hU5CyhdapZH4UzhdFVvf7OM5fnDx4ER3xZxf7jfNZWOlhWs3PwKgqeIPq6XwoYDjCi 33wv7MgAxXOaALU4nd32884uTPS8s5q+XKGRiI6NmGrc40SguvmHG5nxJRhmW97tXVfXag hH32ZJ3Cx1RoiH2erK7IFY4nw5Cbgyo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696831240; x=1728367240; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version:content-transfer-encoding; bh=hpaPgeIMG2zlYHoqAZdtDRddF3V5fjkDFzWnHtt29sc=; b=KYftTSkJatPDB+LROzhTaKNjJPrdY0Fj6l+dyYL0qZZhNA3rvTxdWPCp DHoOzXns2U8zNY5F4287XYjGYW5PMNuolwTD7UAeueriExDBE3b4l7sHw oHiO/O6fTsSZgzJiJoe+OdfOcK+H+StK7vKnRrl8rFYYK/HzuvRQMfqqX +EWlgy6IPBKpUsuhiS4W4RZ2blBrNN2eO3L/baN1wJeQumVnxTU5QI+iF 7u0BubTf6/GnV+08wMw2RCPXOQ06Mq/h3Mr43Ecadje8PaDqDidekLUF9 khJc7+7fLv+/dz9FFN2mmAFyWyjsjFXb6E3dp0zk9Jj4Ee1p+DK6IbkAb A==; X-IronPort-AV: E=McAfee;i="6600,9927,10857"; a="383952891" X-IronPort-AV: E=Sophos;i="6.03,209,1694761200"; d="scan'208";a="383952891" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2023 23:00:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10857"; a="1000069872" X-IronPort-AV: E=Sophos;i="6.03,209,1694761200"; d="scan'208";a="1000069872" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2023 23:00:25 -0700 From: "Huang, Ying" To: Jianlin Lv Cc: tj@kernel.org, lizefan.x@bytedance.com, hannes@cmpxchg.org, corbet@lwn.net, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, akpm@linux-foundation.org, yosryahmed@google.com, willy@infradead.org, linmiaohe@huawei.com, wangkefeng.wang@huawei.com, laoar.shao@gmail.com, yuzhao@google.com, wuyun.abel@bytedance.com, david@redhat.com, peterx@redhat.com, vishal.moola@gmail.com, hughd@google.com, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, jianlv@ebay.com Subject: Re: [PATCH] memcg: add interface to force disable swap References: <20231007130905.78554-1-jianlv@ebay.com> <87mswtkj8x.fsf@yhuang6-desk2.ccr.corp.intel.com> <87il7hjzdp.fsf@yhuang6-desk2.ccr.corp.intel.com> Date: Mon, 09 Oct 2023 13:58:10 +0800 In-Reply-To: (Jianlin Lv's message of "Sun, 8 Oct 2023 17:34:44 +0800") Message-ID: <87edi4jq19.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3D5CCC0019 X-Stat-Signature: tbyu9o9zwfkhojored6rdpks9ugabj7b X-HE-Tag: 1696831239-741857 X-HE-Meta: U2FsdGVkX19OVBrHLBjSulxy/gceCZx2ZZ4yTbJwYd/XX/Zm7Wbb+3Ka+aShkyHEH+9+EyPOthghgdPNTUb5a3yGQVhqar9gVaK02xEMxTQl1N6knf1LolY4nK25r8OQf1Sa7Y2uDIQfYBlIlXAUPGT+4UArFNch3K8/P91hlTMXuIwsAzeIALQiBWmIqe0pN9PQUHA3wKM02mczEFZqcWwfFIEyuEiNs5d133JElk+CzRBg/bh/ywYXaRZ0jfRvzEIRwg+LNwKqDnDmJypnXbgrLqzjt63JtPbJC2Z2WZ0feciPDsm5pad9j6gu0e4IHNuORJvgoGqcO3TzEtXPmDCOdSWgNRcfkQJ/UrRR08Q5/Fcx76viz7TNsVWvZVHSu1J9f4zmyiUiA43xWxxonnE9WbnaxIkE0sC119f1iVcflvFszrDhP6ikA2D1XiLSoQCVdfXmVO1szvdVmdx0rhuxfLsadPSHhsM5Bh2tTVyOMBDtJA7iFkt6BAbEXMx/7XaUWgF4dPY6dNKnvyxrIU+xzVKypIvdzQrdpP6TKZOOqDcfwFQ0Zdbt+GOJWAKeW2ZY6hMGpAbzUpCOdr4ao6c06U+OQmGGMSxSOw1DZu5YPuu+P2oP5lJ3hL8APe8erqJw5xN67cl4CQ2vC33rpx0oNbS4WIEamwLzpScd9tER2hCfn4gXTR2QkbQ/QptwL3ONZVZ1KMkNY+2pgQYcj/3iB2GRBvhiwdtNq2lssdOGdzEca8KA7CckpCWkPhxWvtQvgr6XljoQxH04nYYRnCHj+af3WIhkPzdkNmkhNn2wltts9+wT++/9JjakR3fvXDLA6QSH+14N7WrjFvtY6xnLa0sntNo4/xUa/JcwRWVrzZbo0tUWrObBKEaPYghpnURzsnz3ikD4peX6l3ReUgUsLDX38m2P1JwO7VGzG8yKX08okK8AnwIk80t9/ZI5PjbPz8t/QVP67peUtt1 XuAXInr2 TdGXR4hj49+8XsaiiXbTxzLmB7/cGnzvyYXPIKAnQRfwcbLRrdH6/biFuBkcnuCrBqprzrhWsHvYeMfkTzNMZnEHHiCC+niFyekwsopuSFwF87EYcfpPwyCHj4t+ukzlTg86njmrvGlcc5MMmjFNBp1UlcMb/5Oe4PGeEShazmZENmtqIKYUihCPT0yotKqDaVsZzeWPETtQKLjSMx8/THStiWqqY75TvHE7sfaLp9k5utM4uwkSPdhZmzqcpLtz3Oj6D1GwmRk8+7i7yuHccWFKAJeexmkF+oxUSIvZ8mQbz7DtEjgUFL4+1FIoTtVzZSaGmoU/fQp+PdriYgzkeNSxnDspeDDBg0jzO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Jianlin Lv writes: > On Sun, Oct 8, 2023 at 4:26=E2=80=AFPM Huang, Ying = wrote: >> >> Jianlin Lv writes: >> >> > On Sun, Oct 8, 2023 at 9:17=E2=80=AFAM Huang, Ying wrote: >> >> >> >> Jianlin Lv writes: >> >> >> >> > From: Jianlin Lv >> >> > >> >> > Global reclaim will swap even if swappiness is set to 0. >> >> >> >> Why? Can you elaborate the situation? >> > >> > We reproduced the issue of pages being swapped out even when swappines= s is >> > set to 0 in the production environment through the following test prog= ram. >> > Not sure whether this program can reproduce the issue in any environme= nt. >> > >> > From the implementation of the get_scan_count code, it can be seen tha= t, >> > based on the current runtime situation, memory reclamation will choose= a >> > scanning method (SCAN_ANON/SCAN_FILE/SCAN_FRACT) to determine how >> > aggressively the anon and file LRU are scanned. However, this introduc= es >> > uncertainty. >> > >> > For the JVM issue at hand, we expect deterministic SCAN_FILE scan to a= void >> > swapping out anon pages. >> >> Why doesn't memory.swap.max work? > > The main reason is that deployed nodes are kept on cgroups v1. Check the code again. IIUC, for swappiness =3D=3D 0, anonymous pages will only be reclaimed if sc->file_is_tiny is true. If we don't swap in that situation, OOM may be triggerred. I don't think that it's a good idea to do that. Or I miss something? -- Best Regards, Huang, Ying