From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE401C072A2 for ; Fri, 17 Nov 2023 16:52:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 709A48D0005; Fri, 17 Nov 2023 11:52:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B9D08D0003; Fri, 17 Nov 2023 11:52:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 581978D0005; Fri, 17 Nov 2023 11:52:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 483E58D0003 for ; Fri, 17 Nov 2023 11:52:43 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 10C49C0670 for ; Fri, 17 Nov 2023 16:52:43 +0000 (UTC) X-FDA: 81468040206.06.CF0419A Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by imf07.hostedemail.com (Postfix) with ESMTP id E792B4001D for ; Fri, 17 Nov 2023 16:52:39 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm2 header.b=ocTtZWdo; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=ivNcVvll; spf=pass (imf07.hostedemail.com: domain of shr@devkernel.io designates 66.111.4.29 as permitted sender) smtp.mailfrom=shr@devkernel.io; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700239960; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qjad5w1xVe45VNf69YXVdf321u58ZmSanTzhkR3x92o=; b=O8HZb45V/2OTcouzTzxVyuGzFYphGfuBgTLsVMlBUOX0Dk+0yMkLUZdPo5q4YODLGkxRG7 lixzGKKbZbS2ymUWs+3HOGwmvt3aOfLKMWIKZdEA+uqZ5zBnk0D7Lo4pqxuoBekvhTU9kB y8s3sIEjjkx/GQ/9sYaGiLFq9KCxAy4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700239960; a=rsa-sha256; cv=none; b=hkvdYSAlxWMzm2me6zo4ELH7QJq6uTGI7P1UndNVMMQ/aWyV9mM3rWmIZsr883LN7aiN/o RFUBCFz4GCPLkiJRPVIH/axSX+lWosKF5/N83nOH3o5qbmswx2W4sEzV1raDCDUcjLlkvo uWDVTqeyGBV/xr8HpV6rmpzE2Z/NwbY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm2 header.b=ocTtZWdo; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=ivNcVvll; spf=pass (imf07.hostedemail.com: domain of shr@devkernel.io designates 66.111.4.29 as permitted sender) smtp.mailfrom=shr@devkernel.io; dmarc=none Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3523B5C00A6; Fri, 17 Nov 2023 11:52:39 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 17 Nov 2023 11:52:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=devkernel.io; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1700239959; x=1700326359; bh=qj ad5w1xVe45VNf69YXVdf321u58ZmSanTzhkR3x92o=; b=ocTtZWdou6T9ZnJINU 1lrlCAvSOFFPh2DgMFH8C3XpO3v75aMMzwhKuHsGsddJyQT5exPSFlKlWYowagop ccMEbKouRjnXqtINvy7nK6uOb/JZZDDXyEEx8r0yBllZT5o24grLTGKe9td7B3VK KRP85nU1EOBVEse45iTflbGPMTTKZNWdlWylr4AZmH2u+hpO0Uhpd//xde3iGEKz 7GtkKgbjBsJYMjfeoVkZxB3bcNfMhEZX43FeF+6pAcj3WurqGV+27WgikQM7A69F 3t9jxbrdO8VOjgT7F+THFhYBb+5T+29dKnrRI7+rnyhBCW7xkmBZfHnmVbMmWx73 t2Wg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1700239959; x=1700326359; bh=qjad5w1xVe45V Nf69YXVdf321u58ZmSanTzhkR3x92o=; b=ivNcVvll353DESAycqQeTIeA41Uwe Ia0x8tqlYC4Cn2PVrxNUNvAGfCpcAP+G/E6Np8EomRY7QH9vslLC9mRPvm77buLP l4loH2+ZAQNuN0NMgancgIn0YOD4c1sY6JcSvwqGjsylBCyOHjdeU/OFvgVBvtV5 UwnOntL4uWVELTc/Ccz4SezC13+pgXe60WVS8dQ/BUpe+jQcMtX/Drq16g5flsnh 0RtgB0B3Obi/db4wI8Zss4m0TmXpt8DcxLBx/WohSksFb9uQ37bnPRiC5MiwplqD DM4edNjWfe5u0QyJIEqiXGjYE/JeFP+jjtpY1PfD3BvhK40fe6NvMg4lQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudegtddgleefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvvefuffgjkfggtgesthdtredttdertdenucfhrhhomhepufhtvghf rghnucftohgvshgthhcuoehshhhrseguvghvkhgvrhhnvghlrdhioheqnecuggftrfgrth htvghrnhepvdduhfdvffduvedvkedvffejvdejuedvfeejtdejtefffeejgfelhfetkedt geeknecuffhomhgrihhnpehkshhmtddupgdurdhfrghilhdpkhgvrhhnvghlrdhorhhgpd hkshhmtddurdhfrghilhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgr ihhlfhhrohhmpehshhhrseguvghvkhgvrhhnvghlrdhioh X-ME-Proxy: Feedback-ID: i84614614:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 17 Nov 2023 11:52:35 -0500 (EST) References: <202311161132.13d8ce5a-oliver.sang@intel.com> <3540fd3e-88dd-462b-88ce-df28b7b5b148@redhat.com> User-agent: mu4e 1.10.3; emacs 29.1 From: Stefan Roesch To: David Hildenbrand Cc: kernel test robot , oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, Andrew Morton , Johannes Weiner , Rik van Riel , linux-mm@kvack.org, ltp@lists.linux.it Subject: Re: [linus:master] [mm/ksm] 5e924ff54d: ltp.ksm01.fail Date: Fri, 17 Nov 2023 08:45:07 -0800 In-reply-to: <3540fd3e-88dd-462b-88ce-df28b7b5b148@redhat.com> Message-ID: <87edgo8gq7.fsf@devkernel.io> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: E792B4001D X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: qd7k3t1e53pip79zmot5kk4bhgj1utr5 X-HE-Tag: 1700239959-781656 X-HE-Meta: U2FsdGVkX1+9o3BHgBP8CuSMRs6yF6+BRCggC3ZSHJcsvxAAKfdsP61c+tgJ9ErMJRE9pf6ESUHAOwbHGoEsIXhqztVV5d1frm1CJxPis9qWM52NPtlqfwZLD8q7UZ3a3SdoBCfQa57CaxEpWZ9xGgvuyprxTX7VvUNHHBEInYbfbVerFRhylt0hdO/VSe1/gQdDxD/5fAg7AqOmus70eA60ZuwXBnFxvpTeD8rAInpWgzq5TLNrVhZmUd4JJATeKO/kXvN/oLHC0p1eDZcRVvqGfrewIXV/7gMYMG0JYN+ckozScOPGnM9fvtklOECVgayS8Dt89T8APKYOkbzOtkBACBsClGoAadOhuwah+OIYUsTZNbHdfbLOCCtb/QHM9+uxu4y2ed2nccvZBecW037vgHji2a2g1cANX8peU/5XDiqJeEgVS5BnN2bXzoat7xNT3JRI+FJcOBgQyBd84iRTm5xIMV/J86vy1qsIB1jR+MYg6sugGtklE4+K6HZYoyhEOvXebEMaaqaXgtTKquisFyaOemv6uIE3qRGOTrgA9OzPtaDv6yDvqO3hmhmSC/BG4h8557Ja+S+Xt2nFUj9JfvOPrNjykFApnAPeX8Hq/TgDxV7Ur4mkXYmQFoUXtF4vNcFVW+UZwTy+qIjBaPxNdTpL6HvYXAWbSd/FKXMrr96aetsIvwuuRYMDXjKlbV4ivsbjiQHOJALCnYBYS/9YYM+qNp0ihgTJNfHLcS8UKT+BoYFPlIAOPHdxEzkhiRWgrtIi+YuGCC9YhUmauSWU1lim+VPvBPK5R+qkCf8V/8BV1yL+eDTQrPIjtdCyEZojWFY8R8DhoFButKtqzwr8O6VBMqjHUEZ2yEFaYOcrvyuZ3Wlp37iibE9Ki6K+/vvwH7Dc6/gRGTGiefXdOyo+smN7NBIc+tK3SxUrA+ENIlw4hnv1rrKGJf05v4A8L0/dNbv1K1oWIDKJ7wW 8waBMfNU 9tpj8H40PlwTaouyofRMkUtCSDDJrmTE7zl9mua6X2Zc3DCWtSpa8D2dXAqKxL7eskewlOPmlLvnJuclAOhzjFIgQZIBfAwuhpwnHVFuwiX5llL23B5+7MEEL9/A06qjkP7CJGdivfbQ8iPwyT8VEOvQnpVAMPatdqBXi9SMzdmlug7idjjOhM4RlM6o00lGSPYyusjBliv9d8ras16XQm2RY0dQhL3byVbuXXMLgPLuDus3XeuFCc7nLIuDcRGDr+JXOKEIfBjQTBuqp94W5WF4WclS0JdCBHZaP+LwvwU8yx1aA/ikwjVquEQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: David Hildenbrand writes: > On 16.11.23 05:39, kernel test robot wrote: >> hi, Stefan Roesch, >> we reported >> "[linux-next:master] [mm/ksm] 5e924ff54d: ltp.ksm01_1.fail" >> in >> https://lore.kernel.org/all/202311031548.66780ff5-oliver.sang@intel.com/ >> when this commit is in linux-next/master. >> now we noticed this commit is merged in mainline, and we still observed >> same issue. just FYI. >> Hello, >> kernel test robot noticed "ltp.ksm01.fail" on: >> commit: 5e924ff54d088828794d9f1a4d5bf17808f7270e ("mm/ksm: add "smart" page >> scanning mode") >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master >> [test failed on linus/master 3ca112b71f35dd5d99fc4571a56b5fc6f0c15814] >> [test failed on linux-next/master 8728c14129df7a6e29188a2e737b4774fb200953] >> in testcase: ltp >> version: ltp-x86_64-14c1f76-1_20230715 >> with following parameters: >> disk: 1HDD >> test: mm-00/ksm01 >> compiler: gcc-12 >> test machine: 8 threads 1 sockets Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz (Kaby Lake) with 32G memory >> (please refer to attached dmesg/kmsg for entire log/backtrace) >> If you fix the issue in a separate patch/commit (i.e. not just a new version >> of >> the same patch/commit), kindly add following tags >> | Reported-by: kernel test robot >> | Closes: https://lore.kernel.org/oe-lkp/202311161132.13d8ce5a-oliver.sang@intel.com >> Running tests....... >> <<>> >> tag=ksm01 stime=1699563923 >> cmdline="ksm01" >> contacts="" >> analysis=exit >> <<>> >> tst_kconfig.c:87: TINFO: Parsing kernel config '/proc/config.gz' >> tst_test.c:1558: TINFO: Timeout per run is 0h 00m 30s >> mem.c:422: TINFO: wait for all children to stop. >> mem.c:388: TINFO: child 0 stops. >> mem.c:388: TINFO: child 1 stops. >> mem.c:388: TINFO: child 2 stops. >> mem.c:495: TINFO: KSM merging... >> mem.c:434: TINFO: resume all children. >> mem.c:422: TINFO: wait for all children to stop. >> mem.c:344: TINFO: child 1 continues... >> mem.c:347: TINFO: child 1 allocates 128 MB filled with 'a' >> mem.c:344: TINFO: child 2 continues... >> mem.c:347: TINFO: child 2 allocates 128 MB filled with 'a' >> mem.c:344: TINFO: child 0 continues... >> mem.c:347: TINFO: child 0 allocates 128 MB filled with 'c' >> mem.c:400: TINFO: child 1 stops. >> mem.c:400: TINFO: child 0 stops. >> mem.c:400: TINFO: child 2 stops. >> ksm_helper.c:36: TINFO: ksm daemon takes 2s to run two full scans >> mem.c:264: TINFO: check! >> mem.c:255: TPASS: run is 1. >> mem.c:255: TPASS: pages_shared is 2. >> .... >> mem.c:255: TPASS: pages_shared is 1. >> mem.c:255: TPASS: pages_sharing is 98302. >> mem.c:252: TFAIL: pages_volatile is not 0 but 1. <----- >> mem.c:252: TFAIL: pages_unshared is not 1 but 0. <----- > > @Stefan, is this simply related to the new scanning optimization (skip and > eventually not merge a pages within the "2 scans" windows, whereby previously, > they would have gotten merged)? > > If so, we might just want to disable that optimization for that test case? > > Alternatively, maybe we have to wait for "more" scan cycles instead of only 2? I'd expect this is caused by "smart scan", where we can skip pages. The best is probably to disable the smart scan feature for this test. The smart scan feature can be disabled by: echo 0 > /sys/kernel/mm/ksm/smart_scan I'll have a look at it today.