From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8758CD3420 for ; Tue, 3 Sep 2024 00:47:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 23D438D011E; Mon, 2 Sep 2024 20:47:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1ECB68D0119; Mon, 2 Sep 2024 20:47:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B6D58D011E; Mon, 2 Sep 2024 20:47:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E092C8D0119 for ; Mon, 2 Sep 2024 20:47:36 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 82D151601C7 for ; Tue, 3 Sep 2024 00:47:36 +0000 (UTC) X-FDA: 82521588912.29.226C499 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by imf11.hostedemail.com (Postfix) with ESMTP id BA81E40006 for ; Tue, 3 Sep 2024 00:47:33 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=YIyFRrVJ; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf11.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.17 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725324349; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J9d0gHKIxyJBT/t4mZyAUYCd9YiBIMa5o0FkE0k8InM=; b=YmNIUMrViRWKKjKGRG/CnCuX3iUKrwAnK3cnoNK8RhTr5cm8GgROSiDjSlwNc1W3Sv3nk5 kqaD0d1ZeDgUBuQWwMY6EQYMnMwJBSArzr6FBOsuBkA9FlOrAY60BSvePTZam5f9grSZiu X690ZcDddXI5Sw+k356U0YKBs7Ev4Eg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725324349; a=rsa-sha256; cv=none; b=06bJ4/kDsOy/sIt8SI2Rmea6q97IRsbz7hc8x+wXKPHyfyjGw9hapoVFzpIIO9h9LDXtox 4pUCc/bR+1ZsnCGcS/C3oizW18HTVeYAsTZLAkpU+0M2PULGIRAuHSL0cdgxw0ctZAD3T/ fgciyCFfdbGtHebcKOGgVhsy53cj8fw= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=YIyFRrVJ; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf11.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.17 as permitted sender) smtp.mailfrom=ying.huang@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725324454; x=1756860454; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=8jH7+zPGHzSLqt3NjILmlJ3dyjoBt1jzqzGCSKdY33I=; b=YIyFRrVJffQMMG7SV3yzUCPFFEvpapioW9HmCgNKdeUw0RR2Xv2znWmX tw5UUXPsgzkyoIoa8KxT3kzvxHUv2Jo4B+SQEHKpRDn6KGp1dWGrvNYwE ZWuUqObktbSXXcHEXMZusnBOYxUoanxd5JWr6sqwslbRH0aQIYMpPwNix awP6/vx9X5rAESaoxOFuRkyU9B+ISupnhOgTvmy5lDCDN5p3lmMMW2qDW jgm9jQ5VRIHJlme8NNzVscFjoyChlRI5cTVDvor69GQbLbQoy0XQlPWJ+ cXDqVLl2nTqxazibc7Xvq20AWJ1FudlZyr9KAIl/01HYkC6duDEgX/OCF Q==; X-CSE-ConnectionGUID: iJAjgusOQfSkmKzlSBtOJw== X-CSE-MsgGUID: ucVgnsACR0C8IvxiFIYcUg== X-IronPort-AV: E=McAfee;i="6700,10204,11183"; a="24058662" X-IronPort-AV: E=Sophos;i="6.10,197,1719903600"; d="scan'208";a="24058662" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2024 17:47:33 -0700 X-CSE-ConnectionGUID: RGU/IMGwTaW0oSShIqfwNQ== X-CSE-MsgGUID: VIchrrutTJ+0nEO/rNqDHQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,197,1719903600"; d="scan'208";a="69371773" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2024 17:47:29 -0700 From: "Huang, Ying" To: Andy Shevchenko , Dan Williams Cc: Andrew Morton , , , , Davidlohr Bueso , Jonathan Cameron , "Dave Jiang" , Alison Schofield , Vishal Verma , Ira Weiny , Alistair Popple , Bjorn Helgaas , Baoquan He Subject: Re: [PATCH] Resource: fix region_intersects() for CXL memory In-Reply-To: (Andy Shevchenko's message of "Mon, 2 Sep 2024 14:56:30 +0300") References: <20240816020723.771196-1-ying.huang@intel.com> <66bedd0f746ab_1c18294b5@dwillia2-mobl3.amr.corp.intel.com.notmuch> <87y14wj4ju.fsf@yhuang6-desk2.ccr.corp.intel.com> <66c69470ae357_7605294ab@dwillia2-mobl3.amr.corp.intel.com.notmuch> <87r0a2g64n.fsf@yhuang6-desk2.ccr.corp.intel.com> Date: Tue, 03 Sep 2024 08:43:56 +0800 Message-ID: <87ed61ftwz.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BA81E40006 X-Stat-Signature: pxpdujghubegsewgwzmjqku8hb75rz3i X-Rspam-User: X-HE-Tag: 1725324453-621081 X-HE-Meta: U2FsdGVkX18TUdjaLEq/bpdF5X/HpMsWZod7VPBhHR4vKw1QXWc8PBd3ZKk/2r3AUIdBbeCsUgLx0lfwK0akRNowyVwUGnuwga7anj3vjtkNsZhHcW+PAhjRisa5XnBEh4zUO/i/OZDfQRju2/FTCeY1cHxT24UxXuEwT0l+1K5h4Oct8MaNW4xMR6vz3uqoqqrHOpd57OeYQLsivzBNqIiu+W4ZWzcExieAZ2zD67RJ8dIKZpdy4gDFXljEX1KJNyFyjvjbK+xPR4rlK3zlT5NCMRNcTfImro3/FkiZ0sUxbQ67WcUAHqumFSuEDwhE+frDteZtVtL8PGw8apRZOlCVUBRSu6+UIyIo7s+XFf0lD7VGHS7yXh9kDFGlpXAO00+P9G0VnNU5X21E+d7bfwc8KoY1ElTLWzAwEqbrgStOu70AA2CA4EC92RGCNPqL/euDPsFv2nCqLZJIauDM+1L/8TyLm+8P4BJrNxTxQRx7wQ511G3HgeExVuv6p0iFNQuXYo9OBNX/vIRzvFgLJDjCCFT5H3VMfECd9hkT5Wlrfc1M6zM5WqGaV4RznVsN/ESopViMjaGpQG55XjpWMtZGtY/j506tnhcOySvt7nW7rcJl01eejQcspb95Zle9iwPe38+82nB8/TMHU+TFZ4Y1ZKEqWA8Bp1w5594lKma1bLjFWVxXdbzMC/Itb09Lre8z7Zwkbb2EYZuEd3jZVOgA5n2LKi5NhExlwrbedujg0TmJ+6lLi/3QjJHnYqhE4ZjQsq+WW2fSeFQD0avIYy9EEz15nuJflnHfAwQW/bsY0RC/IINGYXRhhpKb37orVTcZHrIV6Z8Tc108x8ee93i0fOb4zKBSEgCi4n5Z2M6O5LJhgQY1gteupu4fTKzKCLIRFasNq9p6ZofUvfOwWmCF7yhX7BvYoHF35CNsXUCKNHgDJKKyoKJTKUuNRsr67Nb79nqZkwTQrOW9A4h TVNPjBJ8 bzk0RlNKhaAcAHJSFtgouDDQCoBoZ3zu5ztc2J8CbgnopE/3w37m9O6gh6DCSOWkwPm4hVdUHoKfVzrM3579VDUmwUg321VBAQgZdAY2P2gYEp+gzN/SpQWSxRvn+uwFO53xrJiSBLBgZFa711GUYbmjUrBMQuym+BTA9Uo6sVezQ9JejazGFgqs3kvffjHV9NhJqjMrbKoAe5xASkwkx2IxsbpIDsxk0VqALYfGNfkghI5XNvf38Z4qipWRXvswqJ4EU7fZTBMPjiXJZIpWzlj92yUWbBIgbNeHJDafKvdhF3sI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, Andy, Andy Shevchenko writes: > On Mon, Sep 02, 2024 at 10:07:52AM +0800, Huang, Ying wrote: >> Dan Williams writes: >> > Huang, Ying wrote: >> >> Dan Williams writes: >> >> > Huang Ying wrote: > > [..] > > Looking at how many troubles touching kernel/resource.c may lead to, here is > the question(s): > 1) do we have a test cases in general for this library? > 2) can this change be coupled with an addition/update of the test cases? Yes. This is reasonable. As far as I know, Dan has plan to add some unit tests for region_intersects(). Hi, Dan, Have you started working on the unit tests? If needed, please let me know so I can assist. -- Best Regards, Huang, Ying