linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Huang, Ying" <ying.huang@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Dan Williams <dan.j.williams@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,  <linux-mm@kvack.org>,
	<linux-kernel@vger.kernel.org>,  <linux-cxl@vger.kernel.org>,
	 Davidlohr Bueso <dave@stgolabs.net>,
	 Jonathan Cameron <jonathan.cameron@huawei.com>,
	 "Dave Jiang" <dave.jiang@intel.com>,
	Alison Schofield <alison.schofield@intel.com>,
	 Vishal Verma <vishal.l.verma@intel.com>,
	 Ira Weiny <ira.weiny@intel.com>,
	 Alistair Popple <apopple@nvidia.com>,
	 Bjorn Helgaas <bhelgaas@google.com>, Baoquan He <bhe@redhat.com>
Subject: Re: [PATCH] Resource: fix region_intersects() for CXL memory
Date: Tue, 03 Sep 2024 08:43:56 +0800	[thread overview]
Message-ID: <87ed61ftwz.fsf@yhuang6-desk2.ccr.corp.intel.com> (raw)
In-Reply-To: <ZtWn7rVhwcOUwvfM@smile.fi.intel.com> (Andy Shevchenko's message of "Mon, 2 Sep 2024 14:56:30 +0300")

Hi, Andy,

Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:

> On Mon, Sep 02, 2024 at 10:07:52AM +0800, Huang, Ying wrote:
>> Dan Williams <dan.j.williams@intel.com> writes:
>> > Huang, Ying wrote:
>> >> Dan Williams <dan.j.williams@intel.com> writes:
>> >> > Huang Ying wrote:
>
> [..]
>
> Looking at how many troubles touching kernel/resource.c may lead to, here is
> the question(s):
> 1) do we have a test cases in general for this library?
> 2) can this change be coupled with an addition/update of the test cases?

Yes.  This is reasonable.  As far as I know, Dan has plan to add some
unit tests for region_intersects().

Hi, Dan,

Have you started working on the unit tests?  If needed, please let me
know so I can assist.

--
Best Regards,
Huang, Ying


      reply	other threads:[~2024-09-03  0:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-16  2:07 Huang Ying
2024-08-16  4:53 ` Andrew Morton
2024-08-16  5:07   ` Dan Williams
2024-08-16  8:57     ` David Hildenbrand
2024-08-16  5:01 ` Dan Williams
2024-08-16  7:43   ` Huang, Ying
2024-08-22  1:29     ` Dan Williams
2024-09-02  2:07       ` Huang, Ying
2024-09-02 11:56         ` Andy Shevchenko
2024-09-03  0:43           ` Huang, Ying [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ed61ftwz.fsf@yhuang6-desk2.ccr.corp.intel.com \
    --to=ying.huang@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=alison.schofield@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=apopple@nvidia.com \
    --cc=bhe@redhat.com \
    --cc=bhelgaas@google.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=ira.weiny@intel.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox