From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AA95CEACF3 for ; Wed, 2 Oct 2024 19:34:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2EC134401CE; Wed, 2 Oct 2024 15:34:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 274484401B5; Wed, 2 Oct 2024 15:34:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0EE1D4401CE; Wed, 2 Oct 2024 15:34:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D5FD14401B5 for ; Wed, 2 Oct 2024 15:34:04 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 76027160BF9 for ; Wed, 2 Oct 2024 19:34:04 +0000 (UTC) X-FDA: 82629662808.24.64A9A35 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf23.hostedemail.com (Postfix) with ESMTP id 81679140005 for ; Wed, 2 Oct 2024 19:34:02 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=a8EAvpgz; dkim=pass header.d=linutronix.de header.s=2020e header.b=5loLpHo6; spf=pass (imf23.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727897515; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XtvYQ0wp1n9mLzgBjKl0MvaObys0We+viPzRs64Jd9I=; b=XseysT50ZPMRxThyrQ/c7Nx1Dh+FUjtctuTSPk9ZbDDpTUc2ZYlK1qKAasB755FcVKGwap caXsG8hvAjeXU38DrRvTAfWmtQP+bo7x/HR/0M2Qx7mwVpako0+P81yzgX0frHsI+WbHsH AGln4XafJqayR9lZkbIFBjbDrlr6f3w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727897515; a=rsa-sha256; cv=none; b=J/GnPCGA73KH8TFPUhEmtymwB0g7mFL6EUeBrKFsmrB2SY0TGO7d32hOdeegUhpnsuuoYl rjwyHCu4RI+fO7Y0ORKbXHeDLe8eiS22doeYcsWhu4xdhhpRaoCANb1fNOk1VLyYhRR5UI yTHbSSKcS4CfrdE2QLvBhLWsqHXv4hg= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=a8EAvpgz; dkim=pass header.d=linutronix.de header.s=2020e header.b=5loLpHo6; spf=pass (imf23.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1727897639; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XtvYQ0wp1n9mLzgBjKl0MvaObys0We+viPzRs64Jd9I=; b=a8EAvpgzFsLCW/AlrRonjZXEMvQOpA87FmbSh5AI8gQcIXGUH6WxsZdbzWa+KKZ9ghfG3C rjJ7daCVG39y2XEcTD54l0kTZuloeHUjNr8P1oT8gck1m7dccB/gf8MTOAt/E0sfZUoetM 3bPau8RswJzdj4TwGtEgrVMksf083ebi1PkFa/6/VgUi4ea+6MTJyTO+LcVXuCcUnq/Fsl W3agP3XE5Eo7nH0gv7NdXO8kjZCjEDoWEvrPxu39jswpYmUguRNMFkdRQPdycSJ4V7t7NG tZRhGyhYXu8+NfX7nBudvUI5TF/aLXJ2IBsI4eIng/sh3z7DLUhUaDt33xbT9w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1727897639; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XtvYQ0wp1n9mLzgBjKl0MvaObys0We+viPzRs64Jd9I=; b=5loLpHo6nw1uC3b/hFZ50bSgpoJqRSwTF45XEQYWDIka6DCc9oXrcFkzTwKDsmhykprcQ4 k7a5a4sFT/H5BhDw== To: Jeff Layton , John Stultz , Stephen Boyd , Alexander Viro , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Jonathan Corbet , Randy Dunlap , Chandan Babu R , "Darrick J. Wong" , Theodore Ts'o , Andreas Dilger , Chris Mason , Josef Bacik , David Sterba , Hugh Dickins , Andrew Morton , Chuck Lever , Vadim Fedorenko Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org, Jeff Layton Subject: Re: [PATCH v9 07/12] timekeeping: add percpu counter for tracking floor swap events In-Reply-To: <20241002-mgtime-v9-7-77e2baad57ac@kernel.org> References: <20241002-mgtime-v9-0-77e2baad57ac@kernel.org> <20241002-mgtime-v9-7-77e2baad57ac@kernel.org> Date: Wed, 02 Oct 2024 21:33:59 +0200 Message-ID: <87ed4ywb88.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 81679140005 X-Stat-Signature: wo9yrio531wx3tgqbh14cpo4dk9z6wfj X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1727897642-136310 X-HE-Meta: U2FsdGVkX18oFINroqaLHBvWYtkCPWwynDzoQfccj9XVrjGrsogol2c+SgY+ZSoYR33GlhwhlFBYSRcIezzgRvRzN9GQ7eHSEdSBlKVxj5WxpGLoS7TDI+Cx4WLCKbmngClcXy4QVA6AAAFeSHL0QJyFe0o9bMwwEor3oyR/z5xP7h4yPwD5REtK3KQqw0FDkvyOMotGz8A0WiqVsK/1tSbr6yCXRzc/GSnrkAJwAqhqHgEGWXk5hRcklgB8haGnX7kiQkd4Quxjb7l/J4n6JHqCq2DhMFacG7ih++wVUBRDRYGW7EBfIa9oGjBFZCDk4E5NRHDaaupSclLvzZhwRuZrR8mIgiE9zenH2k3V6EEF6I2wR3rhiV3OE8NKAzicC5FJS0Iyr7bJ0fIilwdqJrORJGdW0MR2YMQDptLnmtmuOB/XjuqhdSzQwAZPNnPdPFe7AKPo4fULAnjJJWj4QJoyKeKO02uFiboSZzB6r4LXw0zcI46ug49DR3VM4M0tEkJMHOpO3im8DFmUramjpiqV3t1/4+uyDqxq9Pji5H00YohVrCRVfNjWaX8z7onSBHFllk6nH2TwGNhxLeeGJIqp/ceY/AG1wLoIAHokbPh8vIGjH5FOCu6FBVtrpXHGGYR5kRixdj5kgNwF7H7ilRFNL9vjjPQBVYXIRqK8+rZmjOcovjZvTQPKAgiktLEjsbHsXfcNeDRe+/vXpRYaKJYrMU3/JT934JJwLbP+ZHYVfuU+lPSxmvDbEtnxg4lubATAw4lnOKiDXKNkhKQl1oCV3wiVjo7SIdZTqemkCrK7e9vFEoFSmGphHa/0UhtXuDZ6jr+pW9EayJiPPmpCCoDWtk1q3kLt5zypTXTT029OstswLPbzpI5JtDlW9xIhRkATkEmNeowPizNMoyz7ec3j4N4AXUBREKRHbXFr0OU25zTUx/omRYA+QMyKEJSqebupO9q8n6skD/ag5S7 semY+w9t YThHcRza4y8tlpaePtas7fpe1mehvhLkmHRoSPw9Yhk4D0LLWz9QYRGJDUwbRIBAUzTMCyb4PnlY6nRk9lOPby/Baqx6V9OMQS+babouCX++jQ0SikhWkg56LqOhU1r/6KD1DQGgyDDAkgxLqTpndHoglaNyRiPc8k7NU4K68MalM5/SkyK6SJUjNpnN4gMBCXeK3VtfUZf+Qyi1mpz/0WOq2QREZDYg/LcmHzmWno1Q1r8qPdvyN0pUcloWY2fB3nGpKYupu3pGBdtY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 02 2024 at 14:49, Jeff Layton wrote: > --- > fs/inode.c | 5 +++-- Grmbl. I explicitely asked to split this into timekeeping and fs patches, no? That allows me to pick the timekeeping patches up myself and give Christian a stable tag to pull them from. That lets me deal with the conflicts with other timekeeping stuff which is coming up instead of having cross tree conflicts. > +unsigned long timekeeping_get_mg_floor_swaps(void) > +{ > + int i; > + unsigned long sum = 0; https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#variable-declarations And please use 'cpu' > + > + for_each_possible_cpu(i) > + sum += per_cpu(timekeeping_mg_floor_swaps, i); This needs data_race(per_cpu.....) to tell KCSAN that this is intentionally racy. Your previous fs specific patch has the same issue. > + return sum < 0 ? 0 : sum; Right, a sum of unsigned longs really needs to be checked for being negative. > #ifdef CONFIG_DEBUG_FS > +DECLARE_PER_CPU(unsigned long, timekeeping_mg_floor_swaps); > +static inline void timekeeping_inc_mg_floor_swaps(void) Did you lose your newline key?. Can we please not glue this together for readability sake? Thanks, tglx