From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84925E64A81 for ; Tue, 3 Dec 2024 11:35:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A98BF6B007B; Tue, 3 Dec 2024 06:35:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A48A26B0083; Tue, 3 Dec 2024 06:35:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9103D6B0085; Tue, 3 Dec 2024 06:35:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 74C2E6B007B for ; Tue, 3 Dec 2024 06:35:14 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0B33E12089D for ; Tue, 3 Dec 2024 11:35:14 +0000 (UTC) X-FDA: 82853440950.09.B65C15E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id 62BB68000E for ; Tue, 3 Dec 2024 11:34:47 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hHI3kOxC; spf=pass (imf30.hostedemail.com: domain of bjorn@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=bjorn@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733225703; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h+Qm21TkTw9B8eX/oqyG+qMH9h9Hu+OcYbmEJns9q1w=; b=BNb9hklbF7I3aeKfCBO+4XAtpqmXvUYoFa9gWXzj3g0CL4W8YXiz21IyH0Rm0N8iy3Bpm5 MEj6WXNX5RY/NPr82zMAsqoFo/DyGImPdF7ENmEXyjqUCete+WWSLA1RttCDqoRkOnJRiq Ry6z08YMrQr+hnQsU3v0gdCr2m2gsH8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733225703; a=rsa-sha256; cv=none; b=XUizWlGW3PnWBcKTkpemRIyDzchfBlnwCo+MODqeO6wOl8+J2qZwUMgLAH4Fe3+vlrXzuH Nvq3vWvAY9YMSuSxN+sDbEFvlooJUFR/yGpW9RzshBDXyghktYDl55iiS36ebMr1+h7J8F KnpFqJCBg2QkI0P+THbfJq6B+j5autg= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hHI3kOxC; spf=pass (imf30.hostedemail.com: domain of bjorn@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=bjorn@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 3B4C65C6C60; Tue, 3 Dec 2024 11:34:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5EC7EC4CECF; Tue, 3 Dec 2024 11:35:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733225710; bh=3MWjk85NmWlbYMWabiD2fBNYO8K3kUK/Onp9ETA+5Y4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=hHI3kOxCigtxutre/XbKF8THCbBA15kF2UzeEXnrSamiyaEFqVM4H3c+96TIZ2v3I HpVLl0bl7MdznOYha2Hc7OVvTbjLuiVZMzAqTxx+ERgiEdIkVs/pCTEQkvtMRCQyLe H0mf7yKzj8unWbqRt7i0h7nFlGz4JXTX754TN7l4wpS8dqXRMW9jffGxoM5SjQRdh6 Zv01tQD3eXXzbR8kSvH8wD+zrSXGo5LIQHFCi4NwGDjs8BFDAK66oRovKf3ry8z2bo zpV+LoHnrso1bIivSeWZJBBQIdTGVKZrArvCYv36KO5jZfoKUYZRjAIY42MCc40VXh wUqFRvWrHkh1w== From: =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= To: Celeste Liu , Oleg Nesterov , Paul Walmsley , Palmer Dabbelt , Albert Ou , Eric Biederman , Kees Cook , Shuah Khan Cc: Alexandre Ghiti , "Dmitry V. Levin" , Andrea Bolognani , Thomas Gleixner , Ron Economos , Charlie Jenkins , Quan Zhou , Felix Yan , Ruizhe Pan , Shiqi Zhang , Guo Ren , Yao Zi , Han Gao , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org, linux-kselftest@vger.kernel.org, Celeste Liu Subject: Re: [PATCH v2 1/2] riscv/ptrace: add new regset to access original a0 register In-Reply-To: <20241203-riscv-new-regset-v2-1-d37da8c0cba6@coelacanthus.name> References: <20241203-riscv-new-regset-v2-0-d37da8c0cba6@coelacanthus.name> <20241203-riscv-new-regset-v2-1-d37da8c0cba6@coelacanthus.name> Date: Tue, 03 Dec 2024 12:35:07 +0100 Message-ID: <87ed2pdmok.fsf@all.your.base.are.belong.to.us> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 62BB68000E X-Stat-Signature: z3qqequ9facamcg4ftsuhq7wguqpw9bu X-Rspam-User: X-HE-Tag: 1733225687-723392 X-HE-Meta: U2FsdGVkX18SoDRFEnqFHn3Zk4pWiqeef0LfCtu17YO1rfk65sJJtXKocbthCBBsXiC5pxSsttddp+ccIe3oTfi764OWB796YVDNb76g8gPp8Pk8If7A1OBeRF8RVEzS+6BXpiY451V2HlvErTzl3vJtkkSxF/lSTCl/hIA+6CWlJJfAuIT3j4yBCmzFSEz26V7Pexg5fdfvQf/aNImAQ/KGRq2XYQxgE2Pt9VJQwZz4DkqN0VOhSDXl9LZa4wb/xCjIvOT295qilMAPvp3ZwBV0Q+DlRDMFujv1b/AAslTpbpjuEgOrbNjp7kZyu5XxeV9a3MLv/0QigjvMxwtMs5tV6cniBqmnjzvwMpZ0gP0vCwWtKdeIv3uAU/39LtVaBCp5/HJDw7/B9cW5m6IZbCYc60QHrHgCpts7PNQFsJbozWQ9AdWh/58V1v0/EfnCA+kxhIlEVbqs3E7ETex3fSZ4+sgd4aY9CCZ+0boZlN8Z8H3Poba8OM9g/U8SVGOoHygWDZdn8MyS0J4S3dUz1KP87FIW6+00Yrl1e6sqnjjXM8+bRqS7mK4ZlB4djOWzWN7CHCI/i055EpG1J9+nVD4h4+s9UBWHknnd9yvwTX4rNPFmJDRanfkqEkyU2ptTEtR3PWUQLS4WesqktOdVnhMOhIktJdAqE1I0PqT8tyQLTTg65KdRN7HYZyjdcjg1dQwlFFHpaNfFXcAbPXPrKjVeOMQQmcTeiY7D7rRDIhnVwFv1vqoD9tUjpTtUqow7gwJWNalOZWIhB8TApUfdv+ihLO03Zdi77EzlAmwt8MtNBa0Pjxrm37Lx7pSu+Fy5un130xMIw0fgPv6zEzTkr45GYNzIwJfBIWFbvx9I7mG5QlSILwuHZrmW5o7d6o2q8TqHJFf4fVNf/QGEfAU9WvqberoTc6GGXDRq5gERLpg4bbP9dQUAqFjIeGWfgHzlDbb58zLoZUyVQg+dCVv +16IgpqE nd9yRwmbT6KHUdOGHwkvXbL9bCCkH3N9MENwGIZRvkgh90ov696sO3NPKRJsz6BpmD159Um0T27dxzchTFn59yml+t1nrUQpTlY08WJVThSB2m7RAL4op40atvIr5A/j1z0ZvRwZj/O6LW0vDc//A3T+wuoaUL+2pHcmZUjTt/N2NbZ7Jc44t/WH+Dc9Yw0MAeoQuV4byFBJOPOFUnIUUentIEs4qOq+Itd9B8kbORHf6e7lAO7L/iSzRgM1XrbnAGRrDUi3rOhIPivw8dR4Hf4ieCi3Vnjma/iCammoMQpJwEar6mK/SS/Vb46PHcyouvY76Mrae3ijk9IYhLbsQUGpnR2drEmTkXW3UvmFWHW2K8ftSMdpFbftS13sMP54NqwyxT97cTKienFkYgddVxQyuwE6+4Z/teYqN8Z+q8oqXZz8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Celeste Liu writes: > The orig_a0 is missing in struct user_regs_struct of riscv, and there is > no way to add it without breaking UAPI. (See Link tag below) > > Like NT_ARM_SYSTEM_CALL do, we add a new regset name NT_RISCV_ORIG_A0 to > access original a0 register from userspace via ptrace API. > > Link: https://lore.kernel.org/all/59505464-c84a-403d-972f-d4b2055eeaac@gm= ail.com/ > Cc: stable@vger.kernel.org > Signed-off-by: Celeste Liu > --- > arch/riscv/kernel/ptrace.c | 32 ++++++++++++++++++++++++++++++++ > include/uapi/linux/elf.h | 1 + > 2 files changed, 33 insertions(+) > > diff --git a/arch/riscv/kernel/ptrace.c b/arch/riscv/kernel/ptrace.c > index ea67e9fb7a583683b922fe2c017ea61f3bc848db..18ce07ffb27bb1180667769ee= d800f6fdf96c083 100644 > --- a/arch/riscv/kernel/ptrace.c > +++ b/arch/riscv/kernel/ptrace.c > @@ -31,6 +31,7 @@ enum riscv_regset { > #ifdef CONFIG_RISCV_ISA_SUPM > REGSET_TAGGED_ADDR_CTRL, > #endif > + REGSET_ORIG_A0, > }; >=20=20 > static int riscv_gpr_get(struct task_struct *target, > @@ -184,6 +185,29 @@ static int tagged_addr_ctrl_set(struct task_struct *= target, > } > #endif >=20=20 > +static int riscv_orig_a0_get(struct task_struct *target, > + const struct user_regset *regset, > + struct membuf to) > +{ > + return membuf_store(&to, task_pt_regs(target)->orig_a0); > +} > + > +static int riscv_orig_a0_set(struct task_struct *target, > + const struct user_regset *regset, > + unsigned int pos, unsigned int count, > + const void *kbuf, const void __user *ubuf) > +{ > + unsigned long orig_a0 =3D task_pt_regs(target)->orig_a0; > + int ret; > + > + ret =3D user_regset_copyin(&pos, &count, &kbuf, &ubuf, &orig_a0, 0, -1); > + if (ret) > + return ret; > + > + task_pt_regs(target)->orig_a0 =3D orig_a0; > + return ret; Nit: Could be return 0, for readability. Regardless, Reviewed-by: Bj=C3=B6rn T=C3=B6pel