From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7157DE77188 for ; Sun, 22 Dec 2024 13:33:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88CE86B007B; Sun, 22 Dec 2024 08:33:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 83BB36B0082; Sun, 22 Dec 2024 08:33:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72A826B0083; Sun, 22 Dec 2024 08:33:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 54C016B007B for ; Sun, 22 Dec 2024 08:33:18 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id BBC881A14B4 for ; Sun, 22 Dec 2024 13:33:17 +0000 (UTC) X-FDA: 82922685300.10.4096636 Received: from out30-112.freemail.mail.aliyun.com (out30-112.freemail.mail.aliyun.com [115.124.30.112]) by imf17.hostedemail.com (Postfix) with ESMTP id 77CED40003 for ; Sun, 22 Dec 2024 13:32:45 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=cFHKLgv5; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf17.hostedemail.com: domain of ying.huang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=ying.huang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734874360; a=rsa-sha256; cv=none; b=Ic8ObhKYln65ESxGtH/rzXnTR0BeNbTAKsGNFaB3Rpzp3WA0YfiKyoMfeceliwi6nOQV9p EDy4M//ZorJrw86OkjPYmgfVO1+J5eM6TniaCkfv46kAgAory53oMfeKxEzChzyfktOtCj FEF/GtptFEFbibIq4Arh9Ic2f/W5AiQ= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=cFHKLgv5; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf17.hostedemail.com: domain of ying.huang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=ying.huang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734874360; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s1ugvjlIbNshvGS9ZZbP8CjQoqKgu4xuN4hxoL5UeBw=; b=hAbdsKrbn4x5iAaP3GosmGf3UcGtQ+JYE2iU8j/cmkvKD7u+BI0aM656+YG3fuPIq6LMjr hWogb/hDByWb1P0ZNUSpaNlbaQ+UxlWG5PAzgtBcP7QEcPiMeDOKIMegwFbhLTjrRoVXO3 88ehS5sOhRxme8Xz5SUpQpUBsTmHbwI= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1734874388; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; bh=s1ugvjlIbNshvGS9ZZbP8CjQoqKgu4xuN4hxoL5UeBw=; b=cFHKLgv5H3MMHF9LmvYRF5bXEdxiOTkYAr0aknI3BHW4VQyl0CNesUW3pmBkVNrRyWad7via6JEiwZdTWY8SkpfexbqSG6SGxwL6ldMIlDMYLpYBizC55vWLpZRPoFAxIAZpxyCDDSvJm+wdW991m3ngYU4r10x11Bt+kIccMcE= Received: from DESKTOP-5N7EMDA(mailfrom:ying.huang@linux.alibaba.com fp:SMTPD_---0WLysJwu_1734874386 cluster:ay36) by smtp.aliyun-inc.com; Sun, 22 Dec 2024 21:33:07 +0800 From: "Huang, Ying" To: Kairui Song Cc: linux-mm@kvack.org, Kairui Song , Andrew Morton , Chris Li , Hugh Dickins , Yosry Ahmed , Roman Gushchin , Shakeel Butt , Johannes Weiner , Barry Song , Michal Hocko , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/4] mm, memcontrol: avoid duplicated memcg enable check In-Reply-To: <20241218114633.85196-2-ryncsn@gmail.com> (Kairui Song's message of "Wed, 18 Dec 2024 19:46:30 +0800") References: <20241218114633.85196-1-ryncsn@gmail.com> <20241218114633.85196-2-ryncsn@gmail.com> Date: Sun, 22 Dec 2024 21:33:06 +0800 Message-ID: <87ed1zj10t.fsf@DESKTOP-5N7EMDA> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Stat-Signature: u1wcix4md667nqs5o139bogzuui98dyy X-Rspam-User: X-Rspamd-Queue-Id: 77CED40003 X-Rspamd-Server: rspam08 X-HE-Tag: 1734874365-15452 X-HE-Meta: U2FsdGVkX1+fCNtYY/b1qG1ZmtCiMoKei4nFMIknU/BznQD0WrLfrn9HNdcqG+X/dIZX1wFKV6z1MCE2T7FKDloNtFcLFBdtm+OjFFmRfg9ramaJ9Qw//vUPp9X9+XiW1uCvhHEDE/BJ2kaOE9MtJpLUup7kMRTDiWo3U+kRrNjadJ+y0wOvaFIU3cWbLvWJo6Hl9Lb8KvNbFNzSE1De3Rz6YAMh/Xk+SbecylUb8+YjXaf7NzEFbdgUjSl04eoTWf5tLkjt7jKaC5PFEn459I0FkE+kNT8EpKshajNDpf0mUGNTIDgEFjsAKM8DCmaY4d0Rgtyyho+bZQLeKgYnQnfrV56sv1uu9y3//4d5L+7s2IODS+NWJk86LJMoGMS6Ck4USKFtDjyyyYG+s3pr1TewwoXAF9gJeT0mZt2WsEQ9rSi07UJoSBs4Zx0trEyrUF6n7yAQ1j0+koSX0api4+aZk0WOSoM9OEUg3e1vPF6+UUrG3Rms91p7uFcCnCXSHF7YbkOL/MgQD7HAdG4qaWc635GyI8bPYUX4h6THqJloh8MGJOQ2dXFpLD/0MMIqM8BvqZCu/bs4kdIIc/Naehf+5aw2Q89FK8IAdmDd7tm1+zFalnOw2U5K06wF5y/KPpe4wQxC+p3PJYfC1EKoJUoP0h3KHW6Lbd7IFBUtJ6yL4ZpcdGj1a/4IQafMEEW0hDZiu39ljZA6djrHFCp6Txf/YrxfRC0goVTEH5bLkNUcqdhQHQId1VFbo5jze71tWH0Zrak5lZaE91pdTR1QdOcsxbSuKS5JjK/JC28Weieskiu40xkLvLkpePF44yjvT8YuWQ+FpAD+ntw0e5P8jQbpharSi4JSE76VoRqQi1bdTuaGX+3TnRjcc596j79cP4gqh2LSU3LBc1NzcI4Ln2s3+MOYbZYeQbLnDOTG7INlJWV1ROIYNly6NVDgAzxyk5fL6rJaReggiypSXKd gtrJp2Ib HP0/4WcA5O8lWND6YOXLs0musouj9xlFQwYoKAAAc8ZQ6wk1yjhbFXVRCzglpjACyG24gCV9iaS7k+DyVpwvlcANdl7BQ+4P/pIOfxItv3jj9lt4MNyA9JKCibr4d2yerpKmCM/LFGwNjVN8YpnQzsA+ID7aGufjpYDNqHYaMQXwR2ZJyEyp4+sKbux0/ilbHt6oEE2+N18SHFUNOm+CcNdycD1AY10LhCcovdJmSCG+IlOgYs8WYuXKhhPoByr5DIQMzJAvm+ykIu9cAuKFTpNIn/oltSz2ZzD9RadBAMBVeh0TtMZ/35QIm+g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, Kairui, Sorry for jumping in so late. Kairui Song writes: > From: Kairui Song > > mem_cgroup_uncharge_swap() includes a mem_cgroup_disabled() check, > so the caller doesn't need to check that. > > Signed-off-by: Kairui Song > Reviewed-by: Yosry Ahmed > Reviewed-by: Roman Gushchin > Acked-by: Shakeel Butt > Acked-by: Chris Li > --- > mm/memcontrol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 7b3503d12aaf..79900a486ed1 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -4609,7 +4609,7 @@ void mem_cgroup_swapin_uncharge_swap(swp_entry_t entry, unsigned int nr_pages) > * correspond 1:1 to page and swap slot lifetimes: we charge the > * page to memory here, and uncharge swap when the slot is freed. > */ > - if (!mem_cgroup_disabled() && do_memsw_account()) { > + if (do_memsw_account()) { > /* > * The swap entry might not get freed for a long time, > * let's not wait for it. The page already received a I take a look at memcontrol.c, it appears that almost all extern functions check mem_cgroup_disabled() as the first step. So I guess that this is a convention of memcontrol.c? And the benefit of the change is minimal. In contrast, if someone makes more changes to mem_cgroup_swapin_uncharge_swap() in the future, he may forget to add this back. So, it may be unnecessary to make the change? --- Best Regards, Huang, Ying