From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FA24C3DA6D for ; Fri, 23 May 2025 08:58:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3AF86B00CB; Fri, 23 May 2025 04:58:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EB486B00CF; Fri, 23 May 2025 04:58:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B3146B00D1; Fri, 23 May 2025 04:58:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 686C06B00CB for ; Fri, 23 May 2025 04:58:44 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 123481A1DDF for ; Fri, 23 May 2025 08:58:44 +0000 (UTC) X-FDA: 83473572168.19.D318F8E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id D82B7180004 for ; Fri, 23 May 2025 08:58:41 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=N62MAUSW; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of toke@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=toke@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747990722; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6J/RUYS6OBOPvuZyXgo5WgF2pNpessZJIoWwbAcSf0A=; b=H13yUrfEeb8GswuTYP3wP+uyp8Cf981mmnaPortFcb2+koBMHCJz62M5uZJaqa6jPdhO/j 8d0UH7JLHjJ0eR09Q4p+MRg+odYXg0WojIBn4rwm/YZwBgaE14PX48Qv4k3F5gGPhv1hJc uu4KaV0ahhue/lRGG4LeNg0TbqN9QTU= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=N62MAUSW; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of toke@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=toke@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747990722; a=rsa-sha256; cv=none; b=JOlozQxqssHEzaU90PvxU4MolqLZiPcgk1Jyr5DwPMSpzQ2CpZcmS+tl6gw0qlqZ7vgooY 3ku60qLLk9WB0E0DrCHxYnJa2JASK7GnoeP0ElogP6IRP1xoTyvF6eahcyNQ4gOtHBfZmc TThLZhYCqF5Sc+souzxz12kIF5qfbbw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747990721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6J/RUYS6OBOPvuZyXgo5WgF2pNpessZJIoWwbAcSf0A=; b=N62MAUSWPqMvB9zMaUDQUYlVbYDGBrEmdZc2fcaWsEhRSAPj0XjfRdLFMPFIEHQvoXyz5n OxDDHRTJDRqKaDM2Ax/cQeMjhGlHe7+N74gKmcDVwH3ontyxEotFaycuXqPXem9RUFZKPx xuGQNo0GdfCyLkqHpp/B1HFkA3UvS2k= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-E5jtmGGlNIWFcW-Hqje5XQ-1; Fri, 23 May 2025 04:58:39 -0400 X-MC-Unique: E5jtmGGlNIWFcW-Hqje5XQ-1 X-Mimecast-MFC-AGG-ID: E5jtmGGlNIWFcW-Hqje5XQ_1747990718 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-550d7bd9a7fso4990580e87.2 for ; Fri, 23 May 2025 01:58:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747990717; x=1748595517; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6J/RUYS6OBOPvuZyXgo5WgF2pNpessZJIoWwbAcSf0A=; b=H0MlIsOxllFsZdJvRurW6BFjZY90LQnIdzKSe8WAAFu39Fj/uPUqk4I3OxUcujuf+S b8cmOj179SOCQDv1KWgyDZSOqzthbCDnxM0MLH7LAC0kxQA7UNk0m5GStTs6DMdh7arv 4ZirFQxjv3iZBA8NphLcg+Tu7C7a3iWoFOFFWZTx7KZcPOBNy8KRWcCgR4YV32VSS+wO F4iyA6rGCNWUKIVaEDbHExI2qld9EBrXCZf4fhsmRriviJ1/+EH8BTfZYOAU5GZ6S4dk rk8OXjMbqPJv1cHPZbrgU5kzfqi0obkEWAu9mFvsE53bDNk+Inrgu3gs5bdSh37Nd9O5 yADg== X-Forwarded-Encrypted: i=1; AJvYcCU6QycIjRVT5fXQwlhUJUEjMNXRqF42EuLK5acTVfQLqqF4iPB6iRwTuXPFsqhTm5oNXMLsF6gXOg==@kvack.org X-Gm-Message-State: AOJu0YxEsbZk81fpHACwUNGa+OEhXhxZlwLCBlYcXtWWxJ1/8agoRysf 0vgzuTr8UZMwQhk8G1VmMdPJfnuAQXRzYLxrPpV0Ow/2ePb8U+IHH8HV173q6k86+RPMJrM5CC9 /EWYcuft2eVdQ1aJYxXUNOzdfAAyYM/loB+G6+5Yf+AaewaNhGVYd X-Gm-Gg: ASbGncs43gHZIn9mbtgKvZWoKdSfAaOSdkylgqrh0rzclS/ezuboKYPJw4yniqc956D Fzll4kF3/PrvQIyFhG70XbeQ2LQTPQ5c2Ti2Nurr95HKBwXOEW92LabhYm/NR0XrvIOdhon2gZx 1WdHVB5QSgu/aeolfvoMRVzkJc9mXMcS+f5B9Tk0ogiRpXmmor/BG2s6+xJlzm2QmWQ2lHOd3Oj AxnPxiFdIrYC6CeVW1xWHWYtWd+qEmZ1WpVcYf03g1vLZEbyWsMZdFgyLVb6BG+Oxifewcto0bI KX/7Wbar2sQATQV/8rQLiYUBa6aO9AsUQrKE X-Received: by 2002:a05:6512:3083:b0:552:31c:d27f with SMTP id 2adb3069b0e04-55216e18aa5mr550253e87.6.1747990717430; Fri, 23 May 2025 01:58:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGGupqC+46X0tt6Ygg6tbBTVVOo7BQlw5aLij8Bq0jPcx2TjqKILidIf2WS35eedcHMuDdsdg== X-Received: by 2002:a05:6512:3083:b0:552:31c:d27f with SMTP id 2adb3069b0e04-55216e18aa5mr550242e87.6.1747990716968; Fri, 23 May 2025 01:58:36 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-550e702e03dsm3786008e87.195.2025.05.23.01.58.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 May 2025 01:58:36 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id D7C101AA3B8A; Fri, 23 May 2025 10:58:33 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Byungchul Park , willy@infradead.org, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, almasrymina@google.com, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, asml.silence@gmail.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com Subject: Re: [PATCH 12/18] page_pool: use netmem APIs to access page->pp_magic in page_pool_page_is_pp() In-Reply-To: <20250523032609.16334-13-byungchul@sk.com> References: <20250523032609.16334-1-byungchul@sk.com> <20250523032609.16334-13-byungchul@sk.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Fri, 23 May 2025 10:58:33 +0200 Message-ID: <87ecwfn1om.fsf@toke.dk> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 9rvK0Js6CMwP3n0uRFiqnNoBiOJOFjzmYJXFQIw7wbQ_1747990718 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: D82B7180004 X-Stat-Signature: de6pfe1qzzyt7s7n6dbxoy5bjkqazjfn X-Rspam-User: X-HE-Tag: 1747990721-556947 X-HE-Meta: U2FsdGVkX19JVwuj3Ja1kWmt5SyJ82eri7bMuvJsGq4ggRrjfjmu5NpvukYvRfwZvJPIGxWL2dBcwHF2tbY3XrzqhQDTAIPypUQLZPwZOGfeybt4jYLdtmilmDIF5XJlM7Vw/kFsqvzsK2FKB/Wc19LBrKcL9fXBWI9QmgwMpt6ku4u4/8bghZU1r3/J4XW0mlIxUPHwBVwrmfqyRMZBR5G4mItLzpXjWG2CGc99+yY5ulJmIvcGkHPbmcxbkFFRjLjlmsiJgIvlIis04pLfD4PRcfH72r18XLoCt/T71tSpqjrukoC2BsIrE4FEBhm/UqSSkGiljO6q0YWcEp8HLtJUszpepyYYNCi2udHUrIs+zpsYPl4FQ/8p5Fy+D7/SdJlJru35Gf4r+Ch2ckGGXQsYKukEzxmE/OKZjiqCQ+UN6k6BeHo5MVzaUKJ7sd2I6QZI3RsI9jEO4SRcGJXEeTRB3gHu/VF7fAtnraJ+YOvHe/PJHjhR6uLJkb26cI1RnroGqwXNlaNg/Ab8G/u4tTCqRG7dW+m6TzfxnLLmdsBwSDgwpddTzZJd+osff6EqanmOh6hQZh9JD6gsznIPUevQKnLjOosXZujnJWPCBA9YT8HC/fJudghN/qRnby8dop14fSKwdr+PNPcA95ifIBxTKCgc4OHSVoxwlbaQ+Q9mKyKPXaD9y5tBssp7lBB2QKCWx7LMDYjndmhDPjiwvginhf8cnG7g8/9nFUzpU6sssQE0AbBbZJaEt+dyI5ZWYTOF1XaRyVxCwowniSdmcD468qrAusZH1IWXCZE8dHc5eqvO/7SRnSs6ki0OwfqVC7g8rPRIKJqoI9PcW2jG+tUzyuXcFGkpJZk6O5BERRgZW83ribIShrJwKQ/q0haFwr9PTkjNRaPiYEKBd0/SOdGYpfJaZcJJK0z6b+7I48KYTwbv+GPcpS0X/5qgAfknVDYGDx1iQiCsIz/G+dD mMihrrQY 5QRbcQUelveWDmvKrFDO00Y+/eXcjvt4AWSiqoFVP6DLoF1Ty2/ExCAEnq/KCaXrRId3FZhF8d1QzfQfioOO3jJqETq8f+JxsH2pUVuPGMpL54Rqzi1Wf74PRspHWtq+JhpBXh13kdDUcBsnFVo1SJcxdiF5hRGTcxW3JB/TEmzlEe1w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Byungchul Park writes: > To simplify struct page, the effort to seperate its own descriptor from > struct page is required and the work for page pool is on going. > > To achieve that, all the code should avoid accessing page pool members > of struct page directly, but use safe APIs for the purpose. > > Use netmem_is_pp() instead of directly accessing page->pp_magic in > page_pool_page_is_pp(). > > Signed-off-by: Byungchul Park > --- > include/linux/mm.h | 5 +---- > net/core/page_pool.c | 5 +++++ > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 8dc012e84033..3f7c80fb73ce 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -4312,10 +4312,7 @@ int arch_lock_shadow_stack_status(struct task_struct *t, unsigned long status); > #define PP_MAGIC_MASK ~(PP_DMA_INDEX_MASK | 0x3UL) > > #ifdef CONFIG_PAGE_POOL > -static inline bool page_pool_page_is_pp(struct page *page) > -{ > - return (page->pp_magic & PP_MAGIC_MASK) == PP_SIGNATURE; > -} > +bool page_pool_page_is_pp(struct page *page); Here you're turning an inline function into a function call, which has performance implications. Please try to avoid that. -Toke