From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13B23C77B7C for ; Tue, 24 Jun 2025 04:16:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 437866B00A5; Tue, 24 Jun 2025 00:16:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E75F6B00A6; Tue, 24 Jun 2025 00:16:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D7036B00AE; Tue, 24 Jun 2025 00:16:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1DACF6B00A5 for ; Tue, 24 Jun 2025 00:16:19 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 934D3BF4D0 for ; Tue, 24 Jun 2025 04:16:18 +0000 (UTC) X-FDA: 83588982036.13.D1EABDA Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by imf03.hostedemail.com (Postfix) with ESMTP id 584C32000F for ; Tue, 24 Jun 2025 04:16:14 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=et1bFGaK; spf=pass (imf03.hostedemail.com: domain of ying.huang@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=ying.huang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750738576; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rax2iaNWOHCKSTHeRONdpsloXVAQJACyDqlDlmBHKYA=; b=AGri0ZNgjQYDUL9ybeeUlEqWCz8IoUvuh1M16bpllWl9efs8ta/WISD6LUFx2l09lBfQWO 9CeQdumPmaG+R0sr/zz8kzb2WLdyIGVEgXOKgriqmPZ6TuAdKfrwwutiGH59n9fKreOBXP VIfTJCpPvlPlCM94Txr+J7W8QXrwCR0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=et1bFGaK; spf=pass (imf03.hostedemail.com: domain of ying.huang@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=ying.huang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750738576; a=rsa-sha256; cv=none; b=XAw8jawKEkGq6x+N19zjoLPn9dJFgjZsvN1GhDmQzeNBFX81F0TxPtnScQCjullUPTWlCM nCrujbrJpD9F6HqxhZ7+msJGU9wVd54We8RGYSlNWxL3hH2gyUuAdC+ivUC8GARpxIpsVH l4n/8RgthxzzTWBpZV2j8gGYAV93vWk= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1750738572; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; bh=rax2iaNWOHCKSTHeRONdpsloXVAQJACyDqlDlmBHKYA=; b=et1bFGaK6G62sF9T0oJu9pCB0aojHzuMnkWvIWI8E2n40RVzP9r0L4cZc5lBZ5QLR4jpO5DibPx/ps5AUqTz36jbnPpF6hpJ4PPBGipddk4GWOoWshaf7DV+R7bM5m0gFb02rx0IfQeVxZ8AH3cKD5e4NesOuqA+da+SXo3wm8M= Received: from DESKTOP-5N7EMDA(mailfrom:ying.huang@linux.alibaba.com fp:SMTPD_---0Wef2ct8_1750738566 cluster:ay36) by smtp.aliyun-inc.com; Tue, 24 Jun 2025 12:16:08 +0800 From: "Huang, Ying" To: Shivank Garg Cc: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [RFC PATCH v8 5/7] KVM: guest_memfd: Add slab-allocated inode cache In-Reply-To: <20250618112935.7629-6-shivankg@amd.com> (Shivank Garg's message of "Wed, 18 Jun 2025 11:29:33 +0000") References: <20250618112935.7629-1-shivankg@amd.com> <20250618112935.7629-6-shivankg@amd.com> Date: Tue, 24 Jun 2025 12:16:06 +0800 Message-ID: <87ecv9ojuh.fsf@DESKTOP-5N7EMDA> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 584C32000F X-Stat-Signature: stwnkyj56g57ckk3zidnzanmk87i5iy7 X-HE-Tag: 1750738574-670592 X-HE-Meta: U2FsdGVkX19vwEqeZeM7bDjEoy22ZTJFSMSODCiV9C/dewdV7KSYZBW0XcpIwGpXxFluogMJTcV+wcpgC5TlW2c69cBVr8TWr+7lIMWDNL6ZLLjjXsW7Nd6KfpkHB5YdZ89D9sa82+W/D6OM0jpsmuG4/ZlSMYtfwMZSxAKCP2a0HAtg/Bx3F9ZbEVeFnr9JFMQ7/fCe+e2wowmQhb1iM0FXoO0BD5um72pG/H1i4tsp+2oZGEv5VN6RSvzJQIFcUmQ3B8qMdHgAcsZUzHQB7eBmFex5pUDuHkGbikPAACbgjv0irp7EYW7QWSk98nJZAWjcXGqkyZMzLqIJvg9yHBr9bIXo+mmFTkpkWSQT1ZgjXL4kyawgUeXtCsoqS6YSQ3XJxDCHpB2VfN3x6++5P022z+4VQK0ghXbzCS3Lz3kA7rjswrwYaUU/mKHFUfMTQ5UQY+iHB6Ysk6evoxSoVg4FSwniSsgUa5lu45Voq559HixOvPTKMl6mGwFbEJL6Md7KJsKoxMA9jjABdPCThaocteoxWBLipuVNSHCcCbtl+uOJjUAxXYFr1OQCjlQtvGgmO/4FkT4mpovVDyVtmQ/3RZVk74Os2SrMBOIkRfkQToUaaQlaVYjtOutfoUkirVVUXr2OJbC8bGZdyfc+1KLYphqti2o1ktUW2/Eb1C34LDRb7+4j0UjAXgMps3JbhvhZyI0Aro2NHrnse0THH84gNSEdDNHGNm1TZfoP3Hk2SCtxZHV1OUPpkDsuMabtMQR793t6uIFF7Pugz2pqJ192jO3qP96HOel3CXUJRSMN1R1Hk8d0kVaIjhUETs0H2hz5Nw0NMw7piS5T9bnnP4Fj+v9ekefjr0Xh6VkeSPb8KB36E6eEedHoCIDc1NMIJLHjtz/h3NlRAd9loU9OXqWWgndZSWj0ODjg4AEctj9Ql7Surw9/MbiI12e7UwfoIk3i042/Y4cpQ6dFl8C QIyWlPmE znNR2aJNrsnRisMBSbCEKuHcLjiUEdm1X8zuCQb6GGGa5bmc4NeKZEyI1t3+lChF7lI9BHEc/CBRswFMgr2IHJRY4GNYGOxrXuIZu/NAnMnx52Hj+E7YQU1qd+YHAvo0qHzhttyLP5HxUzik0sateAAv+gtUo5SubQWtr4dv1Q33Q3gszy5qe83mJz3eKAN15h0qWBR70yu6jdySXs/WQIyLzbrZ9kqOwQ59GNvDCGc+rff1CVRdHzMwNbAUhkNOxkOjdgwklQOuW9BGwqxKbliyZ2Ex92p3gq+2Jr/apaxYzIzkMlay9glLAAOEhvfiQ8hYG6lS6dd+dkD6c9Y24I5tWBs/qUfG7Ga22a3ayIRnEvBbOVQhpGFv4p5FWvTJ+k2BurmEZ222948GeZ0VdBp9lL8IbyyI0PolWEL9lPq8teZs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Shivank Garg writes: > Add dedicated inode structure (kvm_gmem_inode_info) and slab-allocated > inode cache for guest memory backing, similar to how shmem handles inodes. > > This adds the necessary allocation/destruction functions and prepares > for upcoming guest_memfd NUMA policy support changes. > > Signed-off-by: Shivank Garg > --- > virt/kvm/guest_memfd.c | 51 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 51 insertions(+) > > diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c > index 159df462d193..5a1ce6f5e287 100644 > --- a/virt/kvm/guest_memfd.c > +++ b/virt/kvm/guest_memfd.c > @@ -17,6 +17,15 @@ struct kvm_gmem { > struct list_head entry; > }; > > +struct kvm_gmem_inode_info { > + struct inode vfs_inode; > +}; > + > +static inline struct kvm_gmem_inode_info *KVM_GMEM_I(struct inode *inode) > +{ > + return container_of(inode, struct kvm_gmem_inode_info, vfs_inode); > +} > + > /** > * folio_file_pfn - like folio_file_page, but return a pfn. > * @folio: The folio which contains this index. > @@ -392,8 +401,33 @@ static struct file_operations kvm_gmem_fops = { > .fallocate = kvm_gmem_fallocate, > }; > > +static struct kmem_cache *kvm_gmem_inode_cachep; > + > +static struct inode *kvm_gmem_alloc_inode(struct super_block *sb) > +{ > + struct kvm_gmem_inode_info *info; > + > + info = alloc_inode_sb(sb, kvm_gmem_inode_cachep, GFP_KERNEL); > + if (!info) > + return NULL; > + > + return &info->vfs_inode; > +} > + > +static void kvm_gmem_destroy_inode(struct inode *inode) > +{ > +} > + > +static void kvm_gmem_free_inode(struct inode *inode) > +{ > + kmem_cache_free(kvm_gmem_inode_cachep, KVM_GMEM_I(inode)); > +} > + > static const struct super_operations kvm_gmem_super_operations = { > .statfs = simple_statfs, > + .alloc_inode = kvm_gmem_alloc_inode, > + .destroy_inode = kvm_gmem_destroy_inode, > + .free_inode = kvm_gmem_free_inode, > }; > > static int kvm_gmem_init_fs_context(struct fs_context *fc) > @@ -426,10 +460,26 @@ static int kvm_gmem_init_mount(void) > return 0; > } > > +static void kvm_gmem_init_inode(void *foo) > +{ > + struct kvm_gmem_inode_info *info = foo; > + > + inode_init_once(&info->vfs_inode); > +} > + > +static void kvm_gmem_init_inodecache(void) > +{ > + kvm_gmem_inode_cachep = kmem_cache_create("kvm_gmem_inode_cache", > + sizeof(struct kvm_gmem_inode_info), > + 0, SLAB_ACCOUNT, > + kvm_gmem_init_inode); Check the return value? And, I'm not a big fan of (logically) one line function encapsulation. > +} > + > int kvm_gmem_init(struct module *module) > { > kvm_gmem_fops.owner = module; > > + kvm_gmem_init_inodecache(); > return kvm_gmem_init_mount(); kmem_cache_destroy(kvm_gmem_inode_cachep) if kvm_gmem_init_mount() return with error? > } > > @@ -437,6 +487,7 @@ void kvm_gmem_exit(void) > { > kern_unmount(kvm_gmem_mnt); > kvm_gmem_mnt = NULL; > + kmem_cache_destroy(kvm_gmem_inode_cachep); > } > > static int kvm_gmem_migrate_folio(struct address_space *mapping, --- Best Regards, Huang, Ying