From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3DCBC6FA82 for ; Tue, 13 Sep 2022 08:57:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38C556B0072; Tue, 13 Sep 2022 04:57:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 313AC8D0002; Tue, 13 Sep 2022 04:57:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B4858D0001; Tue, 13 Sep 2022 04:57:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 086106B0072 for ; Tue, 13 Sep 2022 04:57:43 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CA248160CAA for ; Tue, 13 Sep 2022 08:57:42 +0000 (UTC) X-FDA: 79906459164.11.1EA646B Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf17.hostedemail.com (Postfix) with ESMTP id 58BEC40095 for ; Tue, 13 Sep 2022 08:57:42 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1EB281063; Tue, 13 Sep 2022 01:57:48 -0700 (PDT) Received: from [10.162.42.9] (unknown [10.162.42.9]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9C5903F73B; Tue, 13 Sep 2022 01:57:39 -0700 (PDT) Message-ID: <87e3cb9c-c401-f18b-8d6a-dd63ed6c9e17@arm.com> Date: Tue, 13 Sep 2022 14:27:36 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 10/16] mm, memory_hotplug: remove obsolete generic_free_nodedata() Content-Language: en-US To: Miaohe Lin , akpm@linux-foundation.org Cc: david@redhat.com, osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220909092451.24883-1-linmiaohe@huawei.com> <20220909092451.24883-11-linmiaohe@huawei.com> From: Anshuman Khandual In-Reply-To: <20220909092451.24883-11-linmiaohe@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663059462; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hvjDOHvMa93xyqMoqxpU9uSeW9BTszwsi8ddDdMAMjk=; b=7XD2IZ16H9W1nSUoR38XJMBrVoRiGHGJn3udQzinIK2eiF/DkOsVtUKVZJgtsdpUOgBALg Kkhxx/Xuj81/X0xmQ7xnT/PKUZ8S7GLkbfa6iry5wuWJs+fpZVUzjDApIYtK0fDLVWNzOJ 7p8/2Ef91DTMDFs/35ydllgkHUtrGYU= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663059462; a=rsa-sha256; cv=none; b=k4rahs2nM3yj5UOxRhbgS35FkUHh+MZ+d+EvUU2fkEwkTUWucfA0ZMtJund0+ajpr49aby qu8LS02EDCPD6qcANaoz21h3xc15+MZ9AW4QNIe0OjrCNXcNhTEEpwF1BCNDhHamqX0S9Y i2FwSHz4uxMgI8FYQnMniUspSvvUZO0= X-Rspam-User: X-Stat-Signature: w5z1d7ho61e5o3sxm46dr5w3yggnsmpo X-Rspamd-Queue-Id: 58BEC40095 Authentication-Results: imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com X-Rspamd-Server: rspam08 X-HE-Tag: 1663059462-454497 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/9/22 14:54, Miaohe Lin wrote: > Commit 390511e1476e ("mm, memory_hotplug: drop arch_free_nodedata") > drops the last caller of generic_free_nodedata(). Remove it too. > > Signed-off-by: Miaohe Lin Reviewed-by: Anshuman Khandual > --- > include/linux/memory_hotplug.h | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h > index 51052969dbfe..9fcbf5706595 100644 > --- a/include/linux/memory_hotplug.h > +++ b/include/linux/memory_hotplug.h > @@ -43,11 +43,6 @@ extern void arch_refresh_nodedata(int nid, pg_data_t *pgdat); > ({ \ > memblock_alloc(sizeof(*pgdat), SMP_CACHE_BYTES); \ > }) > -/* > - * This definition is just for error path in node hotadd. > - * For node hotremove, we have to replace this. > - */ > -#define generic_free_nodedata(pgdat) kfree(pgdat) > > extern pg_data_t *node_data[]; > static inline void arch_refresh_nodedata(int nid, pg_data_t *pgdat) > @@ -63,9 +58,6 @@ static inline pg_data_t *generic_alloc_nodedata(int nid) > BUG(); > return NULL; > } > -static inline void generic_free_nodedata(pg_data_t *pgdat) > -{ > -} > static inline void arch_refresh_nodedata(int nid, pg_data_t *pgdat) > { > }