From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06455E95A65 for ; Sat, 7 Oct 2023 20:07:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D75E8D0005; Sat, 7 Oct 2023 16:07:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 387A88D0001; Sat, 7 Oct 2023 16:07:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2760E8D0005; Sat, 7 Oct 2023 16:07:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 18D768D0001 for ; Sat, 7 Oct 2023 16:07:54 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D35671401E3 for ; Sat, 7 Oct 2023 20:07:53 +0000 (UTC) X-FDA: 81319751226.27.0D4CADA Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by imf25.hostedemail.com (Postfix) with ESMTP id 0720FA001B for ; Sat, 7 Oct 2023 20:07:51 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gDAGy60U; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696709272; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=frrbQG1KV2zBsqrzA92ZI0bBTicwEVY0Ipaf/Vo55cE=; b=pYfJYR6RTcREzgCL7u8m8O9K0DXvwhBy6yJ+I3aqI37VXtSWPtyN08AJ38f5hl16p4hodA zwMuf+QXAs+8HDtJnsM3xDGl0V8SW7jXMFWurFj7Q0MqryhyrcteEUFurKMdbuCUgwM0cP GQ2uBQ660Lr5PkD++Z9seV0cdKXb5X0= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gDAGy60U; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696709272; a=rsa-sha256; cv=none; b=BIFtbtEVIwCTAb/vVdaNqx5o8JgJyPylgh6wPqrLzzFYXOCiLgviGnDN6ngi0oTC81D512 1Y2hqd/i+EmiJ3O5x3/K4+TE+/c/Ayw07ycCCgR7q9dz4uAjQQ/SClPHT38rLvkvHYtOcb PceUK+2oODa5ybEBkLLdxQTpQxRHZXg= Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-32487efc319so3112726f8f.1 for ; Sat, 07 Oct 2023 13:07:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696709270; x=1697314070; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=frrbQG1KV2zBsqrzA92ZI0bBTicwEVY0Ipaf/Vo55cE=; b=gDAGy60UFnM7jZ/GVTf56QYE0QF0+Wb3Tegfbwe8p/aWjM225pd8tjIa6tIRBB4Mgn dXU4SF+M4fmGVK6mPBeppyycbJPbsuD/x8OKETDJ+0/cS5AGeiXLYGct3WlHGHmz6Lse 5aMFfGiwwBKF2OrB9trjvCEKG1WxZQ1yjctX/WMdBHTeANqm63BjC71phcAYDP4LoJ7N Wz8ACCtYUI77TeScBnrBRM+Stc/zvg4WhBQpCjPPsy0wgdXLzl6pCQojOoadVQ3id/Z8 R6eOhNPjNjbErCxi/561CNtwSPkXyLb3rgvwpV8mYcd/T4NwzcK6GK9Jmxy1/GbCteE5 WPJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696709270; x=1697314070; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=frrbQG1KV2zBsqrzA92ZI0bBTicwEVY0Ipaf/Vo55cE=; b=xEay5OSXgxK1PZrHVvX0GEhF+4KIIP39iLpYd0GylvtmNxM1TCk9m2ZvWax+7ZPRAo GR/WsjMpnf01s9MUW3pXxAaMNWyAWDQOP+uxz6U47cFEpVIHhVZMrdGKy9S/pVTaVEYC tkWWdf4WsigRM9lvcf9IEykE6+XhnKkUswt9lubExbxDwntdHeesrEKKFtdrKvEqTQjb 8aEfkv/RkF2nB6mcOsKUYeMzuwe2PTXPLldfFX/SIce5jpL+0q8JUgyGo9kMhIrYIe8n /WW/Vqt+iAf9ikfz4CbAYb3CeHXA4Z2x2ZDNCZKxpiN8j2RMjOdMkWlHpfSDSNCHtlxR x8WA== X-Gm-Message-State: AOJu0Yy8k1S+rgmZhy7jeAsPm2BufeZjmgYcop+0UYD8HFyuGa2FEfxL vuLYVafFUNcdwwgi2e5v34s= X-Google-Smtp-Source: AGHT+IGWQk6Kxejzx5y3Pu20Y6dY8/NNiXN6Z/O1O3DHsuExWlc4MtA1UfAL4KQLOm0NSOgL9MlAmw== X-Received: by 2002:adf:cd0a:0:b0:320:5f:c249 with SMTP id w10-20020adfcd0a000000b00320005fc249mr9265591wrm.30.1696709270256; Sat, 07 Oct 2023 13:07:50 -0700 (PDT) Received: from localhost ([2a00:23c5:dc8c:8701:1663:9a35:5a7b:1d76]) by smtp.gmail.com with ESMTPSA id o14-20020a5d4a8e000000b003197b85bad2sm5052534wrq.79.2023.10.07.13.07.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Oct 2023 13:07:48 -0700 (PDT) Date: Sat, 7 Oct 2023 21:07:48 +0100 From: Lorenzo Stoakes To: kernel test robot Cc: oe-lkp@lists.linux.dev, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Matthew Wilcox , Mike Kravetz , Muchun Song , Alexander Viro , Christian Brauner , Andy Lutomirski , linux-fsdevel@vger.kernel.org, Jan Kara , Hugh Dickins Subject: Re: [PATCH v2 3/3] mm: perform the mapping_map_writable() check after call_mmap() Message-ID: <87e0d5f2-7d64-41ec-8a7c-920d5d1ca947@lucifer.local> References: <6f3aea05c9cc46094b029cbd1138d163c1ae7f9d.1682890156.git.lstoakes@gmail.com> <202305161044.bba89e76-yujie.liu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202305161044.bba89e76-yujie.liu@intel.com> X-Rspamd-Queue-Id: 0720FA001B X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: ix6qw18bpoum6s9pommnguwk4aaymqjp X-HE-Tag: 1696709271-115231 X-HE-Meta: U2FsdGVkX180UZi7ILgAVFnwL5E+VkP7s28ON2hkJm9sm1N773hDYNd7t7Ns09uvJIfaj8X0wq4hCAvJ7oD0AOxQP7o07IadsgStBA/l8YuzwXoCVJ9Mrtu6NuLq/hWyICxYiinDIzv5BRzx58SFUhMa8U4Ixqlm5RVeHCBFvSQAzWwzLQ/X6u2st+SIyDhwqSTZ3smgLOCHtiphJIC6pinL5IKsyJ6IGr06BBn2B1gId2PHDju8buzf8pyhajM3NtQmgAUDrrAvPPKGK4EmtzUnceAvHjBhv13pJ97TC5fBbc6Lu5zUHkmXQb7sngnd6gGX9osqVPZYSD8QjGtXI8dT04z4XEj4XX6kt8xMKeqjvb5RgnGhYpKB36xyjZTT3RMO6fuRpqNASaAIyQ2LmBSq3mxHlzhezT70ukjvBOH/B+cJzbKGD3tj3PWMNoV9PJSc5ke3r3WRXnK3u3xj8ZPmmK1PRVTdkd84gtZZGROo4UR0A/wSv9YLshsck1cEAmsQp8YBINEf5BvrkO7tVVLW1DUlP+qzsOaoRSRVTm5Ndg8v3vX++llu86qZEUfnBi/MPp3TxDXzzFhT6pyc3oiaoKHQfBhw6nY2l4n+q+CQUzkI8RFtqUaVyvFRQxKY7WFYd7PUC0v6Eko400G11ujI1UCq2HbIOUsXlLSv5Cxv6anHJNbYo0DyKUboiIbApgrc6Py0H93XkEy8iAh+wgLvxMYyeMbXlMlcfGH9h1WSRZklKu5cEiRbRw4huAvhel3M6DJKGCX7tUg8omoY+nMBU+WXLU3/BEBWlfckD3KSE39jVTj6r7mGvvXDNZnc9sKgH9d5072pP7A8/tYtrDHWH5TLyBY4PtPDhJ5T0QxeBsoMlXL4qkr2JVXL9zyNiu0z7alAStHTN/t39u7jrII5jjp/bU0sePPE2KUhI5rbarWCoQsgUIJ3VcpqR1RVyK+nj0cBIbcMT8VZuk2 MCIKjQS4 WQcSwZvemTwSMXba70ebnf4bEJHgbax8GY0YyZBgU5OPYhv2vXEZKiDNK3FQZ3zSEsjCO0w7ZX/N3g++1TR2+xkfLfpHabwqHr2k6uIoSjEaB1eT8vLiFitw7u2IIqQplop9VxX/xr+CQ3JxZJ4EXo4hPr8Hh5cKUMAFnVH5dveOxNQbViaw4E0phsCJniRtktBiGob8SbdL1J+PC3zmmnqOjN818jX+Z5dbyLrnA7xKpjvMsLk6FjTK+DHaKkSfTIVImjEtf3PWa528khtzVv4h7JnfiQoj13xFNFX45CQ8ZmwTZYNUlYvYFchUNFOnDyLqZPqlOPtLFh10zK/olJpy+5TscB4dtj9hgPuFHQ2NF4uOb+WJWQuuldV2QjelEGO0heE8IG2CqTEFh0m5sGp1gGsc7w0wFVjzshDCpFRJ/T104lrU//clX5wPItartN0CbQUQFzLhroVyzoYdb6e98NRbMT600ITnw38Y/ka6HnMA66Ekdb24JdyQbaJ9yqH+5biXQwVVt4gONuxoVaE8Gpp1KjJGqX6KX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 16, 2023 at 01:52:06PM +0800, kernel test robot wrote: > Hello, > > kernel test robot noticed "assertion_failure" on: > > commit: a0e22a91f487957346732c6613eb6bd1b7c72ab1 ("[PATCH v2 3/3] mm: perform the mapping_map_writable() check after call_mmap()") > url: https://github.com/intel-lab-lkp/linux/commits/Lorenzo-Stoakes/mm-drop-the-assumption-that-VM_SHARED-always-implies-writable/20230501-062815 > base: https://git.kernel.org/cgit/linux/kernel/git/akpm/mm.git mm-everything > patch link: https://lore.kernel.org/all/6f3aea05c9cc46094b029cbd1138d163c1ae7f9d.1682890156.git.lstoakes@gmail.com/ > patch subject: [PATCH v2 3/3] mm: perform the mapping_map_writable() check after call_mmap() > > in testcase: igt > version: igt-x86_64-9e9cd7e6-1_20230506 > with following parameters: > > group: group-11 > > compiler: gcc-11 > test machine: 20 threads 1 sockets (Commet Lake) with 16G memory > > (please refer to attached dmesg/kmsg for entire log/backtrace) > > > If you fix the issue, kindly add following tag > | Reported-by: kernel test robot > | Link: https://lore.kernel.org/oe-lkp/202305161044.bba89e76-yujie.liu@intel.com > > > 2023-05-11 12:29:38 build/tests/gem_mmap_gtt --run-subtest basic-copy > IGT-Version: 1.27.1-g9e9cd7e6 (x86_64) (Linux: 6.3.0-10673-ga0e22a91f487 x86_64) > Starting subtest: basic-copy > (gem_mmap_gtt:1138) i915/gem_mman-CRITICAL: Test assertion failure function gem_mmap__gtt, file ../lib/i915/gem_mman.c:146: > (gem_mmap_gtt:1138) i915/gem_mman-CRITICAL: Failed assertion: ptr > (gem_mmap_gtt:1138) i915/gem_mman-CRITICAL: Last errno: 1, Operation not permitted > Subtest basic-copy failed. [snip] I don't have the hardware to test this (the repro steps don't work and manually running the test indicates the actual hardware is required) but I suspect it's a result of i915_gem_mmap() somehow causing mapping_unmap_writable() to be invoked, which sets mapping->i_mmap_writable negative, and thus the check after call_mmap() is performed reports the error. In v3 I will change this to continue to mark the file writable before invoking call_mmap() which should fix this issue.