From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 306A6D41D4D for ; Tue, 12 Nov 2024 03:20:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 780036B0089; Mon, 11 Nov 2024 22:20:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 72F366B00A2; Mon, 11 Nov 2024 22:20:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D2246B00CC; Mon, 11 Nov 2024 22:20:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3CE476B0089 for ; Mon, 11 Nov 2024 22:20:01 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id CDC7814030E for ; Tue, 12 Nov 2024 03:20:00 +0000 (UTC) X-FDA: 82775987406.25.EA644EF Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by imf02.hostedemail.com (Postfix) with ESMTP id AC30C80011 for ; Tue, 12 Nov 2024 03:18:38 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=q2E4YcB6; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf02.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731381537; a=rsa-sha256; cv=none; b=LNQmyU0a1THQQ6dUrZPzlPPuynWRXfdcS7s05h9VwdD/ocT9wvQxfl4WYHXBa/uIgrXw0d OgOeC0S2jDeSD70gysl2+WXU2/zSiCCumvFK/J/eXchBveLTP0zci1r7Zfw4uSJOe69qK8 hFSDvOY50cz0ZI+PXdxmWAi0B6JCCHE= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=q2E4YcB6; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf02.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731381537; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vAs1rV77DkI2iKDI266dN+In2P7tHRg+caJMvkuicwo=; b=coZzVIgl9jddJ5BKKh+6BvlMPOTunYB2GnnN+/h7rUFYvqqrlwI8QR8kstimMPKF6a2J2j OaR7E1Ky/XDwmUoM3xdIA1vZA0smpsHBKnbLczXU+ce1Uqnq7Kq6Mol4AYLYGqxjod0TQ1 TV1EUJUKUDWLV0FBOIGmDGe+On50kC4= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1731381593; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=vAs1rV77DkI2iKDI266dN+In2P7tHRg+caJMvkuicwo=; b=q2E4YcB6AFPKouqq5MU4YBdfnl+C1YwFciMChKeabH3YbejT0QaawoIiCGUZltU67GvLZX6x0PDUVWunqGGLbSbO+KUYod7FMgfwpGB4B75PXBmM7giJ8cILhIx4mVrisYHJJO9F8llFuZ3+CDr0bhyA8E1ut4ivzGjYVg1hNHA= Received: from 30.74.144.120(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WJFQ5jo_1731381590 cluster:ay36) by smtp.aliyun-inc.com; Tue, 12 Nov 2024 11:19:51 +0800 Message-ID: <87df7d30-6ef1-49d4-9a94-ce78e0ffc5af@linux.alibaba.com> Date: Tue, 12 Nov 2024 11:19:49 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/4] Support large folios for tmpfs To: David Hildenbrand , akpm@linux-foundation.org, hughd@google.com Cc: willy@infradead.org, wangkefeng.wang@huawei.com, 21cnbao@gmail.com, ryan.roberts@arm.com, ioworker0@gmail.com, da.gomez@samsung.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <3d49fbf8-866f-485b-b7fa-a89bbfb3cd7c@redhat.com> From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: AC30C80011 X-Rspamd-Server: rspam01 X-Stat-Signature: dpf9knnuft1r658jtg4pgy616ozc4yb9 X-HE-Tag: 1731381518-443558 X-HE-Meta: U2FsdGVkX1+1sskFndttQKYilEdov+Jmwmo2KwQ4wDr2OE/QyqqiNGR08oo11E/kwge86v97rHmUhvJs8Ru4Q66TA9knrcjlhTyQRZOEpZ++ql156oJH3fCK3ATfPdQEY35yVF59IdOVVEUR+CPHijnfhW8tmyaoIHhj/0yrejujM94VX8aWIhKKQ0qeSicbo5EB5stigMveO6uCNiVje1RQt/IiFzr6MvPgJ1N59g5LZXDYglU23pvy8KJ4oK7HVC/qBCzV2gshImi2Vor/wN4OWoxZDTky5M46cKcSapK9DawMJV1VRLGd8ph0Nvs7zE+ArUurn0Z54H7D3h1phO0GYD0ar7D0y6p2H4pZnPkcMPqM4DwfJhWVWggf/QxVNgHR1HwkBg6Q6VBWQCKEe6qqtpnrobYwKthnARW05ji+79fuX6ouNamyLg9JBc7lpBu6fyiAyEVlF6zAar07P7Hbi49++d1Al+clR9lcwyuearuhfcIocdcYqu5pDvgzNR6uC0VyqRNX5TKh6kaAKYF3VkQdAmfMiCxGgUdbLrIOzLVDwq1PTteoXXVkECrTOsNm8EchIPvRQvaw7bMJXyx/86tT4Rm/UgYLB/MwI85v/xo551FenqLZkGF5jFb8HhOjQp4coJc6rjW1D0iLSIcaLZlaX0Lp7aXoPzAoRDYD3mkhDcjTF7gSWfCICFMEKfu/C2hQ/nVj/E5Bm3VmpJzWyMAo0jIJvosil2p7qcEnPruMeKVspEMBgw1Hwu1gstfadLBp+XaE3xcB1ktvjiDZjLHcag7VNZg2Is2T3qm2Kox7eXuUP38BYVgA6Xv+t38a+2KWEMwqU6oQNmqn1VhUWh+v+DQf2Vwu4QY/dt9u9v10WKH+mFCkELOJoxr2hAVeeDczWkyfmNKupu+O67tdF7LdEi2xuAs37lMwy4mQqwLvFanLwIp9dVNkhUn6fbI2OPO5gyQA5zhHYGy aiKPHS5c E/BbZckEwEwfS9VkcNMgfKFD8JCMVvdl/QY2BaiIteSMu4/Alpvm8E2bzB0zymoaySwgdTe1x7fFgZ6V1YuvEzWTejzxq25rZIxsAKHBmskXiMcLAZLm8QpYixGdVk/vkxJ4kJGpNGkTlBMLR2zF9RbWSw/hW9euJa6c8nw2XHxISKSKn/OMQh+pAsknGNaDAtKvyFUvKaMpG+x8rIYcWhMaJD76Dvgle6vO6DgXH+LPUxStdn7r2LgN2/EARwQtn05Ar X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/11/12 03:47, David Hildenbrand wrote: > On 09.11.24 08:12, Baolin Wang wrote: >> >> >> On 2024/11/8 23:30, David Hildenbrand wrote: >>> On 08.11.24 05:12, Baolin Wang wrote: >>>> Traditionally, tmpfs only supported PMD-sized huge folios. However >>>> nowadays >>>> with other file systems supporting any sized large folios, and >>>> extending >>>> anonymous to support mTHP, we should not restrict tmpfs to allocating >>>> only >>>> PMD-sized huge folios, making it more special. Instead, we should allow >>>> tmpfs can allocate any sized large folios. >>>> >>>> Considering that tmpfs already has the 'huge=' option to control the >>>> huge >>>> folios allocation, we can extend the 'huge=' option to allow any sized >>>> huge >>>> folios. The semantics of the 'huge=' mount option are: >>>> >>>> huge=never: no any sized huge folios >>>> huge=always: any sized huge folios >>>> huge=within_size: like 'always' but respect the i_size >>>> huge=advise: like 'always' if requested with fadvise()/madvise() >>>> >>>> Note: for tmpfs mmap() faults, due to the lack of a write size hint, >>>> still >>>> allocate the PMD-sized huge folios if huge=always/within_size/advise >>>> is set. >>> >>> So, no fallback to smaller sizes for now in case we fail to allocate a >>> PMD one? Of course, this can be added later fairly easily. >> >> Right. I have no strong preference on this. If no one objects, I can add >> a fallback to smaller large folios if the PMD sized allocation fails in >> the next version. > > I'm fine with a staged approach, to perform this change separately. Sure. >>>> Moreover, the 'deny' and 'force' testing options controlled by >>>> '/sys/kernel/mm/transparent_hugepage/shmem_enabled', still retain the >>>> same >>>> semantics. The 'deny' can disable any sized large folios for tmpfs, >>>> while >>>> the 'force' can enable PMD sized large folios for tmpfs. >>>> >>>> Any comments and suggestions are appreciated. Thanks. >>>> >>>> Hi David, >>>> I did not add a new Kconfig option to control the default behavior of >>>> 'huge=' >>>> in the current version. I have not changed the default behavior at this >>>> time, and let's see if there is a need for this. >>> >>> Likely we want to change the default at some point so people might get a >>> benefit in more scenarios automatically. But I did not investigate how >>> /tmp is mapped as default by Fedora, for example. >> >> Personally, adding a cmdline to change the default value might be more >> useful than the Kconfig. Anyway, I still want to investigate if there is >> a real need. > > Likely both will be reasonable to have. > > FWIW, "systemctl cat tmp.mount" on a Fedora40 system tells me > "Options=mode=1777,strictatime,nosuid,nodev,size=50%%,nr_inodes=1m" > > To be precise: > > $ grep tmpfs /etc/mtab > vendorfw /usr/lib/firmware/vendor tmpfs rw,relatime,mode=755,inode64 0 0 > devtmpfs /dev devtmpfs > rw,nosuid,size=4096k,nr_inodes=4063361,mode=755,inode64 0 0 > tmpfs /dev/shm tmpfs rw,nosuid,nodev,inode64 0 0 > tmpfs /run tmpfs > rw,nosuid,nodev,size=6511156k,nr_inodes=819200,mode=755,inode64 0 0 > tmpfs /tmp tmpfs > rw,nosuid,nodev,size=16277892k,nr_inodes=1048576,inode64 0 0 > tmpfs /run/user/100813 tmpfs > rw,nosuid,nodev,relatime,size=3255576k,nr_inodes=813894,mode=700,uid=100813,gid=100813,inode64 0 0 > > > Having a way to change the default will likely be extremely helpful. Thanks. I'd like to add a command line option like 'transparent_hugepage_shmem' to control the default value.