From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 998F3C3F2C6 for ; Wed, 4 Mar 2020 02:20:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5289520661 for ; Wed, 4 Mar 2020 02:20:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="ldXQ0oXs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5289520661 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CC4046B0003; Tue, 3 Mar 2020 21:20:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C4DFE6B0005; Tue, 3 Mar 2020 21:20:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AEE286B0006; Tue, 3 Mar 2020 21:20:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0142.hostedemail.com [216.40.44.142]) by kanga.kvack.org (Postfix) with ESMTP id 938406B0003 for ; Tue, 3 Mar 2020 21:20:53 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 7853B18EEE for ; Wed, 4 Mar 2020 02:20:53 +0000 (UTC) X-FDA: 76556076786.13.women03_41ef4378ae63b X-HE-Tag: women03_41ef4378ae63b X-Filterd-Recvd-Size: 4445 Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Wed, 4 Mar 2020 02:20:52 +0000 (UTC) Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0242EQs6115587; Wed, 4 Mar 2020 02:20:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=eFV22HHbaKS3x4oCXdEGLU9J7x32IJMaz4nLH/50CKY=; b=ldXQ0oXseOkrVwoFUqOm38qMWTBNGcWWvh1F5sNpQ/9VXKfzyuaKPuEnE6NpzPNL5MUt gCRnGpdiFuXh19j6Wrlpf9lLf8wkUgl7iqfwPa3r7gUU+npDIe5pMpxZ7JOLJw8xR/pF efoBZrVcwrWXL0F4r14ztKzPihyzNs73fy1d+15QYs1ccat7AiP54zZdbgigGizJEKv9 RL035gIDa3TtdTKXsj7JZIUQW5CSYlp/3oOutDAG4NZwh7Q7MrSg0Fp/n8MpitKiUg/u UKT0OdL3gRymmdFGd70dm7t56dTDgrpVRCmmxFASBkiA81XexJ1s7XnjqEs0JhdUunoK lg== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 2yffwqu8w6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Mar 2020 02:20:50 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0242IUDI155317; Wed, 4 Mar 2020 02:20:50 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 2yg1p624wd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Mar 2020 02:20:49 +0000 Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 0242Kn0h000787; Wed, 4 Mar 2020 02:20:49 GMT Received: from [192.168.1.206] (/71.63.128.209) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 03 Mar 2020 18:20:48 -0800 Subject: Re: [PATCH] mm/hugetlb.c: Clean code by removing unnecessary initialization To: mateusznosek0@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org References: <20200303212354.25226-1-mateusznosek0@gmail.com> From: Mike Kravetz Message-ID: <87d405de-d73b-9ba9-1644-c2222881ed98@oracle.com> Date: Tue, 3 Mar 2020 18:20:47 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200303212354.25226-1-mateusznosek0@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9549 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 mlxlogscore=999 mlxscore=0 spamscore=0 adultscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003040015 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9549 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 spamscore=0 impostorscore=0 malwarescore=0 mlxlogscore=999 mlxscore=0 suspectscore=0 phishscore=0 clxscore=1011 bulkscore=0 adultscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003040015 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000051, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/3/20 1:23 PM, mateusznosek0@gmail.com wrote: > From: Mateusz Nosek > > Previously variable 'check_addr' was initialized, > but was not read later before reassigning. > So the initialization can be removed. > > Signed-off-by: Mateusz Nosek Thanks, that is indeed not needed. Reviewed-by: Mike Kravetz -- Mike Kravetz > --- > mm/hugetlb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index e4116385a4e1..7fb31750e670 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -5021,7 +5021,7 @@ static bool vma_shareable(struct vm_area_struct *vma, unsigned long addr) > void adjust_range_if_pmd_sharing_possible(struct vm_area_struct *vma, > unsigned long *start, unsigned long *end) > { > - unsigned long check_addr = *start; > + unsigned long check_addr; > > if (!(vma->vm_flags & VM_MAYSHARE)) > return; >