From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6F2AC04A6A for ; Thu, 3 Aug 2023 14:36:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1FB6028026D; Thu, 3 Aug 2023 10:36:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1AC0728022C; Thu, 3 Aug 2023 10:36:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 04BD328026D; Thu, 3 Aug 2023 10:36:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E645528022C for ; Thu, 3 Aug 2023 10:36:24 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A7E5D41257 for ; Thu, 3 Aug 2023 14:36:24 +0000 (UTC) X-FDA: 81083043888.09.75D77AF Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by imf22.hostedemail.com (Postfix) with ESMTP id 2AC99C0029 for ; Thu, 3 Aug 2023 14:36:20 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=U313M1uz; spf=pass (imf22.hostedemail.com: domain of colin.i.king@gmail.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=colin.i.king@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691073381; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kzLqXdsOToTJCAjPdHmcMFH6VhO+zYxqzF/B4ldzHXs=; b=PZPKt0ikmvPG5S84vVQYnCTSs37rzJfQF7KGrW4uHngSnALg7LbXL32JqD6KJaE3D5G3ON xP442DkMYqYFS7o9iwfix0t75FS34vVQ9zAV+Hd71xhV7kSnT/CY1YL1+ahwv1M0bsgT+/ mhf3C+VB8PAB/MXlbkjvVQ9hPUcH65c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691073381; a=rsa-sha256; cv=none; b=F+2F/QIX9KjHrvLv9K9mCYujFHtovZv/+FurtBmdjbx0Pqrrqsmtlu00FLUP1KuBfsX0V+ b0AnIuFyejXYfzrF6yhKDuGfJ3vrYbt3DN8g8OL8hDOrQ7YhjZFOYtf8f9+L7AsSPN7Pgy jOWVSbD4TzUofVJm/FoSvnR/EdXMEQg= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=U313M1uz; spf=pass (imf22.hostedemail.com: domain of colin.i.king@gmail.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=colin.i.king@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-3fe2bc27029so10703915e9.3 for ; Thu, 03 Aug 2023 07:36:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691073379; x=1691678179; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kzLqXdsOToTJCAjPdHmcMFH6VhO+zYxqzF/B4ldzHXs=; b=U313M1uzbuFj9Z1IG4LRMxUJXR3GU1wWRSg7e1fxJ1c3MDiZjviBufqo15cfY83nYs DrLL7FrL5Nu1Mv6iwBGRiL9o26dYlu+qbZDIId7hlX6czuNisGoMCyF8qBJz+f50T9eH Wos40edfnFTEZ+o4kosi+XQvZnBXD9/uWrZLkb3j/1RCo/vAhuFt64vB7LOU29Ma8xjc A7BxW+HR9IOuAsvwRfZyxeYXICoO2E78WAb2Kur3LhZ0i0O2c4sFqHhhLf4lSOXxbrtP MyWDnOljnzMdRS9W/PELffcyrW1LLQAadBpiknpiJccOcYgzdt5m5Bnd56NMqzvNfAwp MzyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691073379; x=1691678179; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kzLqXdsOToTJCAjPdHmcMFH6VhO+zYxqzF/B4ldzHXs=; b=lmeYiklgq9hwcEutDlr4rBBmTYIMiTkJ2vqb6+xjbvjP1FRheqt5IQGZx3kQysXxB1 Ry54zhm9lKVfaOprxttJe/EaCg8p9xHor4cRnhl7inBJmmyhhE7r79Ku/Dt+s3TJK9Lr 1KWZ0AVaq0eAxGZ4k+yi4mLUyaxj5PN/qCYp1eI3t5uq3ywocp6h3WJfR9QRdTxHGGUW jd1LFqSuTvr+LazrVamy/3jYDgOcEvgBJs6PDIPO4m2F9ptIMXK8b2vqS69RCFaiOTDH 0eTZhEWYItClxJWo2GtsutL0ATOEr5BOwcq+bUyhMxwb6ezAUEwlf/8KUgRzYM+yY3ZD E+dg== X-Gm-Message-State: ABy/qLbHwalXQ74x/1o4WpO89/fpyoXBwUBLru6i+NMVHTUnrNR04B05 YUw5ZvpY5PWN3xhGY4xtPnA= X-Google-Smtp-Source: APBJJlFn5pw7orVnGePFk3OzEZU0DDmLkD9qYF0MPhdQ8N1oP0zaleo8LZHSSHCjDwjVUP2T2X1XoA== X-Received: by 2002:a05:600c:2048:b0:3fe:2bb1:11ba with SMTP id p8-20020a05600c204800b003fe2bb111bamr6644892wmg.27.1691073378979; Thu, 03 Aug 2023 07:36:18 -0700 (PDT) Received: from [192.168.0.101] (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.googlemail.com with ESMTPSA id s4-20020a05600c044400b003fe24681b10sm4441228wmb.28.2023.08.03.07.36.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Aug 2023 07:36:18 -0700 (PDT) Message-ID: <87d361ca-7512-4451-016e-6c2e3cec2bfe@gmail.com> Date: Thu, 3 Aug 2023 15:36:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: Fwd: crash/hang in mm/swapfile.c:718 add_to_avail_list when exercising stress-ng Content-Language: en-US To: Aaron Lu , Bagas Sanjaya Cc: Andrew Morton , Linus Torvalds , Linux Kernel Mailing List , Linux Memory Management List References: <43765f2d-f486-8b00-7fb9-9eaea5045bfe@gmail.com> <20230803060646.GA87850@ziqianlu-dell> <20230803134106.GA130558@ziqianlu-dell> From: "Colin King (gmail)" In-Reply-To: <20230803134106.GA130558@ziqianlu-dell> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2AC99C0029 X-Rspam-User: X-Stat-Signature: xbcisz5euemt6dk18gwig74gqnh8mu63 X-Rspamd-Server: rspam03 X-HE-Tag: 1691073380-460803 X-HE-Meta: U2FsdGVkX1/ShFHGRXz1qonJ48o2RDY/UIQJoTE66BjfR1FQUXuWtt/1F/U9iKyeWHiDJryVsREJqgn6y593GkNaRYt6f2hSAeV8J5MtnQ0MayCb/i0ML8+AcQTbuD6zEUEA3APq3ClaIfM7foEYWqqT6tfwOJH5WS9xbPG0mDCC0YoTSLpjRBQ+ge1gkxk2UdTGpRU860lZm+i6J2IRCI2BkPobxGaHMsRS9hyz8qAL/pTa9lFI3W09q7hhpT5ndrOLLpgd54iGwn0hNoI+umD4RFDiXNJg078e9hM2wwTJzI7cADlO8OidlI8wxZU6epCS71dBxAiPBm1zH4VuQfGtAnG2Bb3vb/k9TvGFDOgnluu5C2Yt04BMIoAh8dz94nnWFn3KrHrGhjNi1fx00UhehqiJS98MnBvcEMayiY20t3AQcOCrae/mssl3qHVx9aoYcW1h6/4tG/iVA2Mkjtms+LNkpdVfB2hOmpgb1S1c/WUIXp6Q9jb7/Z46CMtGp7fNwHfEJmJ2QrYpxQg8c6HWwFEyzhAciv5F1x9CxdKpXh2lOnu/3GFWd11/EPS5QGqqWoI7/ioFvU8TrqCW5eJEda46jlZmizqSPafjhe3yitiAqTEklk426MFwgtgFeOGsyMMlncwZAvmkIFx2g0uWUADizlcrS9pBO8nwjUSy9RCcwYxC1pRkuCYfM4av3AUKVOJ4EgLeXMFf0WOySFr1689K80rRweTPPKJKotH2Kx8tUTyjminMIGN8FgzLJVXVCzLuDuMJ0VkVGvY2DIBV/bjAI7u//JIixciihNJlbutuG4z8opE8MpyhleFSIU+GFzEQKaZBek+ivCpVZ8x1NMpAfXXZ/znYb//Vw+TrLAmT7YSNGmVXh1bPHY9B2MZa+bd3WLy1iTgiN3BfOFe47vcUtiwUTDsarYOccT6EAHmzOtHsAziUcoYiPTGndqxAKR0UpjE8Y6yd11I NKabSpf4 afJSBc/N38U3lI3lSm3tKsHpHQmP9U1GKXsaKH4rY+7IyfCG8rO33m11Zvv9A8MLDB35OxZyREXx6zj6KtqUYC27H7kABUo5cnTHnjYypcsSaIshtzCpn3HWuYDsE+XDdmVuPmiwv5/8k7wUEOj1vuNB93e8P7RH+B/iileK73tPMFzT8soReBMBCHhqP7UlWDidPFO+BtA0dwy8APkzagO+KpVaUMidI2btqTX/DxC//xDhONkSst2/FueFfWuKWdf1zjaj7C/L0+UyD8qzfmziyFEt2HkDd7uuMTvCxCdbbqOJ2zY2k7MTWZjRBUdliNVzTvSLof5e6Js3ld92MdgQiHLMwR7d4WVy0aZdeHFKIUK6eVaQHfhRDVfoQ9BhLj5WqdqoQ53RgRovG5KeYJ1g3vQayqTumPhgb/uIaZ3bCVMW4QQqmueOvRtB7QrnuOnZrzKQSgak5+wL5E7zL4O58ML0TS/hdNkiUTV/w/oL/EvBLJpwGKoLU1zVRETIPXUNWmKRDnGg1ZkdJ2bXSF3y4TjJuEx7k9/o24WgJHlZICDA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Aaron, Thanks for the speedy fix. I've tested this for a couple of 10 minute soak test and can't reproduce the issue with the fix, so it looks good to me, so please add: Tested-by: Colin Ian King Colin On 03/08/2023 14:41, Aaron Lu wrote: > On Thu, Aug 03, 2023 at 02:06:46PM +0800, Aaron Lu wrote: >> On Wed, Aug 02, 2023 at 07:54:38PM +0700, Bagas Sanjaya wrote: >>> Hi, >>> >>> I notice a bug report on Bugzilla [1]. Quoting from it: >>> >>>> How to reproduce: >>>> >>>> Had 24 CPU Alderlake 16GB debian12 system running with default kernel (from makecondig) on 6.5-rc4, exercised with no swap to start with. >>>> >>>> using stress-ng tip commit 0f2ef02e9bc5abb3419c44be056d5fa3c97e0137 >>>> (see https://github.com/ColinIanKing/stress-ng ) >>>> >>>> build and run stress-ng for say 60 minutes: >>>> >>>> ./stress-ng --cpu-online 50 --brk 50 --swap 50 --vmstat 1 -t 60m >>>> >>>> Will hang in mm/swapfile.c:718 add_to_avail_list+0x93/0xa0 >>>> >>>> See attached file for an image of the console on the hang (I'm trying to get the full stack dump). >>> >>> See Bugzilla for the full thread and attached console image. >>> >>> FWIW, I have to forward this bug report to the mailing lists because >>> Thorsten noted that many developers don't take a look on Bugzilla >>> (see the BZ thread). >> >> Thanks. >> >> I can reproduce this issue using below cmdline: >> $ sudo ./stress-ng --brk 50 --swap 5 --vmstat 1 -t 60m >> >> I'll investigate what is happening. > > Hi Colin, > > Can you try the below diff on top of v6.5-rc4? It works for me here > although I got the warn in a different place in get_swap_pages(): > > WARN(!si->highest_bit, > "swap_info %d in list but !highest_bit\n", > si->type); > > I think the warn you got in add_to_avail_list() due to the swap device > is already in the list is similar, see below explanation. > > diff --git a/mm/swapfile.c b/mm/swapfile.c > index 8e6dde68b389..cb7e93ec1933 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -2330,7 +2330,8 @@ static void _enable_swap_info(struct swap_info_struct *p) > * swap_info_struct. > */ > plist_add(&p->list, &swap_active_head); > - add_to_avail_list(p); > + if (p->highest_bit) > + add_to_avail_list(p); > } > > static void enable_swap_info(struct swap_info_struct *p, int prio, > > The finding is, if a swap device failed to be swapoff, then it will be > reinsert_swap_info() -> _enable_swap_info() -> add_to_avail_list(). The > problem is, this swap device may run out of space with its highest_bit > being 0 and shouldn't be added to avail list. In your case, once its > highest_bit becomes non-zero, it will go through add_to_avail_list() > and since it's already in the list, thus the warn. > > If it works for you, I'll prepare a patch. Thanks.