From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF95FC2D0F4 for ; Thu, 2 Apr 2020 01:49:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AE603206D3 for ; Thu, 2 Apr 2020 01:49:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE603206D3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4816E8E0008; Wed, 1 Apr 2020 21:49:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 409E38E0007; Wed, 1 Apr 2020 21:49:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F8758E0008; Wed, 1 Apr 2020 21:49:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0222.hostedemail.com [216.40.44.222]) by kanga.kvack.org (Postfix) with ESMTP id 13F318E0007 for ; Wed, 1 Apr 2020 21:49:40 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id CFF8F4404 for ; Thu, 2 Apr 2020 01:49:39 +0000 (UTC) X-FDA: 76661233278.04.page70_1a0f102aa630c X-HE-Tag: page70_1a0f102aa630c X-Filterd-Recvd-Size: 2699 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Thu, 2 Apr 2020 01:49:38 +0000 (UTC) IronPort-SDR: GLEHcey8sQSAmwSrj1PuKiY0fjdrMMiildt8hbTEsKcpV1EryGmKJGrX78iJprHiqxJySHgh/1 V+20t4au0s8g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2020 18:49:37 -0700 IronPort-SDR: i/S/kqoV2XLfBcwuoAcph+w+D88RFxrkZjVZtRZv5s53U84lBAZQQw30Fzqo4O9Ng7LQH46v71 4FzN8VKLfKzA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,333,1580803200"; d="scan'208";a="396191444" Received: from yhuang-dev.sh.intel.com (HELO yhuang-dev) ([10.239.159.23]) by orsmga004.jf.intel.com with ESMTP; 01 Apr 2020 18:49:34 -0700 From: "Huang\, Ying" To: Zi Yan Cc: Andrew Morton , , , Andrea Arcangeli , "Kirill A . Shutemov" , Vlastimil Babka , Alexey Dobriyan , Michal Hocko , Konstantin Khlebnikov , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Yang Shi Subject: Re: [PATCH] /proc/PID/smaps: Add PMD migration entry parsing References: <20200331085604.1260162-1-ying.huang@intel.com> <965DC015-7D6F-430D-8FB7-A24A814C13BE@nvidia.com> Date: Thu, 02 Apr 2020 09:49:33 +0800 In-Reply-To: <965DC015-7D6F-430D-8FB7-A24A814C13BE@nvidia.com> (Zi Yan's message of "Tue, 31 Mar 2020 08:24:07 -0400") Message-ID: <87d08qhd1u.fsf@yhuang-dev.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Zi Yan writes: > On 31 Mar 2020, at 4:56, Huang, Ying wrote: >> >> From: Huang Ying >> - /* FOLL_DUMP will return -EFAULT on huge zero page */ >> - page = follow_trans_huge_pmd(vma, addr, pmd, FOLL_DUMP); >> + if (pmd_present(*pmd)) { >> + /* FOLL_DUMP will return -EFAULT on huge zero page */ >> + page = follow_trans_huge_pmd(vma, addr, pmd, FOLL_DUMP); >> + } else if (unlikely(is_swap_pmd(*pmd))) { > > Should be: > } else if (unlikely(thp_migration_support() && is_swap_pmd(*pmd))) { Thought this again. This can reduce the code size if thp_migration_support() isn't enabled. I will do this in the next version. Best Regards, Huang, Ying