From: "Huang\, Ying" <ying.huang@intel.com>
To: Zi Yan <ziy@nvidia.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
"Andrea Arcangeli" <aarcange@redhat.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Alexey Dobriyan" <adobriyan@gmail.com>,
"Michal Hocko" <mhocko@suse.com>,
"Konstantin Khlebnikov" <khlebnikov@yandex-team.ru>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Yang Shi" <yang.shi@linux.alibaba.com>
Subject: Re: [PATCH] /proc/PID/smaps: Add PMD migration entry parsing
Date: Thu, 02 Apr 2020 09:49:33 +0800 [thread overview]
Message-ID: <87d08qhd1u.fsf@yhuang-dev.intel.com> (raw)
In-Reply-To: <965DC015-7D6F-430D-8FB7-A24A814C13BE@nvidia.com> (Zi Yan's message of "Tue, 31 Mar 2020 08:24:07 -0400")
Zi Yan <ziy@nvidia.com> writes:
> On 31 Mar 2020, at 4:56, Huang, Ying wrote:
>>
>> From: Huang Ying <ying.huang@intel.com>
>> - /* FOLL_DUMP will return -EFAULT on huge zero page */
>> - page = follow_trans_huge_pmd(vma, addr, pmd, FOLL_DUMP);
>> + if (pmd_present(*pmd)) {
>> + /* FOLL_DUMP will return -EFAULT on huge zero page */
>> + page = follow_trans_huge_pmd(vma, addr, pmd, FOLL_DUMP);
>> + } else if (unlikely(is_swap_pmd(*pmd))) {
>
> Should be:
> } else if (unlikely(thp_migration_support() && is_swap_pmd(*pmd))) {
Thought this again. This can reduce the code size if
thp_migration_support() isn't enabled. I will do this in the next
version.
Best Regards,
Huang, Ying
next prev parent reply other threads:[~2020-04-02 1:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 8:56 Huang, Ying
2020-03-31 9:51 ` Konstantin Khlebnikov
2020-04-01 2:31 ` Huang, Ying
2020-04-01 6:03 ` Konstantin Khlebnikov
2020-04-01 6:20 ` Huang, Ying
2020-03-31 12:24 ` Zi Yan
2020-04-01 2:24 ` Huang, Ying
2020-04-01 2:42 ` Zi Yan
2020-04-02 1:49 ` Huang, Ying [this message]
2020-04-01 23:04 ` Andrew Morton
2020-04-02 1:42 ` Huang, Ying
2020-04-02 6:27 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d08qhd1u.fsf@yhuang-dev.intel.com \
--to=ying.huang@intel.com \
--cc=aarcange@redhat.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jglisse@redhat.com \
--cc=khlebnikov@yandex-team.ru \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=vbabka@suse.cz \
--cc=yang.shi@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox