From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 627ADC433EF for ; Mon, 2 May 2022 09:20:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA0266B0072; Mon, 2 May 2022 05:20:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B50C56B0073; Mon, 2 May 2022 05:20:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A17926B0074; Mon, 2 May 2022 05:20:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 92A966B0072 for ; Mon, 2 May 2022 05:20:35 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 555AC81B8F for ; Mon, 2 May 2022 09:20:35 +0000 (UTC) X-FDA: 79420257630.26.C987BCD Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf22.hostedemail.com (Postfix) with ESMTP id 8DB07C0071 for ; Mon, 2 May 2022 09:20:33 +0000 (UTC) From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1651483232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rzfdL55sKTwT/KWa9oyx9CtM+emKdBvooXpdLahQrpU=; b=j8CmyZoLzBOC0GXUd5JxjOeb0G3xhiKAMqdvpix3YrULTPsGMUg8u2dkETM4tANAnK2hQt VwOo0gJvZs+/ifhnW7U2L9Caf5r8VNTP7lUfnh4BMffWqMBn8QoJG6v5guk50DtPfAOMpR YzrHkf/dbt8N1GhtNgWtf0T5vgGGBiPJSiJDM3wxgyPBon6UIwfXxELweaBEeokBpJTVZe w4HQOJkgIrwq5UQebHJEK4PnuBraQ7D3/XBEn0LZgSbivVIKJpRRWuvnuUgHxF4Rq+2MUM uXMmVh/GGpgyVFxM6CDXFCyt6eS2sCmnGh2OJNaHPymdaMaGwkv4GRn12RIHJA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1651483232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rzfdL55sKTwT/KWa9oyx9CtM+emKdBvooXpdLahQrpU=; b=ypr5ktzoRR9yKPEgwzApJC1WmvpkyzQ9I1B6fwNKOqIWB5S1Ua0CEpFbf0/mUuc3CViB8t VuZ9NafLOLpuHZCg== To: Petr Mladek , Marco Elver Cc: Naresh Kamboju , Linux-Next Mailing List , open list , lkft-triage@lists.linaro.org, linux-mm , Andrew Morton , Alexander Potapenko , Dmitry Vyukov , Stephen Rothwell , Anders Roxell , Andrey Konovalov , Andrey Ryabinin , Catalin Marinas , Evgenii Stepanov , Mark Rutland , Peter Collingbourne , Vincenzo Frascino , Will Deacon Subject: Re: [next] i386: kunit: ASSERTION FAILED at mm/kfence/kfence_test.c:547 In-Reply-To: References: <87fslup9dx.fsf@jogness.linutronix.de> Date: Mon, 02 May 2022 11:26:31 +0206 Message-ID: <87czgwmgtc.fsf@jogness.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8DB07C0071 X-Stat-Signature: nd4meqnyy9uqgzx6hwon4iep7c9y3unj X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=j8CmyZoL; dkim=pass header.d=linutronix.de header.s=2020e header.b=ypr5ktzo; spf=pass (imf22.hostedemail.com: domain of john.ogness@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=john.ogness@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de X-HE-Tag: 1651483233-395584 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022-05-02, Petr Mladek wrote: >> My proposal would be to fix the tracepoint like so: >> >> | --- a/kernel/printk/printk.c >> | +++ b/kernel/printk/printk.c >> | @@ -2002,8 +2002,6 @@ static void call_console_driver(struct console *con, const char *text, size_t le >> | { >> | size_t dropped_len; >> | >> | - trace_console_rcuidle(text, len); >> | - >> | if (con->dropped && dropped_text) { >> | dropped_len = snprintf(dropped_text, DROPPED_TEXT_MAX, >> | "** %lu printk messages dropped **\n", >> | @@ -2178,6 +2176,8 @@ static u16 printk_sprint(char *text, u16 size, int facility, >> | } >> | } >> | >> | + trace_console_rcuidle(text, text_len); >> | + >> | return text_len; >> | } >> >> This fixes the KFENCE and KCSAN tests. >> >> Unless I hear objections, I'll prepare a patch explaining why we need to >> fix the tracepoint. > > It makes perfect sense to me. This is the easiest place for it. However, it should be clear that in the context of trace_console_rcuidle(), the message is not yet visible to any readers. The message _will_ get committed and definitely _will_ become visible at some point. But it is not (yet) visible at _this_ point. Maybe that is OK for what it is being used for. If trace_console_rcuidle() must be called at the point of visibility for readers, it becomes more complicated. John