From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09A2CC00140 for ; Mon, 8 Aug 2022 11:42:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D211C8E0002; Mon, 8 Aug 2022 07:42:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CCF958E0001; Mon, 8 Aug 2022 07:42:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B725D8E0002; Mon, 8 Aug 2022 07:42:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A4A718E0001 for ; Mon, 8 Aug 2022 07:42:57 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7EF76C0D31 for ; Mon, 8 Aug 2022 11:42:57 +0000 (UTC) X-FDA: 79776238794.24.8F60335 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf27.hostedemail.com (Postfix) with ESMTP id 083C040165 for ; Mon, 8 Aug 2022 11:42:56 +0000 (UTC) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1659958974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hxz5dJVKmW1JnSAUI9gZLzzxb4GJLXHvw8kFzNX5wd8=; b=P78VbJbhlFpuaRdoY0rRdSHkrmwFXjGAEcXUPHpzToAtrbtJ6quuzWFygkHUaZ/YKn23iH m3hOn3lyMu4XvNbNIm9x3rjaezSOFFoCQryOSpvkCmBS5sPR0foKFa4ImSNp13avNWIMU1 NapzLVC2AF45f6exFgL5eDAE/ElbAjlIlHQZ6ZnvDw2s125p9Q5/iSnf9WaDQ4Z2wswrDZ i1+u07p8TefWOpGDTxKLVKSk8cV1nbwFtPw/jW6vlogwWf4JNNj6F5755wcIPgACCA5M+s 5eytNX+JviKrGszvF3B3CaReaRI5fqiwy/YRzW/zQen+EOXXnlykC1XYrAiyqQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1659958974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hxz5dJVKmW1JnSAUI9gZLzzxb4GJLXHvw8kFzNX5wd8=; b=m4hEevSGgE4U5+5naPIR6UURVhQTYZGLM8RMnmVGdjavu7mQqxWW7wFigJsRGGYEB+XDxD phOWpBmu6yN2RMBg== To: Yury Norov , linux-kernel@vger.kernel.org, Alexander Lobakin , Alexei Starovoitov , Alexey Klimov , Andrew Morton , Andrii Nakryiko , Andy Shevchenko , Ben Segall , Christoph Lameter , Dan Williams , Daniel Borkmann , Daniel Bristot de Oliveira , Dennis Zhou , Dietmar Eggemann , Eric Dumazet , Frederic Weisbecker , Guenter Roeck , Ingo Molnar , Isabella Basso , John Fastabend , Josh Poimboeuf , Juergen Gross , Juri Lelli , KP Singh , Kees Cook , Martin KaFai Lau , Mel Gorman , Miroslav Benes , Nathan Chancellor , "Paul E . McKenney" , Peter Zijlstra , Randy Dunlap , Rasmus Villemoes , Sebastian Andrzej Siewior , Song Liu , Steven Rostedt , Tejun Heo , Valentin Schneider , Vincent Guittot , Vlastimil Babka , Yonghong Song , Yury Norov , linux-mm@kvack.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH 11/16] time: optimize tick_check_preferred() In-Reply-To: <87fsi9rcxu.ffs@tglx> References: <20220718192844.1805158-1-yury.norov@gmail.com> <20220718192844.1805158-12-yury.norov@gmail.com> <87fsi9rcxu.ffs@tglx> Date: Mon, 08 Aug 2022 13:42:54 +0200 Message-ID: <87czdbq7up.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659958977; a=rsa-sha256; cv=none; b=iPGpF11vJ6GKEGj5Gz2rcj1JXiAT1tRQXhWKBWtbNcWgHtPUdBBX1LGt9nN10RRA2vrm22 IBX/GKb2YALbs2yNrX2f9/FZCph7bEqEKI9Rg3byU1dWxCY2pKQZtnm0BXUzJwGDwZKBJf Ziktzi6SUlgyvcJGDV4cd20FYTWAo0w= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=P78VbJbh; dkim=pass header.d=linutronix.de header.s=2020e header.b=m4hEevSG; spf=pass (imf27.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659958977; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hxz5dJVKmW1JnSAUI9gZLzzxb4GJLXHvw8kFzNX5wd8=; b=iVO70wJE9DBhaJ3wg5cgRcLab3dW/DCisYpv96JYyqU1oB0HGh4AEB7WKTbZ5NmKPTli7i COWT1TK4bwwARw0KqR9biuUzw6/bUw/2jRJBzZ9JjfQG2GPG1STWuxD65LYa5kHOG1N5cj D+nejzRrCL5FmI7y0yVYda2sohto0H8= X-Stat-Signature: aee5fuiy8cko1oawqma8yk3qseio5aay X-Rspamd-Queue-Id: 083C040165 Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=P78VbJbh; dkim=pass header.d=linutronix.de header.s=2020e header.b=m4hEevSG; spf=pass (imf27.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1659958976-44458 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Aug 06 2022 at 10:30, Thomas Gleixner wrote: > On Mon, Jul 18 2022 at 12:28, Yury Norov wrote: > >> tick_check_preferred() calls cpumask_equal() even if >> curdev->cpumask == newdev->cpumask. Fix it. > > What's to fix here? It's a pointless operation in a slow path and all > your "fix' is doing is to make the code larger. In fact cpumask_equal() should have the ptr1 == ptr2 check, so you don't have to add it all over the place. Thanks, tglx